Re: [dev] [st] Segmentation fault when clicking the top of window

2013-03-27 Thread Christoph Lohmann
Greetings. On Wed, 27 Mar 2013 22:56:12 +0100 Markus Teich wrote: > Nope, > > Juhani's report seems to be from the 0.3 release. > The bug has already been fixed in commit abe85c0e on Nov 3 2012 (one day > after the 0.3 release). > Maybe it is time for 0.4? ;) It is, I only have to integrate so

Re: [dev] [st] Segmentation fault when clicking the top of window

2013-03-27 Thread Markus Teich
Nope, Juhani's report seems to be from the 0.3 release. The bug has already been fixed in commit abe85c0e on Nov 3 2012 (one day after the 0.3 release). Maybe it is time for 0.4? ;) --Markus Am 27.03.2013 21:48, schrieb Christoph Lohmann: > Greetings. > > On Wed, 27 Mar 2013 21:48:14 +0100 Mar

Re: [dev] [st] Segmentation fault when clicking the top of window

2013-03-27 Thread Christoph Lohmann
Greetings. On Wed, 27 Mar 2013 21:48:14 +0100 Markus Teich wrote: > Am 27.03.2013 08:41, schrieb Christoph Lohmann: > > I thought you would fix the segfault, but instead all I got was a lousy > > XML file. :/ > > problem: > in config.h borderpx is declared as an unsigned int. > in the bpress(X

RE: [dev] [DWM] Patch: stack mfact

2013-03-27 Thread Jente Hidskes
The patch is already up on dwm.suckless.org/patches, including the issues it has. Do note that it _only_ crashes when there are 30+ clients in the _stack_. Monocle is not affected. I agree that a patch which introduces a crash (even with the unlikely case in which there's 30+ clients in the stac

Re: [dev] [DWM] Patch: stack mfact

2013-03-27 Thread Carlos Torres
On Wed, Mar 27, 2013 at 10:41 AM, Raphael Proust wrote: > On Wed, Mar 27, 2013 at 1:17 PM, Jente Hidskes wrote: >> You're right - I should not have submitted the patch with a bug that would >> crash DWM. However, it was only with seven clients or more and as I rarely >> have more than 3 open at o

Re: [dev] [DWM] Patch: stack mfact

2013-03-27 Thread Raphael Proust
On Wed, Mar 27, 2013 at 1:17 PM, Jente Hidskes wrote: > You're right - I should not have submitted the patch with a bug that would > crash DWM. However, it was only with seven clients or more and as I rarely > have more than 3 open at once, for me it wasn't that big of an issue. I have > now fixed

RE: [dev] [DWM] Patch: stack mfact

2013-03-27 Thread Jente Hidskes
You're right - I should not have submitted the patch with a bug that would crash DWM. However, it was only with seven clients or more and as I rarely have more than 3 open at once, for me it wasn't that big of an issue. I have now fixed it, though. I did that by having setsmfact() check the amou

Re: [dev] [st] Segmentation fault when clicking the top of window

2013-03-27 Thread Markus Teich
Am 27.03.2013 08:41, schrieb Christoph Lohmann: > I thought you would fix the segfault, but instead all I got was a lousy > XML file. :/ problem: in config.h borderpx is declared as an unsigned int. in the bpress(XEvent* e) function Y2ROW(e->xbutton.y) is called and gets expanded to: (((e->xbutto

Re: [dev] [DWM] Patch: stack mfact

2013-03-27 Thread Raphael Proust
On Tue, Mar 26, 2013 at 7:17 PM, Jente Hidskes wrote: > First of all, when there is an X number of clients in the stack and smfact > (stackmfact) is increased too much, it will crash DWM. This could be fixed > by having setsmfact() detect the amount of stacked clients and having it set > a limit t

Re: [dev] [st] Segmentation fault when clicking the top of window

2013-03-27 Thread Christoph Lohmann
Greetings. On Wed, 27 Mar 2013 08:41:53 +0100 Markus Teich wrote: > Heyho, > > Thanks! I managed to reproduce this bug in a VM on OpenBSD 5.2. > The difficult part was to get my debugging system to work on OpenBSD, > but i figured it out and finally got a report (see attachement). > > If you h