Re: [dev] [st] Unexpected Insert key behavior in mc

2012-12-10 Thread Roberto E. Vargas Caballero
> Since we had these two discussions goin on parallel, my guts told me > to revert my patch to config.h today. Then I did something a bit > different. It now works for both sandy and mc correctly, likewise for > DEL, INS and HOME which were making trouble yesterday. Attached is the > patch which wo

Re: [dev] [st] Unexpected Insert key behavior in mc

2012-12-10 Thread Martti Kühne
On Mon, Dec 10, 2012 at 3:43 PM, Roberto E. Vargas Caballero wrote: > > Could you send here the output of infocmp command?. If Insert or delete are > not > working is due some mismatch between the values generated by st and the > terminfo entry. For delete the important value is dhc1, that should

Re: [dev] [st] [patch] alternate screen selection bugfix

2012-12-10 Thread Christoph Lohmann
Greetings. On Mon, 10 Dec 2012 20:46:11 +0100 p37si...@lavabit.com wrote: > Patch is attached. Thank you very much for this patch! That was a really nasty bug. Of course the patch is now applied in tip. Sincerely, Christoph Lohmann

Re: [dev] [st] delete key didn't work correctly

2012-12-10 Thread Roberto E. Vargas Caballero
> On my machine, just toggling the keypad values on the delete lines > worked at first (the ordering of them doesn't seem to matter for me), > but then I did a make install and they stopped working. I copied over > some old versions of st terminfo files (I can't remember from when) > and they start

Re: [dev] [st] Unexpected Insert key behavior in mc

2012-12-10 Thread Roberto E. Vargas Caballero
> > I did "git pull" before compiling today. Since I did not do install > > previously > > I have tested it after doing install, thus with updated terminfo, it still > > does > > not work correctly. My term is st-256color . > > > > same here with st-256color. > > I'm half way planning to look int

Re: [dev] [st] Unexpected Insert key behavior in mc

2012-12-10 Thread Christoph Lohmann
Greetings. On Mon, 10 Dec 2012 15:05:42 +0100 Martti Kühne wrote: > On Mon, Dec 10, 2012 at 1:39 PM, Edgaras wrote: > >> > >> I have tested it with the HEAD and works fine for me. What value of TERM > >> do you have?, and > >> are you sure you have installed last version of the terminfo definit

[dev] [st] [patch] alternate screen selection bugfix

2012-12-10 Thread p37sitdu
To trace the glitch, I added fprintf(stderr, "%d %d\n", sel.alt, !!IS_SET(MODE_ALTSCREEN)); into the draw() function. What happens: 1. Start st. Type something: both sel.alt and IS_SET(MODE_ALTSCREEN) are 0. 2. Run "man man". MODE_ALTSCREEN is set to 1. 3. Press LMB. sel.alt is 0, MODE_ALTSCR

Re: [dev] [st] Unexpected Insert key behavior in mc

2012-12-10 Thread Martti Kühne
On Mon, Dec 10, 2012 at 1:39 PM, Edgaras wrote: >> >> I have tested it with the HEAD and works fine for me. What value of TERM do >> you have?, and >> are you sure you have installed last version of the terminfo definition?. >> > I did "git pull" before compiling today. Since I did not do install

Re: [dev] [st] Unexpected Insert key behavior in mc

2012-12-10 Thread Edgaras
On Mon, Dec 10, 2012 at 12:32:58PM +0100, Roberto E. Vargas Caballero wrote: > > It seems that in current version of st it is impossible to select files in > > mc > > using Insert key, instead it enters "4h" in command prompt. I do not know > > why > > this happens, but I know that this did not h

Re: [dev] [st] delete key didn't work correctly

2012-12-10 Thread Daniel Bainton
On 10 December 2012 13:27, Roberto E. Vargas Caballero wrote: >> Now, st's delete key didn't work, and I looked into the code long enough to >> say with confidence, there's nothing wrong with kmap(). > > I can see that you change the order of Delete definitions in your > patch. Theoretically this

Re: [dev] [st] Unexpected Insert key behavior in mc

2012-12-10 Thread Roberto E. Vargas Caballero
> It seems that in current version of st it is impossible to select files in mc > using Insert key, instead it enters "4h" in command prompt. I do not know why > this happens, but I know that this did not happen in 0.2. I have tested it with the HEAD and works fine for me. What value of TERM do yo

Re: [dev] [st] delete key didn't work correctly

2012-12-10 Thread Roberto E. Vargas Caballero
> Now, st's delete key didn't work, and I looked into the code long enough to > say with confidence, there's nothing wrong with kmap(). I can see that you change the order of Delete definitions in your patch. Theoretically this should not work because the keypdap column is different. If your patch

Re: [dev] [st] Unexpected Insert key behavior in mc

2012-12-10 Thread Martti Kühne
On Mon, Dec 10, 2012 at 10:08 AM, Edgaras wrote: > It seems that in current version of st it is impossible to select files in mc > using Insert key, instead it enters "4h" in command prompt. I do not know why > this happens, but I know that this did not happen in 0.2. > Seems this is another shor

[dev] [st] Unexpected Insert key behavior in mc

2012-12-10 Thread Edgaras
It seems that in current version of st it is impossible to select files in mc using Insert key, instead it enters "4h" in command prompt. I do not know why this happens, but I know that this did not happen in 0.2.