Re: [dev] [st] Tip adds non-existing trailing whitespace upon mouse selection + fix

2012-10-09 Thread hiro
pancake: even in my urxvt copying text never works reliably, so I always end up repeating what I did in 9term and copy-pasting from there. dumb, ugly, useless, annoying shit. vts suck.

[dev] [st] toggle font

2012-10-09 Thread stanio
Hi, This patch (against tip) introduces an array of font names in the config instead FONT and allows to cycle through them with Ctrl-PgUp at runtime. I missed this feature a lot when light conditions and distance to display change, often so with a notebook, even more when different displays plugg

Re: [dev] dmenu - filename tab completion

2012-10-09 Thread E S
I just updated the patch file myself. The cursor stays at the position before the text has been added from the tab completion, which isn't the most desirable. But, it works. The updated patch can be found at https://gist.github.com/3861386. I might delve into this further to make it behave more int

Re: [dev] [st] Tip adds non-existing trailing whitespace upon mouse selection + fix

2012-10-09 Thread Aurélien Aptel
On Tue, Oct 9, 2012 at 7:03 PM, Roberto E. Vargas Caballero wrote: > Solution of copying all the characters needs some work, because I agree it > sucks > when you copy this non existing leading paces. I think the solution should be > a > variable by line saying maximum column written in it. I th

Re: [dev] dmenu - filename tab completion

2012-10-09 Thread Martti Kühne
On Tue, Oct 9, 2012 at 7:47 PM, E S wrote: > I am looking for a patch that would implement file name tab completion for > dmenu. I found a patch (http://lists.suckless.org/dwm/0901/7355.html) which > appears to have been written for an older version of dmenu, but was > wondering if anyone knows of

Re: [dev] Adding utmpx stuff

2012-10-09 Thread Roberto E. Vargas Caballero
It is also necessary set WINDOWID, because it is the XWindow ID of the terminal. I suppouse w3m needs this variable to print images in the terminal.

Re: [dev] Adding utmpx stuff

2012-10-09 Thread Roberto E. Vargas Caballero
> How is this a possible security risk? St shouldn’t be used to control > login shells. It’s there to show escape sequences jump around on a > screen. The problem is that the terminal emulation is too much related to the pty stuff. The program who create the master/slave is the responsabl

[dev] dmenu - filename tab completion

2012-10-09 Thread E S
I am looking for a patch that would implement file name tab completion for dmenu. I found a patch (http://lists.suckless.org/dwm/0901/7355.html) which appears to have been written for an older version of dmenu, but was wondering if anyone knows of an updated patch for dmenu-4.5. Is there an updated

Re: [dev] Adding utmpx stuff

2012-10-09 Thread Roberto E. Vargas Caballero
> > And if SHELL is not set, st before this patch segfault. > > Actually, this is a simple check to just use »/bin/sh«. Which environ‐ > ment today does not have SHELL set? The code set SHELL only if is not set (3rd parameter of setenv). SHELL can be unset if a ugly user unset it ;).

Re: [dev] Adding utmpx stuff

2012-10-09 Thread Roberto E. Vargas Caballero
> That e‐mail has several reason to not support utmpx. The proposed patch > has the same size of an equal dbus interface that would call some kind > of logind. That’s the kind of cruft people complain about before they > start to reinvent it using Javascript or Go. xterm uses libutempter, wh

Re: [dev] Adding utmpx stuff

2012-10-09 Thread Christoph Lohmann
Greetings. On Tue, 09 Oct 2012 19:31:50 +0200 "Roberto E. Vargas Caballero" wrote: > > > > Relay in correct values of LOGNAME and USER is a security risk. If st > > doesn't check against /etc/passwd you can get who(1) shows other user as > > connected, for example. Usually these variables are se

Re: [dev] Adding utmpx stuff

2012-10-09 Thread Christoph Lohmann
Hello. On Tue, 09 Oct 2012 19:25:29 +0200 "Roberto E. Vargas Caballero" wrote: > > This patch is fixing something st shouldn’t do. In my environment all > > the environment variables you propose to add are set. That’s something > > the shell should do and not the terminal emulator. A term

Re: [dev] Adding utmpx stuff

2012-10-09 Thread Christoph Lohmann
Greetings. On Tue, 09 Oct 2012 19:20:53 +0200 "Anthony J. Bentley" wrote: > "Roberto E. Vargas Caballero" writes: > > This patch adds utmpx support in st, which means that st sessions > > will be visible using who or, who is the correct behaviour of a terminal > > emulator, but this means th

Re: [dev] Adding utmpx stuff

2012-10-09 Thread Roberto E. Vargas Caballero
> > Relay in correct values of LOGNAME and USER is a security risk. If st > doesn't check against /etc/passwd you can get who(1) shows other user as > connected, for example. Usually these variables are set by login(1), and > like a terminal emulator is doing the login job, setting these variables

Re: [dev] Adding utmpx stuff

2012-10-09 Thread Roberto E. Vargas Caballero
> This patch is fixing something st shouldn’t do. In my environment all > the environment variables you propose to add are set. That’s something > the shell should do and not the terminal emulator. A terminal emulator > should be neutral to this. Sorry, but I think you are fixing something

Re: [dev] Adding utmpx stuff

2012-10-09 Thread Anthony J. Bentley
"Roberto E. Vargas Caballero" writes: > This patch adds utmpx support in st, which means that st sessions > will be visible using who or, who is the correct behaviour of a terminal > emulator, but this means that the binary needs have setgid, which is > something we have to thing carefully. >

Re: [dev] Adding utmpx stuff

2012-10-09 Thread Christoph Lohmann
Hello. On Tue, 09 Oct 2012 19:09:36 +0200 "Roberto E. Vargas Caballero" wrote: > Hello, > > This patch adds utmpx support in st, which means that st sessions > will be visible using who or, who is the correct behaviour of a terminal > emulator, but this means that the binary needs have se

Re: [dev] [st] Tip adds non-existing trailing whitespace upon mouse selection + fix

2012-10-09 Thread Roberto E. Vargas Caballero
On Tue, Oct 09, 2012 at 04:07:54PM +0200, pancake wrote: > i feel this annoying too, but someone told me this was an > intentional behaviour. The problem is that tab characters means a movement of the cursor. so if you apply your patch and run something like: $ printf "a\tb" you will see in the

[dev] Adding utmpx stuff

2012-10-09 Thread Roberto E. Vargas Caballero
Hello, This patch adds utmpx support in st, which means that st sessions will be visible using who or, who is the correct behaviour of a terminal emulator, but this means that the binary needs have setgid, which is something we have to thing carefully. Other important about this

[dev] [st] fileio patch

2012-10-09 Thread Roberto E. Vargas Caballero
Improve the error handling writing to the fileio. >From 5321822f43782edfad107d71db558493552b3a65 Mon Sep 17 00:00:00 2001 From: "Roberto E. Vargas Caballero" Date: Tue, 9 Oct 2012 18:12:29 +0200 Subject: Add error control to iofile write can write less bytes than we request, so it is necessary ch

Re: [dev] [st] Tip adds non-existing trailing whitespace upon mouse selection + fix

2012-10-09 Thread pancake
i feel this annoying too, but someone told me this was an intentional behaviour. i'm used to xterm and iTerm2, and copypasting text with text selection is something I do many times (as well as scrolling), and this is behaviour of st is somewhat annoying. i vote for your patch to be upstream :

[dev] [st] Tip adds non-existing trailing whitespace upon mouse selection + fix

2012-10-09 Thread Rafa Garcia Gallego
Hi, Upon selecting text with the mouse, st tip fills the selection straight from its term matrix and replaces unset glyphs with a whitespace. This results in some really annoying trailing whitespace at the end of each line when you paste/pipe the selection. Is there any reason for this? The attac

Re: [dev] [dmenu] option to pin focus to mouse

2012-10-09 Thread Stanislav Seletskiy
Thanks for answer! Yep, your patch for dmenu looks like solution (and more general, than my). Why this patch is not in upstream yet? -- Stanislav Seletskiy

Re: [dev] [dmenu] option to pin focus to mouse

2012-10-09 Thread Martti Kühne
On Tue, Oct 9, 2012 at 12:54 PM, Martti Kühne wrote: > I had to write a patch [1] to make dmenu follow the active screen > instead of the mouse earlier. oops. The third mail in that thread by me links to the pair of patches I use. cheers! mar77i [1] http://comments.gmane.org/gmane.comp.misc.suc

Re: [dev] [dmenu] option to pin focus to mouse

2012-10-09 Thread Martti Kühne
On Mon, Oct 8, 2012 at 8:08 AM, Станислав Селецкий wrote: [...] > > I think it will be useful, if dmenu have an option to explicitly > specify that i want launch dmenu on the screen, that contains mouse > cursor. > > Trivial patch in the attachment. > > If there is more graceful way to achieve thi