Re: [dev] [dvtm] dvtm on aix

2010-11-21 Thread Ross Mohn
Success! After much debugging, I found and patched two bugs in the v0.6 code. I've got it working on AIX now, but I'm not fully satisfied with the forkpty-aix.c code so I won't post that piece yet unless others need it now. The first bug fix is to madtty.c. It wasn't causing the coredump, but was

[dev] Re: [dmenu] [patch] add xft and fix possible memory leak in version 4.2.1

2010-11-21 Thread Dan Brown
Connor Lane Smith wrote: >Would you be able to produce an Xft-only patch without filter >or tok? I'd also like to see if I can make the patch more "dmenu-like" >(just a few minor points) before we put it on the wiki or an Hg branch Connor- Attached is a patch that adds xft and cleanup routines to

Re: [dev] surf segfault

2010-11-21 Thread Jacob Todd
Probably because the patch wasn't applied to surf proper. On Nov 21, 2010 6:58 PM, "Martin Kopta" wrote: >> A patch for this issue has been posted several times. I have posted it >> at least twice, at least. > > And why is surf still broken? >

Re: [dev] surf segfault

2010-11-21 Thread Martin Kopta
> A patch for this issue has been posted several times. I have posted it > at least twice, at least. And why is surf still broken?

Re: [dev] surf segfault

2010-11-21 Thread Troels Henriksen
Gregor Best writes: > On Sun, Nov 21, 2010 at 02:46:00PM +0100, Martin Kopta wrote: >> [...] >> Why is in surf.c at line /gdk_draw_rectangle(w->window,/ the w->window null >> pointer? >> >> (gdb) p w >> $5 = (GtkWidget *) 0x7fd4d00225e0 >> (gdb) p w->window >> $6 = (GdkWindow *) 0x0 >> >> That

Re: [dev] git dmenu mirror with feature branches instead of separate patches

2010-11-21 Thread Dieter Plaetinck
On Sun, 21 Nov 2010 19:56:07 + Connor Lane Smith wrote: > On 21 November 2010 19:33, wrote: > > Another kinda heretic idea might be to have fairly feature-rich > > branches and feature-removing patches. Just thinking loud > > Trunk, a branch per patch, a spicy branch, and a plain branc

Re: [dev] Re: [dmenu] [patch] add xft and fix possible memory leak in version 4.2.1

2010-11-21 Thread Connor Lane Smith
On 21 November 2010 17:18, Dan Brown wrote: > This was the patch I used as an starting point for adding xft support. > After studying it, I came up with a few ways to simplify it that I > think you'll appreciate. Having compared it to the previous source it definitely does look better. Would you

Re: [dev] git dmenu mirror with feature branches instead of separate patches

2010-11-21 Thread Connor Lane Smith
On 21 November 2010 19:33, wrote: > Another kinda heretic idea might be to have fairly feature-rich branches > and feature-removing patches. Just thinking loud Trunk, a branch per patch, a spicy branch, and a plain branch? (Names pending.) Trunk would be mainline dmenu, a stable version to

Re: [dev] git dmenu mirror with feature branches instead of separate patches

2010-11-21 Thread stanio
* Dieter Plaetinck [2010-11-21 17:12]: > On Sun, 21 Nov 2010 16:30:55 +0100 > v4hn wrote: > > On Sun, Nov 21, 2010 at 04:14:26PM +0100, sta...@cs.tu-berlin.de > > wrote: > > > Set of branches based on multiple patches, representing different > > > dmenu flavours -- like surf-flavour (e.g. vertica

[dev] Re: [dmenu] [patch] add xft and fix possible memory leak in version 4.2.1

2010-11-21 Thread Dan Brown
Hello. Continuing the discussion ... Connor Lane Smith wrote: > Anselm R Garbe wrote: >> Well for clarity and consistency reasons I prefer if dmenu cleans up >> all resources acquired at the end. So that cleanup() was removes looks >> more like a bug to me and thanks to Dan for pointing this out

Re: [dev] git dmenu mirror with feature branches instead of separate patches

2010-11-21 Thread Dieter Plaetinck
On Sun, 21 Nov 2010 16:30:55 +0100 v4hn wrote: > On Sun, Nov 21, 2010 at 04:14:26PM +0100, sta...@cs.tu-berlin.de > wrote: > > Often, issues arise when applying multiple patches. The prposal > > doesn't solve this, does it? For single features -- sure, it's > > beneficial, but the work to keep st

Re: [dev] git dmenu mirror with feature branches instead of separate patches

2010-11-21 Thread v4hn
On Sun, Nov 21, 2010 at 04:14:26PM +0100, sta...@cs.tu-berlin.de wrote: > Often, issues arise when applying multiple patches. The prposal doesn't > solve this, does it? For single features -- sure, it's beneficial, but the > work to keep stuff up to date with master remains. Yes, there are problem

Re: [dev] git dmenu mirror with feature branches instead of separate patches

2010-11-21 Thread stanio
* Dieter Plaetinck [2010-11-21 13:50]: > For the following reasons... > > - It's easier to maintain and update separate versions/features using > vcs branches rather then separate patch files. (unless all the > patches posted are generated by vcs systems, but in that case we > should at lea

Re: [dev] surf segfault

2010-11-21 Thread Gregor Best
On Sun, Nov 21, 2010 at 02:46:00PM +0100, Martin Kopta wrote: > [...] > Why is in surf.c at line /gdk_draw_rectangle(w->window,/ the w->window null > pointer? > > (gdb) p w > $5 = (GtkWidget *) 0x7fd4d00225e0 > (gdb) p w->window > $6 = (GdkWindow *) 0x0 > > That is good or bad? > [...] I'd say t

Re: [dev] surf segfault

2010-11-21 Thread Martin Kopta
On Sun, Nov 21, 2010 at 02:09:10PM +0100, Martin Kopta wrote: > > $ surf > > (:12945): Gdk-CRITICAL **: IA__gdk_gc_new: assertion `drawable != > > NULL' failed > > (:12945): Gdk-CRITICAL **: IA__gdk_gc_set_rgb_fg_color: assertion > > `GDK_IS_GC (gc)' failed > > (:12945): GLib-GObject-WARNING **:

Re: [dev] surf segfault

2010-11-21 Thread Martin Kopta
> $ surf > (:12945): Gdk-CRITICAL **: IA__gdk_gc_new: assertion `drawable != > NULL' failed > (:12945): Gdk-CRITICAL **: IA__gdk_gc_set_rgb_fg_color: assertion > `GDK_IS_GC (gc)' failed > (:12945): GLib-GObject-WARNING **: invalid uninstantiatable type > `(null)' in cast to `GtkWidget' > Segment

Re: [dev] git dmenu mirror with feature branches instead of separate patches

2010-11-21 Thread Connor Lane Smith
Hey, On 21 November 2010 12:49, Dieter Plaetinck wrote: > It's easier to maintain and update separate versions/features using > vcs branches rather then separate patch files. (unless all the > patches posted are generated by vcs systems, but in that case we > should at least publish the correspon

Re: [dev] surf segfault

2010-11-21 Thread Martin Kopta
> I am familiar with this issue in tabbed where I close windows using second > button of the mouse. Since I run the experiment without tabbed, observed > problem might be some other, nonrelated issue than the 'tabbed+surf+winclose > crash'. I caught the segfault with tabbed, so the issue h

Re: [dev] Re: [dmenu] [patch] add xft and fix possible memory leak in version 4.2.1

2010-11-21 Thread Connor Lane Smith
Hey, On 21 November 2010 03:56, Dan Brown wrote: > 2) dmenu v4.2.1 appears to be leaking memory. It is missing the > routines to teardown/cleanup memory structures present in previous > versions. This patch also adds them. As Wolf says, there is no memory leak: there are only mallocs right at th

[dev] git dmenu mirror with feature branches instead of separate patches

2010-11-21 Thread Dieter Plaetinck
Hi, I'm not sure if this is a good idea or not, but at least it's an interesting experiment. For the following reasons... - It's easier to maintain and update separate versions/features using vcs branches rather then separate patch files. (unless all the patches posted are generated by vcs sy

Re: [dev] surf segfault

2010-11-21 Thread Martin Kopta
> If you know how to catch error output of application runned within tabbed, > please tell me. Of course, running tabbed from terminal does the trick. Somehow, I thought it would not. Sorry for my stupidity.

[dev] surf segfault

2010-11-21 Thread Martin Kopta
As I mentioned earlier in this list, surf is crashing. We already discussed this and marked that as X related non-fixable issue. Anyway, today I got bit angry and took surf out of tabbed to do an experiment. I run surf from st a browsed few pages. Then surf crashed with following output. $ surf (:

Re: [dev] Re: [dmenu] [patch] add xft and fix possible memory leak in version 4.2.1

2010-11-21 Thread Dieter Plaetinck
On Sun, 21 Nov 2010 01:22:46 -0800 Dan Brown wrote: > 3) adds 2 other features that I want (but may not be generally > popular): filter mode and token matching "token matching" seems to be the same as the xmms-style matching: http://tools.suckless.org/dmenu/patches/xmms-like_pattern_matching (al

[dev] Re: [dmenu] [patch] add xft and fix possible memory leak in version 4.2.1

2010-11-21 Thread Dan Brown
In response to suggestions on this thread, here is an updated patch for dmenu 4.2.1 that makes the following changes: 1) adds memory cleanup/free routines 2) adds xft font support 2b) moves all code that deals with details of drawing into draw.h and draw.c files, and out of dmenu.c . It's my hope

Re: [dev] [dmenu] [patch] add xft and fix possible memory leak in version 4.2.1

2010-11-21 Thread Anselm R Garbe
On 21 November 2010 06:31, Wolf Tivy wrote: >> 2) dmenu v4.2.1 appears to be leaking memory. It is missing the >> routines to teardown/cleanup memory structures present in previous >> versions. This patch also adds them. > > dmenu doesn't run long and the OS frees all the memory used > by the proc