Re: [dev] [dwm] tagging interface

2010-09-22 Thread Wolf Tivy
> Can you explain what could go wrong?  The predicate would > be passed in > the KeyRelease event (as an XPointer), and return True if it finds > a KeyPress with matching time and keycode. Sorry, there is no problem. I didn't quite grasp the arbitrary predicate part before. I am skeptical about w

Re: [dev] [dwm] tagging interface

2010-09-22 Thread matus,
On Wed, Sep 22, 2010 at 05:41:24PM -0700, Wolf Tivy wrote: > > In particular, XCheckIfEvent seems well suited to this situation- > > -feed in a predicate which specifically finds the repeated KeyPress > > (matches time, key, etc.). But this can perform unnecessary > > computation since it checks th

Re: [dev] [dwm] tagging interface

2010-09-22 Thread Wolf Tivy
> > There are various functions I think you could use. apropos XCheck? > > In particular, XCheckIfEvent seems well suited to this situation- > -feed > in a predicate which specifically finds the repeated KeyPress (matches > time, key, etc.). But this can perform unnecessary computation > since it

Re: [dev] [dwm] tagging interface

2010-09-22 Thread yy
2010/9/23 Wolf Tivy : > If someone can elaborate on the motivation and use-cases for the toggle, > I might be better able to give it the right semantics with the combo stuff. > From my understanding it's no longer necessary as it was simply a > mechanism to cache your tagset which was microtedious

Re: [dev] [dwm] tagging interface

2010-09-22 Thread matus,
On Wed, Sep 22, 2010 at 11:44:46PM +0100, Connor Lane Smith wrote: > Hey, > > On Wednesday, 22 September 2010, Wolf Tivy wrote: > > I wasn't just being cheap when I left that out. It looks like XPeekEvent > > blocks, which won't do. I haven't found the (hopefully existent) > > non-blocking equiva

Re: [dev] [dwm] tagging interface

2010-09-22 Thread Connor Lane Smith
Hey, On Wednesday, 22 September 2010, Wolf Tivy wrote: > I wasn't just being cheap when I left that out. It looks like XPeekEvent > blocks, which won't do. I haven't found the (hopefully existent) > non-blocking equivalent, so I can't even write that part. There are various functions I think you

Re: [dev] [dwm] tagging interface

2010-09-22 Thread matus,
On Wed, Sep 22, 2010 at 03:00:53PM -0700, Wolf Tivy wrote: > I wasn't just being cheap when I left that out. It looks like > XPeekEvent blocks, which won't do. I haven't found the (hopefully > existent) non-blocking equivalent, so I can't even write that part. Okay, I feel like a moron: I had no i

Re: [dev] [dwm] tagging interface

2010-09-22 Thread Wolf Tivy
> I suppose your goal was code economy, so maybe you don't care, > but: by > not adding the code to deal with repeats, you're forcing the resulting > release/press pairs to be handled by the toplevel event loop, one > undoing the effect of the other. > > Visually though it shouldn't be an issue:

Re: [dev] [dwm] tagging interface

2010-09-22 Thread matus,
I suppose your goal was code economy, so maybe you don't care, but: by not adding the code to deal with repeats, you're forcing the resulting release/press pairs to be handled by the toplevel event loop, one undoing the effect of the other. Visually though it shouldn't be an issue: like I said, I

Re: [dev] [dwm] tagging interface

2010-09-22 Thread Robert Ransom
On Wed, 22 Sep 2010 10:42:43 -0700 Wolf Tivy wrote: > > hey, > > > > sounds quite interesting, but what's wrong with a simple > > diff-file instead of instructions where to insert c-code? -.- > > > > > > v4hn > > A diff would be better, but my dwm has some other crap, and I > don't have the u

Re: [dev] [dwm] tagging interface

2010-09-22 Thread Wolf Tivy
> By the previous tags I mean the other tagset. It can be toggled with > view(0), MODKEY+Tab by default. If you want to add that functionality > to your patch add > >     selmon->seltags ^= 1; /* toggle sel tagset */ > > before > >     selmon->tagset[selmon->seltags] = newtags; > > It will pro

Re: [dev] [dwm] tagging interface

2010-09-22 Thread Wolf Tivy
> hey, > > sounds quite interesting, but what's wrong with a simple > diff-file instead of instructions where to insert c-code? -.- > > > v4hn A diff would be better, but my dwm has some other crap, and I don't have the unmodified, and those are just excuses for the fact that i don't know how t

Re: [dev] [dwm] tagging interface

2010-09-22 Thread v4hn
On Tue, Sep 21, 2010 at 10:19:55PM -0700, Wolf Tivy wrote: > Ok so I'm done my little mods, works great. I have attached > a 'patch' so that the rest of you can play with it. > Some possible breakage is that the new view function > doesn't toggle between the two tag sets. Still works for me > thoug

Re: [dev] [dwm] tagging interface

2010-09-22 Thread yy
2010/9/22 Wolf Tivy : > Sorry for being unclear. Not quite like toggle. I mean when you press a > tag key it does the normal thing (tags = newtag or whatever), but then > if you press more tag keys before you release any of them it adds them > to the selection (like tags |= newtag). So if you mash