Re: [PATCH] limit diff effort to fix performance issue

2022-04-01 Thread Johan Corveleyn
On Tue, Jun 8, 2021 at 5:58 PM Johan Corveleyn wrote: > On Tue, Jun 8, 2021 at 3:24 PM Stefan Sperling wrote: > > On Tue, Jun 08, 2021 at 02:57:34PM +0200, Johan Corveleyn wrote: > > > Okay, I focused on the first revision causing the annotate to differ, > > > and with some debug logging: > > > -

Re: What to do about PGP KEYS for release?

2022-04-01 Thread Mark Phippard
On Fri, Apr 1, 2022 at 2:22 AM Nathan Hartman wrote: > > tl;dr: > (1) Attached script to generate KEYS (I'll be happy to provide the > generated KEYS by request) > (2) dsahlberg, futatuki, jun66j5, kfogel: it can't find your key > > Replies and details inline below... > > On Thu, Mar 31, 2022 at 7

All set for release process to begin tomorrow

2022-04-01 Thread Mark Phippard
I will do a dry-run this AM and run all the tests to confirm but I believe we are all set to produce the release tarballs tomorrow. I might do the commits to CHANGES later today as I see no harm in doing it ahead of time. This will also give a window where people can make edits if they see fit. T

Re: [PATCH] limit diff effort to fix performance issue

2022-04-01 Thread Stefan Sperling
On Fri, Apr 01, 2022 at 12:44:24PM +0200, Johan Corveleyn wrote: > On Tue, Jun 8, 2021 at 5:58 PM Johan Corveleyn wrote: > > On Tue, Jun 8, 2021 at 3:24 PM Stefan Sperling wrote: > > > On Tue, Jun 08, 2021 at 02:57:34PM +0200, Johan Corveleyn wrote: > > > > Okay, I focused on the first revision c

Re: What to do about PGP KEYS for release?

2022-04-01 Thread Mark Phippard
On Fri, Apr 1, 2022 at 6:50 AM Mark Phippard wrote: > I was able to run the script without problem, so I think I am all set. > The release.py script will still fail when it tries to download the > KEYS but I am assuming that is the last step it does in that part of > the process. Presumably if I t

Review CHANGES for release

2022-04-01 Thread Mark Phippard
I think we are all set for tomorrow. I updated CHANGES on trunk for both releases and backported to the branches. Feel free to review and make edits if you see fit. I will just go with whatever is on the branches tomorrow AM. Now, back to $DAYJOB Mark

Re: [PATCH] limit diff effort to fix performance issue

2022-04-01 Thread Johan Corveleyn
On Fri, Apr 1, 2022 at 1:12 PM Stefan Sperling wrote: > > On Fri, Apr 01, 2022 at 12:44:24PM +0200, Johan Corveleyn wrote: > > On Tue, Jun 8, 2021 at 5:58 PM Johan Corveleyn wrote: > > > On Tue, Jun 8, 2021 at 3:24 PM Stefan Sperling wrote: > > > > On Tue, Jun 08, 2021 at 02:57:34PM +0200, Johan

Re: [PATCH] limit diff effort to fix performance issue

2022-04-01 Thread Stefan Sperling
On Fri, Apr 01, 2022 at 04:17:45PM +0200, Johan Corveleyn wrote: > - Perhaps the fundamental diff algorithm in SVN is fine, but it has a > performance bug / low-level inefficiency? I think that should be > explored first, because it might fix most of this problem without > requiring a discussion ab

Re: Review CHANGES for release

2022-04-01 Thread Stefan Sperling
On Fri, Apr 01, 2022 at 10:16:41AM -0400, Mark Phippard wrote: > I think we are all set for tomorrow. I updated CHANGES on trunk for > both releases and backported to the branches. Feel free to review and > make edits if you see fit. I will just go with whatever is on the > branches tomorrow AM. >

Re: [PATCH] limit diff effort to fix performance issue

2022-04-01 Thread Johan Corveleyn
On Fri, Apr 1, 2022 at 4:37 PM Stefan Sperling wrote: > Yes, roughly, Patience diff involves two algorithms, the grouping of > lines along similar-line boundaries performed by Patience, and an > LCS for parts of the files which Patience cannot deal with by itself. > > But LCS needs to complete its

Re: [PATCH] limit diff effort to fix performance issue

2022-04-01 Thread Stefan Sperling
On Fri, Apr 01, 2022 at 05:04:49PM +0200, Johan Corveleyn wrote: > Yes, I suppose this is the case: Patience feeds different (smaller) > things to LCS. Because, as far as I understand, Myers' way of > calculating the LCS is fundamentally "somewhat" quadratic (according > to the Myers paper from 198

Re: [PATCH] limit diff effort to fix performance issue

2022-04-01 Thread Johan Corveleyn
On Fri, Apr 1, 2022 at 5:19 PM Stefan Sperling wrote: > > On Fri, Apr 01, 2022 at 05:04:49PM +0200, Johan Corveleyn wrote: > > Yes, I suppose this is the case: Patience feeds different (smaller) > > things to LCS. Because, as far as I understand, Myers' way of > > calculating the LCS is fundamenta

Re: [PATCH] limit diff effort to fix performance issue

2022-04-01 Thread Nathan Hartman
On Fri, Apr 1, 2022 at 10:37 AM Stefan Sperling wrote: > > On Fri, Apr 01, 2022 at 04:17:45PM +0200, Johan Corveleyn wrote: > > - Perhaps the fundamental diff algorithm in SVN is fine, but it has a > > performance bug / low-level inefficiency? I think that should be > > explored first, because it

Re: [PATCH] limit diff effort to fix performance issue

2022-04-01 Thread Stefan Sperling
On Fri, Apr 01, 2022 at 06:08:14PM +0200, Johan Corveleyn wrote: > I suppose the "modified for better performance" refers to some > optimisations done by Morten Kloster, who then later submitted the > patch adding this comment in r1128862. His optimisations were more > related to the LCS algorithm