Re: [PR] Bump up Java version to 21 [solr]

2024-10-24 Thread Gus Heck
hmm when I try to change the project jdk to 21 in intellij I get Cannot Save Settings Content root '/home/gus/projects/gus-asf/solr/fork/solr/solr/benchmark/src/test-files' is defined for modules 'org.apache.solr.solr-root.solr.benchmark.test' and 'solr-root.solr.benchmark.test'. Two modules in a

Re: [PR] Bump up Java version to 21 [solr]

2024-10-24 Thread Gus Heck
No I meant build tool, meaning gradle the compatibility matrix says you shouldn't run gradle 8.4 on 21 and that requires 8.5. It seems we should be upgrading to There's apparently some support for toolchains, but if we're using that it

Re: Deduplicating/Modularizing Our Jenkins Jobs

2024-10-24 Thread Jason Gerlowski
My original writeup here missed one important detail that Uwe recently clarified for me on the lucene lists. [1]. The constant presence of some Solr jobs in the Jenkins build-queue isn't accidental, it's by design(!) We've historically triggered some jobs "hourly" instead of "nightly" in order to

Re: [PR] Bump up Java version to 21 [solr]

2024-10-24 Thread sanjay dutt
I believe this should go away by setting JAVA_HOME to 21. -- Sanjay

Re: [PR] Bump up Java version to 21 [solr]

2024-10-24 Thread David Smiley
GUS, I think your comment is best placed for the ANNOUNCE dev list thread, not Christos's PR. Also our "build tool" is Gradle, and it hasn't changed. You meant an IDE but I'm using IntelliJ just fine, and I can say IntelliJ compatibility was a critical concern and evaluation I did as a reviewer.

Re: [PR] Bump up Java version to 21 [solr]

2024-10-24 Thread sanjay dutt
Gradle 8.4 does support JDK 21 as mentioned in release notes as well. Is there any specific error that you are getting? https://docs.gradle.org/8.4/release-notes.html This release features several improvements for JVM-based projects. Java 21

Re: [PR] Bump up Java version to 21 [solr]

2024-10-24 Thread Christos Malliaridis
I had the same issue on Windows. I updated the JAVA_HOME and PATH to point to JDK 21. Since I have multiple JDKs installed, the order in PATH is important, as only the first path to a JDK directory is taken into account by IntelliJ. I also updated the Gradle JVM under Build, Execution, Deploymen

Re: [PR] Bump up Java version to 21 [solr]

2024-10-24 Thread Christos Malliaridis
Just noticed, Gradle 8.4 does not support JDK 21 (only up to 20). So the last part about updating Gradle JVM in the IDE may cause other issues. I guess upgrading Gradle is one of the next steps. :) - To unsubscribe, e-mail: dev-

Re: [PR] Bump up Java version to 21 [solr]

2024-10-24 Thread Gus Heck
I just updated (merging main into a branch I'm working on). Now Intellij can't even reload gradle: A problem occurred configuring root project 'solr-root'. > Could not determine the dependencies of null. > Could not resolve all task dependencies for configuration ':classpath'. > Could not

Re: Moving away from Zookeeper in SolrJ

2024-10-24 Thread David Smiley
On Thu, Oct 24, 2024 at 9:07 AM Jason Gerlowski wrote: > Hi! > > I'm all for (eventually) nudging folks towards HttpCSP. It's a "Good > Thing", conceptually, to hide ZK! > > But it sounds like there are still some significant (if few) downsides > to using HttpCSP (the "all live nodes disappear"

Re: HELP wanted: Dependency upgrades

2024-10-24 Thread Christos Malliaridis
I got a few questions before interacting with the Solrbot PRs, because I haven't done that before. - When are the CHANGES entries added, and when not? Is it just "if Solrbot created the PR, then it will be added automatically during next release"? - In case no additional actions are necessary, w

Re: Community Virtual Meetup, October 23rd

2024-10-24 Thread Jason Gerlowski
Great summary notes David, and thanks for volunteering for this past month! On Thu, Oct 24, 2024 at 1:33 AM David Smiley wrote: > > I probably should have activated the transcription feature for Google Meet > but didn't. I will next time. > > On Thu, Oct 24, 2024 at 1:25 AM Ishan Chattopadhyaya

Re: [PR] Bump up Java version to 21 [solr]

2024-10-24 Thread Christos Malliaridis
That makes sense, thanks for the details. I looked into the release notes and it says: > Gradle now supports using Java 21 for compiling, testing, and starting other > Java programs. This can be accomplished using toolchains. > > Currently, you cannot run Gradle on Java 21 because Kotlin lacks s

Re: [PR] Bump up Java version to 21 [solr]

2024-10-24 Thread Gus Heck
I don't think we should have been pushing a change to a jdk not supported by our build tool? My ide is now refusing to import with the big mismatch in my prior email if gradle set to 17 or 19, but if it's set to 21 it just says "Invalid Gradle JDK configuration found. Open Gradle Settings" On Thu

[ANNOUNCE] JDK 21 now needed to build Solr main

2024-10-24 Thread sanjay dutt
Hey everyone,  We have successfully bumped up the main branch to JDK 21 and SolrJ to JDK 17. All test packages are now set to Java 21 to address interdependencies between the modules. As you merge with the main branch, you'll start encountering some errors; please update JAVA_HOME to version 21

Re: HELP wanted: Dependency upgrades

2024-10-24 Thread David Smiley
I haven't either and I have the same doubts/questions. Hopefully there's a developer docs page we can maintain on this and that which is linked to from those PRs. On Thu, Oct 24, 2024 at 10:15 AM Christos Malliaridis < malliari...@apache.org> wrote: > I got a few questions before interacting wit

Re: Deduplicating/Modularizing Our Jenkins Jobs

2024-10-24 Thread David Smiley
Sounds very good Jason; thanks for the summary and execution of the plan. On Thu, Oct 24, 2024 at 3:56 PM Jason Gerlowski wrote: > My original writeup here missed one important detail that Uwe recently > clarified for me on the lucene lists. [1]. The constant presence of > some Solr jobs in the

Re: Community Virtual Meetup, October 23rd

2024-10-24 Thread Ishan Chattopadhyaya
If these meetings are organized using MS Teams, maybe they can be auto transcribed. I saw this feature during a client call and was impressed with the quality. On Thu, 24 Oct, 2024, 9:56 am David Smiley, wrote: > I finished updating the post meeting notes and attendees. This is > definitely a t