Re: Unit Tests: how to see solr.log?

2023-12-15 Thread James Dyer
My initial concern here is to decrease the amount of mail I get! Solr test failures create a lot of clutter. I honestly failed to notice this test only fails in 8.x and I do see now you have already done a lot of work with this test. I think if we have no intention of fixing this test in the old

Re: Unit Tests: how to see solr.log?

2023-12-15 Thread James Dyer
Thank you for the details and for taking the time to illustrate with a PR. This worked like a charm. Perhaps someday it might be nice to add a gradle option to easily enable solr.log output. I imagine this would be helpful in a lot of cases. (While I am writing I also want to thank you for helpi

Re: Unit Tests: how to see solr.log?

2023-12-15 Thread Chris Hostetter
: lot of work with this test. I think if we have no intention of fixing : this test in the old branch we should @Ignore it in that branch. At the time i worked on this the concensus was to never do any more 8.11 bug fixes and all of the 8x jenkins jobs were turned off. I have no objection to

Re: Unit Tests: how to see solr.log?

2023-12-15 Thread Chris Hostetter
: Thank you for the details and for taking the time to illustrate with a : PR. This worked like a charm. Perhaps someday it might be nice to : add a gradle option to easily enable solr.log output. I imagine this : would be helpful in a lot of cases. There shouldn't need to be any gradle option

Re: (solr) branch main updated: SOLR-16949: Restrict certain file types from being uploaded to or downloaded from Config Sets

2023-12-15 Thread Chris Hostetter
This change, and it's associated backports, seem to have broken TestConfigSetService (regardless of seed?) due to leaked files. https://ci-builds.apache.org/job/Solr/job/Solr-Check-main/8576/consoleText https://jenkins.thetaphi.de/view/Solr/job/Solr-main-Windows/3706/consoleText https://ci-build