Re: Change suggestion: more efficient replica state tracking

2023-10-02 Thread Mark Miller
Actually, I think what I did was move the DOWN state to startup. Since you can’t count on it on shutdown (crash, killed process, state doesn’t get published for a variety of reasons), it doesn’t do anything solid for the holes where you are indexing and a node cycles. So it can come up in any state

Re: Change suggestion: more efficient replica state tracking

2023-10-02 Thread Ilan Ginzburg
Not sure I totally follow what you mean Mark. We thought making actual replica state = published replica state AND node state, which would set practical replica states to down when an ephemeral Zookeeper node for a SolrCloud node disappears. This works nicely for the going down part, but still requ

Re: [JENKINS] Solr-main-Linux (64bit/hotspot/jdk-20) - Build # 14858 - Unstable!

2023-10-02 Thread Kevin Risden
This reproduces for me on main w/ JDK 17 gradlew :solr:core:test --tests "org.apache.solr.util.tracing.TestSimplePropagatorDistributedTracing.testUpdateRequest" -Ptests.jvms=5 "-Ptests.jvmargs=-XX:TieredStopAtLevel=1 -XX:+UseParallelGC -XX:ActiveProcessorCount=1 -XX:ReservedCodeCacheSize=120m" -Pt

Re: [JENKINS] Solr-main-Linux (64bit/hotspot/jdk-20) - Build # 14858 - Unstable!

2023-10-02 Thread Alex Deparvu
Thanks Kevin. I will take a look. On Mon, Oct 2, 2023 at 5:47 AM Kevin Risden wrote: > This reproduces for me on main w/ JDK 17 > > gradlew :solr:core:test --tests > > "org.apache.solr.util.tracing.TestSimplePropagatorDistributedTracing.testUpdateRequest" > -Ptests.jvms=5 "-Ptests.jvmargs=-XX:Ti

Re: Change suggestion: more efficient replica state tracking

2023-10-02 Thread Ishan Chattopadhyaya
Thanks for bringing up this topic, Ilan. > We are also running a fork of Solr and in our > fork we have made some optimizations to avoid processing DOWNNODE > messages for nodes that only host PRS collections. Those optimizations > have not made it upstream at this point. I can take a look at > up

Re: 8.11.3 release

2023-10-02 Thread Pierre Salagnac
Hi Ishan, Sorry for the late chime in. Some time ago I filled a Jira for a Solr 8 specific bug: https://issues.apache.org/jira/browse/SOLR-16843 At that time, I wasn't expecting more 8.x releases, so I did not open a PR for it. I can work on a fix if we have a few days more before the release. I

Re: Change suggestion: more efficient replica state tracking

2023-10-02 Thread Mark Miller
Oh I’m not referring to your proposal, just what happens with the current system and what I had done around DOWN state to address it. The problem there is the missing replica state when you come up as the live node can’t cover for it. How you cover for that state could be done in a lot of ways, it’

Re: [DISCUSS] 9.4 release

2023-10-02 Thread Alex Deparvu
Another quick update. There are 2 things pending and wanted to check on the progress - https://issues.apache.org/jira/browse/SOLR-17005 seems to be a regression in the start script on Windows. it looks like this needs to block the release. please correct if I misunderstood the priority. - https:

Re: 8.11.3 release

2023-10-02 Thread Ishan Chattopadhyaya
Thanks Pierre, I'll have it included in 8.11 once you are able to have a PR for this. Thanks! On Mon, 2 Oct 2023 at 22:22, Pierre Salagnac wrote: > Hi Ishan, > Sorry for the late chime in. > > Some time ago I filled a Jira for a Solr 8 specific bug: > https://issues.apache.org/jira/browse/SOLR-1

Re: Ideas for Grabbing Json from URL in our Unit Tests and Code?

2023-10-02 Thread Eric Pugh
I had another thought which is that often the reason we are grabbing JSON from some random URL is because we don’t have SolrJ support for that specific API. However, with the upcoming V2 api’s and the code generated Java client objects, maybe we could start using them in our tests. This would

Re: [DISCUSS] 9.4 release

2023-10-02 Thread Eric Pugh
So, I’m thinking that SOLR-14496 probably needs more tests and eyeballs, so don’t hold up the release for it. Hopefully it makes it! > On Oct 2, 2023, at 2:01 PM, Alex Deparvu wrote: > > Another quick update. > > There are 2 things pending and wanted to check on the progress > - https://is

Feedback on changing signature of two commands...

2023-10-02 Thread Eric Pugh
In SOLR-14496, we introduce Basic Auth support using the command line long option “-credentials” and the short form “-u”.This dropped in seamlessly except for two commands, AssertTool and PackageTool. AssertTool uses the -u parameter to mean “Asserts that we run as same user that owns .” An

Re: Feedback on changing signature of two commands...

2023-10-02 Thread Ishan Chattopadhyaya
How about using -u and --credentials for all other commands, but for those two commands using -c and --credentials? I like -u for credentials because curl supports that. On Tue, 3 Oct 2023 at 00:13, Eric Pugh wrote: > In SOLR-14496, we introduce Basic Auth support using the command line long >

Re: Feedback on changing signature of two commands...

2023-10-02 Thread Eric Pugh
Yeah, the -u for credentials came out of Curl as well ;-). One less thing to remember. As far as -c, both AssertTool and PackageTool use that already as a short option, so the same issue applies. I worry that a lot of folks will learn the -u user:password pattern, and then get caught by Asse

Re: [DISCUSS] 9.4 release

2023-10-02 Thread Tomás Fernández Löbbe
I understand we still don't have a feature freeze, right? I'm planning on merging SOLR-16852 for 9.4 unless there are any objections. On Mon, Oct 2, 2023 at 11:35 AM Eric Pugh wrote: > So, I’m thinking that SOLR-14496 probably needs more tests and eyeballs, > so don’t hold up the release for it.

solrj - SslConfig improvements

2023-10-02 Thread Karl-Johan Karlberg
Hi, Just attepted to upgrade to solrj-9.x realized a few compiler errors on of witch I have a suggestion for, The thing that breaks is that we used to provide our own HttpClient for communication with solr. Looked something like: HttpClient getHttpClient() { try { …. lots of code

Back-compat for backup/restore

2023-10-02 Thread David Smiley
https://issues.apache.org/jira/browse/SOLR-16924 There is a small improvement planned for Collection restore (from backup) internal sequencing, and I have a question for the group on backwards compatibility. The RestoreCmd will no longer need to send a REQUESTAPPLYUPDATES command to each core fol

Re: solrj - SslConfig improvements

2023-10-02 Thread David Smiley
Sounds like a nice improvement suggestion. JIRA issue & PR welcome :-) Note that you could probably just use some system properties today: https://github.com/apache/solr/blob/901e0debc381f988373a6d9c09ca47341dda05fb/solr/solrj/src/java/org/apache/solr/client/solrj/impl/Http2SolrClient.java#L1363