Re: Build checks for missing javadocs

2023-09-29 Thread Uwe Schindler
Hi, in Lucene and Solr we have a plugin for javac/javadoc that checks for missing javadocs on several levels. I just checked: Solr has the missing-doclet, too: https://github.com/apache/solr/tree/main/dev-tools/solr-missing-doclet But it looks like the checker is almost fully disabled and on

Re: [DISCUSS] 9.4 release

2023-09-29 Thread Ishan Chattopadhyaya
I'd like to merge SOLR-16644, please. I think it is low risk, since it affects only the start script and fixes the way a low entropy warning is generated. On Fri, 29 Sept 2023 at 03:19, Alex Deparvu wrote: > Hi, > > It would be unfortunate to get this close and miss out on the Lucene > release.

Ideas for Grabbing Json from URL in our Unit Tests and Code?

2023-09-29 Thread Eric Pugh
In SOLR-14496 for adding basic auth to our CLI, I ran again into “I need to call an end point that spits back JSON and do something with it”. Specifically, you can see this rather convoluted method https://github.com/apache/solr/pull/1954/files#diff-9cf9bffde79b0e6e23224cd3240c4a2b281ba91eed9

RE: Solr9 TermsComponent behavior that response writer is csv

2023-09-29 Thread ufuk yılmaz
When I look at the Solr source code, if I’m understanding correctly, it’s not possible to get CSV formatted response from the terms handler. Because terms handler puts its data in “terms” key of the map while CSVWriter reads data from the “response” key only. //org.apache.solr.handler.component

Re: [DISCUSS] 9.4 release

2023-09-29 Thread David Smiley
There is no feature freeze yet (there is no branch_9_4), thus no necessity to ask permission. ~ David On Fri, Sep 29, 2023 at 10:34 AM Ishan Chattopadhyaya < ichattopadhy...@gmail.com> wrote: > I'd like to merge SOLR-16644, please. I think it is low risk, since it > affects only the start scrip

Re: [DISCUSS] 9.4 release

2023-09-29 Thread Alex Deparvu
Hi, Just a quick status update - SOLR-16994 looks almost complete: PR was reviewed, I'm not sure if there is more work pending - SOLR-16644 was merged and backported - SOLR-16985 - lucene upgrade is almost complete. there are no more failures (still running one single test a few more times just

Re: 8.11.3 release

2023-09-29 Thread Ishan Chattopadhyaya
I'm going to track items from 9x releases in the following sheet. https://docs.google.com/spreadsheets/d/1FADkjDS0yfXpaUi3fbwsa7Izy5HOxE9AR_NKiss1sIo/edit#gid=0 Please let me know if there's any item there that you think would be useful to backport (if easy) to 8.11, and want me to take a look at

Re: [DISCUSS] 9.4 release

2023-09-29 Thread Eric Pugh
If SOLR-14496, https://github.com/apache/solr/pull/1954 ends up getting reviewed with no issues, I’m hoping to get it into 9.4…. Since we have basic auth added to prometheus as well! > On Sep 29, 2023, at 1:45 PM, Alex Deparvu wrote: > > Hi, > > Just a quick status update > - SOLR-16994 l

Re: Solr9 TermsComponent behavior that response writer is csv

2023-09-29 Thread Moriyasu Kannami
Hi、 Thank you, Ufuk. I understood that it’s not possible to get CSV formatted response from the terms handler. I'll use JSON format. Regards, mori. 2023年9月30日(土) 0:42 ufuk yılmaz : > > When I look at the Solr source code, if I’m understanding correctly, it’s not > possible to get CSV formatted