Re: [EXTERNAL] - Re: PR reviewed

2023-08-31 Thread Jan Høydahl
Hi, I'd think that you have all the details of what commands GHA ran to get there, in the GHA run logs, e.g. https://github.com/apache/solr/actions/runs/6030623459/job/16362805679 Here is a screenshot of how the logs look like from here

Re: Crave patch optimization

2023-08-31 Thread Michael Gibney
I realized that although I had responded on Aug. 24, the response was sent only to Uv, not to the list. The commits on the PR referenced have changed now, since I went ahead and rebased for this PR in order to be able to merge it. But the response should be applicable to other PRs as well. And in f

Re: Crave patch optimization

2023-08-31 Thread Alex Deparvu
Hi, Just to add my +1 to Michael's analysis. It does seem crave is doing a lot of extra work determining the list of correct changes as patches, when a single patch file would be sufficient to run the build. not completely sure if you need that entire metadata for any reason. I ran a quick test o