Always-on trace id generation merged to Solr main

2023-08-24 Thread Alex Deparvu
Dropping a note to let everyone know that SOLR-15367 [0] was just merged to Solr main (no 9.x backport). This change brings always-on trace id generation based on OTEL libraries, but without having the entire tracing mechanism enabled. This is a much improved version of the existing rid mechanism

Re: SolrStream error response format - backwards compatibility

2023-08-24 Thread Jason Gerlowski
Hey Alex, I'm sure we're not totally consistent on this, but in most cases I think it's fine to change error messages or format etc. without worrying unduly about backcompat. It's definitely something we've done in the past. Best, Jason On Fri, Aug 18, 2023 at 12:03 PM Alex Deparvu wrote: > >

Re: ZkCLI.java (and bin/zkcli.sh) commands

2023-08-24 Thread Jason Gerlowski
> what commands that exist in zkcli are already covered with existing bin/solr > zk subcommands, which maybe are no longer needed To clarify - you're thinking of removing functionality from zkcli if there's already an equivalent in "bin/solr zk"? Or the opposite? I'm definitely rusty on this bi

Re: Always-on trace id generation merged to Solr main

2023-08-24 Thread Ishan Chattopadhyaya
+1, great improvement. Thanks! On Thu, 24 Aug, 2023, 6:53 pm Alex Deparvu, wrote: > Dropping a note to let everyone know that SOLR-15367 [0] was just merged to > Solr main (no 9.x backport). > > This change brings always-on trace id generation based on OTEL libraries, > but without having the en

Re: Throttling "expensive" admin operations

2023-08-24 Thread Pierre Salagnac
It seems there was some push back due to the complexity and the impact on the overseer code. So this PR is now probably stale. I opened a simpler version that introduces a dedicated thread pool for "expensive" operations. End behavior is the same: we don't execute more than 5 concurrent expensive

Fwd: [JENKINS] Solr » Solr-Check-main - Build # 7785 - Still Failing!

2023-08-24 Thread David Smiley
Many Bats tests seem to be failing on main branch; can't start Solr: > Port 8983 is already being used by another process (pid: 31806) https://ci-builds.apache.org/job/Solr/job/Solr-Check-main/ Eric, you've been looking at Bats lately; do you know about this? ~ David -- Forwarded messa

Re: [JENKINS] Solr » Solr-Check-main - Build # 7785 - Still Failing!

2023-08-24 Thread Houston Putman
It happens on the first test sometimes, so I think it may be a rogue process on the machine. On Thu, Aug 24, 2023 at 11:27 PM David Smiley wrote: > Many Bats tests seem to be failing on main branch; can't start Solr: > > Port 8983 is already being used by another process (pid: 31806) > > https:/