Re: Surprising interactions between MultiFloatFunctions and the query function

2023-07-11 Thread David Smiley
Hi Joel, RE SumFloatFunction: agreed; should be "any" not "all" logic. RE QueryDocValues: I think the current implementation is probably correct since a default value is mandatory. That said, I could imagine using a def(query-here, 1.0) to accomplish the same. Ugh; I see DefFunction.exists isn'

Re: Thinking about the future of lib directives in SolrConfigs

2023-07-11 Thread David Smiley
+1 definitely That said, I could imagine a future solrconfig.xml improvement in which the desired Solr packages (modules?) are declared... and if so then using the "lib" XML element seems congruent with that. But it wouldn't be to individual JAR files! I don't love that packages are linked to co

Re: New branch and feature freeze for Solr 9.3.0

2023-07-11 Thread David Smiley
https://issues.apache.org/jira/browse/SOLR-16507 is a bit unusual; there are two changes/PRs by different people somewhat related with only one of them backported to 9x; the other was forgotten (my bad). Changes.txt entry for main branch shows this under 9.3 but hasn't been ported yet. I intend t

Possible rate limit request processing bug

2023-07-11 Thread Alex Deparvu
Hi, I think there is a bug in the rate limiting code inside ServletUtils [0]: the error code is set to 429 but the 'return' is missing so the request will continue to be processed even if the RateLimitManager returns a 'false'. From the client's side, I think the client sees 429 but the server wil

Re: Possible rate limit request processing bug

2023-07-11 Thread Mark Miller
Yup, though of course the return can't simply be added to that method, but sendError won't stop the request, it will just cause an error when there is an attempt to write to the response later.