Re: modulus function query does mod on floats

2022-08-30 Thread Dan Rosher
Hi Jason, I've created https://issues.apache.org/jira/browse/SOLR-16361 with a linked PR Cheers, Dan On Tue, 23 Aug 2022 at 14:20, Jason Gerlowski wrote: > Hi Dan, > > I'm not very familiar with how Solr implements function-queries, but I > agree this seems like a bug. > > Taking a glance at t

Re: modulus function query does mod on floats

2022-08-23 Thread Jason Gerlowski
Hi Dan, I'm not very familiar with how Solr implements function-queries, but I agree this seems like a bug. Taking a glance at the code it looks like most of the "math" function-queries cast to floats, so I wonder whether this behavior (intentional or not) wouldn't occur more widely too. e.g. "s

modulus function query does mod on floats

2022-08-18 Thread Dan Rosher
Hi, I was surprised when using the mod function query, the modulus was wrong on my largeish int. This was because the int was cast to float, meaning the modulus was wrong for any int above 2^24 Should the mod function change to int modulus instead of float and have another fmod function (like c/