Re: forbidden-apis + assertThat = insanity

2023-10-27 Thread Chris Hostetter
: I agree that having to write "MatcherAssert.assertThat" each time is : tedious and makes my code ugly. So finally I try to avoid this nice : construction. Not satisfying. This right there is the "twist" of the knife in my heart. The 2 lines of code below are both very similar in terms of ea

Re: forbidden-apis + assertThat = insanity

2023-10-27 Thread David Smiley
This would be cleared up if we change LuceneTestCase? ~ David On Wed, Oct 25, 2023 at 4:26 PM Chris Hostetter wrote: > > Begin Rant... > > $ tail -6 ./gradle/validation/forbidden-apis/junit.junit.all.txt > junit.framework.TestCase @ All classes should derive from LuceneTestCase > junit.framewor

Re: forbidden-apis + assertThat = insanity

2023-10-25 Thread Bruno Roustant
I agree that having to write "MatcherAssert.assertThat" each time is tedious and makes my code ugly. So finally I try to avoid this nice construction. Not satisfying. Le mer. 25 oct. 2023 à 22:44, Kevin Risden a écrit : > It came in as part of > https://github.com/apache/solr/pull/947#issuecomme

Re: forbidden-apis + assertThat = insanity

2023-10-25 Thread Kevin Risden
It came in as part of https://github.com/apache/solr/pull/947#issuecomment-1279651282 I linked to one of the comments there since this was discussed on the PR. Basically it removes a ton of deprecated usages. If/when we upgrade Junit we should hopefully have much less to do. So to answer your que

forbidden-apis + assertThat = insanity

2023-10-25 Thread Chris Hostetter
Begin Rant... $ tail -6 ./gradle/validation/forbidden-apis/junit.junit.all.txt junit.framework.TestCase @ All classes should derive from LuceneTestCase junit.framework.Assert @ Use org.junit.Assert junit.framework.** @ Use org.junit org.junit.Assert#assertThat(**) @ Use org.hamcrest.MatcherAsse