I enhanced https://github.com/apache/solr/pull/3357 to incorporate that
test and make other changes. Keeping the IllegalStateException but at
least the idle timeout can be set at the request level. The downside is
that a number of places in Solr that were customizing the connection
timeout can no
That's a good point. I didn't immediately realize it would effectively be the
minimum of the two idle timeout values but now that I think about it, it makes
sense.
Looking at it from a higher level though, since Jetty appears to honor
idleTimeout at the request level (either through the aforem
Luke, thanks for writing this test!!
I looked at your test
(esp.
org.apache.solr.client.solrj.impl.Http2SolrClientTest#testIdleTimeoutWithHttpClient
) in more detail. You tested going from having a sufficient amount of idle
timeout for the request to succeed, then down to a lower amount, asserti
: Then I noticed something insidious: If an Http2SolrClient (Jetty) is
: created using the builder's withHttpClient(...) method, then the idle (aka
: socket) timeout & connection timeout (and basically any other setting
: that's inside the Jetty HttpClient) cannot *actually* be customized
: hen
BERG/ 919 3RD A ) , stilla...@apache.org,
gus.h...@gmail.com
Subject: Re: SolrJ timeouts
My annotated draft PR:
https://github.com/apache/solr/pull/3357
Doesn't solve the issue but its exception throwing means many tests fail
since those places in Solr were trying to both use an existing
My annotated draft PR:
https://github.com/apache/solr/pull/3357
Doesn't solve the issue but its exception throwing means many tests fail
since those places in Solr were trying to both use an existing HttpClient
_and_ set timeouts. We can't do that and we *weren't* doing that! 'course
if I'm missi
This weekend I was harmonizing some of the timeouts between JDK & Jetty
based HTTP SolrClient implementations. I saw some inconsistencies,
duplication, and the need for javadocs to explain what these timeouts
fundamentally mean. I have some nice WIP code I was looking forward to
sharing by now.
