Re: branch_9x broken

2023-05-03 Thread Eric Pugh
I merged the BadApple'ing of CollectionReloadTest, so hopefully branch_9x will be back to green. > On May 3, 2023, at 9:24 AM, Jan Høydahl wrote: > > The PR is already merged, and if it had not been for the broken > CollectionReloadTest, branch_9x would have been fine again... > > Jan > >>

Re: branch_9x broken

2023-05-03 Thread Jan Høydahl
The PR is already merged, and if it had not been for the broken CollectionReloadTest, branch_9x would have been fine again... Jan > 3. mai 2023 kl. 15:13 skrev David Smiley : > > If it's non-trivial and you're super confident, commit directly. Otherwise, > throw up a PR (or patch) immediately

Re: branch_9x broken

2023-05-03 Thread David Smiley
If it's non-trivial and you're super confident, commit directly. Otherwise, throw up a PR (or patch) immediately. I looked at your patch here. +1 from me. ~ David Smiley Apache Lucene/Solr Search Developer http://www.linkedin.com/in/davidwsmiley On Tue, May 2, 2023 at 2:01 PM Eric Pugh wrote:

Re: branch_9x broken

2023-05-02 Thread Eric Pugh
What is the best way to fix this?  I went into branch_9x and checked, and yeah, I totally goofed it somehow…..   Can I commit the attached patch directly to branch_9x? patch.patch Description: Binary data On May 2, 2023, at 3:53 AM, Jan Høydahl wrote:Last successful jenkins "check" on branch_9x w