Re: SolrParams implementations

2024-04-03 Thread David Smiley
I've felt we need one or two less maybe. MultiMapSolrParams can often be substituted by ModifiableSolrParams. Javadocs could be improved in general. RequiredSolrParams and DefaultSolrParams (plus subclasses) could be package scope so as to discourage direct use, which I think is never needed. O

Re: SolrParams implementations

2024-04-03 Thread Houston Putman
I agree that things are needlessly complex, and could definitely be simplified. (hopefully down to one class?)' - Houston On Wed, Apr 3, 2024 at 9:54 AM Gus Heck wrote: > Ah, just noticed that I missed the ! symbol when I read that code, none the > less things are still complex > > On Wed, Apr

Re: SolrParams implementations

2024-04-03 Thread Gus Heck
Ah, just noticed that I missed the ! symbol when I read that code, none the less things are still complex On Wed, Apr 3, 2024 at 10:50 AM Gus Heck wrote: > We have quite a few, including MapSolrParams which seems to explicitly > defy the contract of SolrParams being a multimap... > > Has anyone