Re: Progress on SOLR-16573 EmbeddedSolrServerTestRule

2023-01-03 Thread Jason Gerlowski
Hi David, Thanks for bringing the PR up for attention here. Had a few thoughts on the setter and build() naming, as you called out, and commented on those in the PR. But otherwise, it looks very nice so far! Best, Jason On Tue, Jan 3, 2023 at 1:06 AM David Smiley wrote: > Happy New Year eve

Progress on SOLR-16573 EmbeddedSolrServerTestRule

2023-01-02 Thread David Smiley
Happy New Year everyone. Joshua and I have some good progress on a new EmbeddedSolrServerTestRule https://issues.apache.org/jira/browse/SOLR-16573 + PR (read the JIRA first, always) Keep in mind this is one incremental step, and I expect it will be evolutionary (The API will evolve as we address m