Re: Potential Dead Code: MetricsCollectorHandler, SolrReporter

Andy, I’m working on cleaning up the warnings in the unit tests, and had the same questions about how to tell if things are broken or not. https://ci-builds.apache.org/job/Solr/job/Solr-Check-main/ is my first stop. Take a look at http://fucit.org/solr-jenkins-reports/failure-report.html

Re: Potential Dead Code: MetricsCollectorHandler, SolrReporter

> +1 to what Christine said, and thanks for volunteering to take it off > my list Andy. If you do push up a PR and no one jumps on it, feel > free to plug it here and I'll definitely take a look. I will start digging into this. My big concern is I don’t know what to do as far as testing. Last ti

Re: Potential Dead Code: MetricsCollectorHandler, SolrReporter

These are opt-in plugins living in Solr-core. A user can configure reporters on all their nodes publishing to a node that has the MetricsCollectorHandler configured. AB explains their use here: https://issues.apache.org/jira/browse/SOLR-15007?focusedCommentId=17234635&page=com.atlassian.jira.plugi

Re: Potential Dead Code: MetricsCollectorHandler, SolrReporter

pull request for the removal of the code, that > would be wonderful. > > Thanks, > Christine > > From: dev@solr.apache.org At: 06/30/22 22:13:32 UTC+1:00 > To: dev@solr.apache.org > Subject: Re: Potential Dead Code: MetricsCollectorHandler, SolrReporter > > After a bit mo

Re: Potential Dead Code: MetricsCollectorHandler, SolrReporter

: dev@solr.apache.org At: 06/30/22 22:13:32 UTC+1:00To: dev@solr.apache.org Subject: Re: Potential Dead Code: MetricsCollectorHandler, SolrReporter After a bit more digging, I suspect more strongly that this is dead code. I'm going to put it on my backlog, but it may take me a while to get to. If anyon

Re: Potential Dead Code: MetricsCollectorHandler, SolrReporter

> After a bit more digging, I suspect more strongly that this is dead > code. I'm going to put it on my backlog, but it may take me a while > to get to. If anyone comes to this thread late and knows definitively > one way or another, feel free to chime in! I don’t know one way or the other, but

Re: Potential Dead Code: MetricsCollectorHandler, SolrReporter

Hi all, After a bit more digging, I suspect more strongly that this is dead code. I'm going to put it on my backlog, but it may take me a while to get to. If anyone comes to this thread late and knows definitively one way or another, feel free to chime in! Best, Jason On Thu, Jun 23, 2022 at

Potential Dead Code: MetricsCollectorHandler, SolrReporter

Hi all, I was poking around and noticed what I think are some remnants on "main" of the metrics-history feature that was removed in 9.0. Particularly I'm wondering about the "MetricsCollectorHandler" and "SolrReporter" classes. Neither is referenced elsewhere in the code base or ref-guide as far