Re: [EXTERNAL] - Re: PR ready fro review

2024-04-11 Thread Jason Gerlowski
tributors. > > > Isabelle Giguère > Computational Linguist & Java Developer > Linguiste informaticienne & développeur java > > > ____________ > De : Gus Heck > Envoyé : 9 avril 2024 11:15 > À : dev@solr.apache.org > Objet : [EXTERNAL] - Re:

Re: [EXTERNAL] - Re: PR ready fro review

2024-04-10 Thread Isabelle Giguere
; développeur java De : Gus Heck Envoyé : 9 avril 2024 11:15 À : dev@solr.apache.org Objet : [EXTERNAL] - Re: PR ready fro review CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you recognize the sender and kn

Re: PR ready fro review

2024-04-09 Thread Gus Heck
+1 for v2 in same PR On Tue, Apr 9, 2024 at 10:15 AM Jason Gerlowski wrote: > > V2 could be handled in a different PR, if preferable. > > My preference at least would be that v2 is added in the same PR, so > there's no chance it falls through the cracks. > > I haven't found time to review yet, b

Re: PR ready fro review

2024-04-09 Thread Jason Gerlowski
> V2 could be handled in a different PR, if preferable. My preference at least would be that v2 is added in the same PR, so there's no chance it falls through the cracks. I haven't found time to review yet, but I've put this on my list and will try to come back through this week at some point. I

Re: PR ready fro review

2024-04-09 Thread Eric Pugh
I put some comments in.On the V2 api, I think that if this is specific to a collection, then /api/collections/cluster-size or maybe even /api/collections/sizing If it’s overall, and not collection specific, then /api/cluster/sizing would make sense.And if it supports both, well

PR ready fro review

2024-04-08 Thread Isabelle Giguere
Hello committers; Please take some time to review this PR : https://github.com/apache/solr/pull/1638 It is based on a rather old patch, so only V1 is supported, for now. If we wanted V2, what should be the URL path ? * /api/collections/cluster-size * /api/cluster/sizing V2 could be handled