Re: NullPointerException when using facets in More Like This Query

2023-02-08 Thread Grace Sainsbury
Thanks for the quick fix! It seems to have resolved the issue. On Tue, 7 Feb 2023 at 16:29, Mikhail Khludnev wrote: > https://github.com/apache/solr/pull/1339 > Reviews are welcome. > > On Tue, Feb 7, 2023 at 10:54 PM Grace Sainsbury wrote: > > > I've created a ticket for this here: > > > > htt

Re: NullPointerException when using facets in More Like This Query

2023-02-07 Thread Mikhail Khludnev
https://github.com/apache/solr/pull/1339 Reviews are welcome. On Tue, Feb 7, 2023 at 10:54 PM Grace Sainsbury wrote: > I've created a ticket for this here: > > https://issues.apache.org/jira/browse/SOLR-16648 > > It only seems to affect The MoreLIkeTHis query handler, The same facet > setup work

Re: NullPointerException when using facets in More Like This Query

2023-02-07 Thread Mikhail Khludnev
Right, Michael. MLTHandler refuses to init rb.query, but facets needs it for evaluating filters when some of them are excluded. Grace, I created a jira account for you. Check it out. On Tue, Feb 7, 2023 at 6:36 AM Michael Gibney wrote: > I do suspect this is MLT-specific -- I'm not exactly sure

Re: NullPointerException when using facets in More Like This Query

2023-02-06 Thread Michael Gibney
Grace, if you'd like to set up a Jira account, you're welcome to; there are instructions here on how to get that set up: https://infra.apache.org/jira-guidelines.html#who (we should update the Solr "community" section and contributor guidelines to clarify this initial Jira account setup step, whi

Re: NullPointerException when using facets in More Like This Query

2023-02-06 Thread Michael Gibney
I do suspect this is MLT-specific -- I'm not exactly sure how this is _supposed_ to work (I'm unfamiliar with MLT), but something seems a bit off between these two spots: https://github.com/apache/solr/blob/257c93c956a66f805e23f4835cab88e7a1fe9201/solr/core/src/java/org/apache/solr/handler/MoreLike

Re: NullPointerException when using facets in More Like This Query

2023-02-06 Thread Mikhail Khludnev
Devs, heads up! At first glance this failure doesn't look like mlt specific. It just falls down on NPE when it has no result (null docset, ha!) in fq and then attempts to cache null. Not good, you know. I hope I'm wrong. $ git diff diff --git a/solr/core/src/test/org/apache/solr/handler/MoreLikeT