Re: New branch and feature freeze for Solr 9.0.0

The blockers are once again resolved. Building RC1 has failed 4 times in a row due to flaky tests. Also, the last 4 runs of "Solr-Check-9.0" in Jenkins have failed: https://ci-builds.apache.org/job/Solr/job/Solr-Check-9.0/ These are the tests failing in recent Jenkins runs: - org.apache.solr.se

Re: New branch and feature freeze for Solr 9.0.0

Hi, I filed these new blockers for build bugs, with attached PRs. Please do a quick review: https://issues.apache.org/jira/browse/SOLR-16117 Do not publish an empty solr-server.jar to maven https://issues.apache.org/jira/browse/SOLR-16118 Solr source jars should contain NOTICE, LICENSE files

Re: New branch and feature freeze for Solr 9.0.0

Seriously monumental effort everyone! Thanks for keeping this on track Jan! - Houston On Fri, Mar 25, 2022 at 10:36 PM David Smiley wrote: > Woohoo! > > ~ David Smiley > Apache Lucene/Solr Search Developer > http://www.linkedin.com/in/davidwsmiley > > > On Fri, Mar 25, 2022 at 4:16 PM Jan Høyd

Re: New branch and feature freeze for Solr 9.0.0

Woohoo! ~ David Smiley Apache Lucene/Solr Search Developer http://www.linkedin.com/in/davidwsmiley On Fri, Mar 25, 2022 at 4:16 PM Jan Høydahl wrote: > Hi, > > All code blockers are now cleared: > https://issues.apache.org/jira/issues/?filter=12351219 > Some work remains for RefGuide and docke

Re: New branch and feature freeze for Solr 9.0.0

Hi, All code blockers are now cleared: https://issues.apache.org/jira/issues/?filter=12351219 Some work remains for RefGuide and docker release procedures, we can continue on those in parallell with the RCs. I'll proceed with RC1. Jan > 4. mar. 2022 kl. 21:52 skrev Houston Putman : > > I thi

Re: New branch and feature freeze for Solr 9.0.0

I think we have another blocker for 9.0. Basically there is a bug in the updated version of commons-io that causes index files to be set to read-only in the filesystem occasionally. The solution is to upgrade commons-io, or find a workaround in Solr, but we can have that discussion on the JIRA. Mo

Re: New branch and feature freeze for Solr 9.0.0

I suppose the biggest spots for peer review are: * use of brackets [ ] in the metric name where the request handler is. Thus "/select[shard]" * There is a fundamental difference in how the metrics are tracked on a handler. Previously, there were metrics for all of /select (no matter how it was inv

Re: New branch and feature freeze for Solr 9.0.0

Hi David, I read your note about SOLR-14401 but not clear what you need from me? Seems like you're renaming existing metrics and removing "distrib" from handlers that don't support a distrib mode, seems right to me. I actually haven't done much work on the metrics backend. For Grafana, it's a JSO

Re: New branch and feature freeze for Solr 9.0.0

On Tue, Mar 1, 2022 at 4:46 AM Jan Høydahl wrote: > Hi, and welcome to March! > > Our initial goal of a RC1 within February slipped, but we are still in a > good position. > I'll try to summarize the current code blockers: > > > *SOLR-16061 Decouple CloudSolrClient from ZkStateReader* > > This i

Re: New branch and feature freeze for Solr 9.0.0

Hi, and welcome to March! Our initial goal of a RC1 within February slipped, but we are still in a good position. I'll try to summarize the current code blockers: SOLR-16061 Decouple CloudSolrClient from ZkStateReader This is new, a spin-off from SOLR-15342 to prepare for solrj modularization

Re: New branch and feature freeze for Solr 9.0.0

Thanks! Done. From: dev@solr.apache.org At: 02/24/22 10:02:33 UTCTo: Christine Poerschke (BLOOMBERG/ LONDON ) , dev@solr.apache.org Subject: Re: New branch and feature freeze for Solr 9.0.0 Sure, all bug fixes that are ready can go in. Jan 23. feb. 2022 kl. 19:32 skrev Christine Poerschke

Re: New branch and feature freeze for Solr 9.0.0

g/jira/browse/SOLR-15983> "ClassCastException in > UpdateLog$LogReplayer.doReplay" fixes to 9.0 branch also? > > From: dev@solr.apache.org At: 02/22/22 11:20:46 UTC > To: dev@solr.apache.org <mailto:dev@solr.apache.org> > Subject: Re: New branch and feature freeze for So

Re: New branch and feature freeze for Solr 9.0.0

Thanks Jan for the update! Is it okay to backport https://issues.apache.org/jira/browse/SOLR-15983 "ClassCastException in UpdateLog$LogReplayer.doReplay" fixes to 9.0 branch also? From: dev@solr.apache.org At: 02/22/22 11:20:46 UTCTo: dev@solr.apache.org Subject: Re: New branch a

Re: New branch and feature freeze for Solr 9.0.0

I created a new blocker SOLR-16040 Fix split packages in hdfs module Not sure if it needs to be a blocker though, but we should try to avoid split packages as far as we can, and this cannot be done in 9.x. Meanwhile, SOLR-15064 is resolved and SOLR-14401 is in PR review phase. Jenkins is now mo

Re: New branch and feature freeze for Solr 9.0.0

These are the three main code-blockers for doing 9.0.0 RC1: (P) SOLR-15064 Atomic/partial updates to nested docs should not assume _route_ dsmiley dsmiley (S) SOLR-14290 Fix NPE in SolrTestCaseJ4 breaking external usage for master/9.x gus gus (S) SOLR-14401 """distrib"" reque

Re: New branch and feature freeze for Solr 9.0.0

Congrats on HDFS as a package! Huge win! Also some other blockers have been closed recently. Status on the 9.0 release, one week into February. - I have done a dry-run of an RC and the smoketester. Think the release scripts are ready! - 11 open blockers: (P) SOLR-15587 Replicas end up with ba

Re: New branch and feature freeze for Solr 9.0.0

> > SOLR-14660 Migrating HDFS into a module > krisden ichattopadhyaya This was just merged. Big shout out to Istvan Farkas for doing 99% of the heavy lifting here! Kevin Risden On Sat, Jan 29, 2022 at 5:11 PM Jan Høydahl wrote: > Hi, > > Nine days ago we had 24 blockers. Several blo

Re: New branch and feature freeze for Solr 9.0.0

> 7. jan. 2022 kl. 11:26 skrev Ishan Chattopadhyaya : > > > Btw - does Solr have any benchmarks published yet, that we can compare 8.11 > > with 9.0? Would be very useful. > > I can work on it over the weekend. I have some suites ready with me, but not > automated yet. Any update on the benchm

Re: New branch and feature freeze for Solr 9.0.0

SOLR-15064 "Atomic/partial updates to nested docs should not assume _route_ param is the root ID" will be simple; I will do it. RE the UH being the default; I'm about to post a PR ~ David Smiley Apache Lucene/Solr Search Developer http://www.linkedin.com/in/davidwsmiley On Sat, Jan 29, 2022 at

Re: New branch and feature freeze for Solr 9.0.0

Hi, Nine days ago we had 24 blockers. Several blockers have since been added and several resolved, and today we are at 19. I notified in the previous email that I'd remove inactive blockers. Here is the list of JIRAs for which I intend to remove the blocker flag on February 1st: SOLR-14097 co

Re: New branch and feature freeze for Solr 9.0.0

Hi Jan, I'd like us to include https://issues.apache.org/jira/browse/SOLR-15951 (Local packages) to 9.0. I expect that we can wrap it up in a week (with reviews etc.) and it is essentially a build related change. It is a way for the user to load the contribs/modules through the package manager fro

Re: New branch and feature freeze for Solr 9.0.0

I'd classify both those as bugs, even if the fix breaks a public HTTP API. If they are low hanging, go ahead, just make sure of course to call out the compat break in "Major Changes". Jan > 20. jan. 2022 kl. 20:02 skrev Houston Putman : > > Any issues with me finishing and merging SOLR-15842

Re: New branch and feature freeze for Solr 9.0.0

Any issues with me finishing and merging SOLR-15842 and SOLR-15884 for 9.0.0? They are both backwards incompatible changes but are really good things to include for 9.0. They are also both fairly

Re: New branch and feature freeze for Solr 9.0.0

Hi, The list of release blockers can be seen with this JIRA filter: https://issues.apache.org/jira/issues/?filter=12351219 After the committer's meeting today we decided to add these to the blockers list: - SOLR-15556Ref Guide Redesign Phase 3: Replace Jekyll - SOLR-15917Rename 'contrib

Re: New branch and feature freeze for Solr 9.0.0

Hi, I did a successful test-build of an RC with the releas wizard yesterday, with 0 test failures (what's the chance of that :) ? Currently fixing the smoke tester to accept the new docker/ folder we added to the structure and a few more things. Once I have a passing smoketester locally we are a

Re: New branch and feature freeze for Solr 9.0.0

I'd like to consider getting SOLR-15919 into 9.0 because I'm not sure if it would be allowed in 9.1. I just realized we would want this while looking at the code tonight, don't even have a patch to present yet. It would be a fairly substantial cha

Re: New branch and feature freeze for Solr 9.0.0

I think the key is to get 9.0 out the door so we can start regular releases again. I'm excited about vector search as well but it will be impactful in 9.0 or 9.1. I'll be adding more documentation also for the new the Temporal Graph features in Solr 9.0 (SOLR-15197). With the new DAY and WEEKDAY t

Re: New branch and feature freeze for Solr 9.0.0

I don't disagree with you that it is cool with announcements of killer features. But we have known for almost 2 years that 9.0 is eventually coming, but still chose to backport every single cool feature to 8.x, leaving less for the 9.0 release. And I cannot blame us, since we all thought of 9.0

Re: New branch and feature freeze for Solr 9.0.0

Major releases are special, not like minor releases. More people will look at what's neat in a major release than a minor one. It's a de facto PR event for the project to *potentially* shine. If Lucene or whatever project didn't use them to its advantage years ago then it was a missed opportunit

Re: New branch and feature freeze for Solr 9.0.0

Hi Cassandra, I browsed through the confluence page and the Antora project a bit. Looks like many good reasons for doing the move, and the new structure at https://nightlies.apache.org/solr/draft-guides/solr-reference-guide-antora/solr/HEAD/index.html looks very promising. I'll not stand in the

Re: New branch and feature freeze for Solr 9.0.0

Thanks Jan for the flexibility, esp with respect to the vector search thing. If it happens to be ready within your proposed timelines, it will be a good thing for our project. I don't advocate delaying the release, though. > Honestly, if you are out of the chair when the music stops, you look more

Re: New branch and feature freeze for Solr 9.0.0

On Mon, Jan 10, 2022 at 12:57 AM Jan Høydahl wrote: > > Hi, > > This is quite simple. > - The 9.0 release is on-going - now on branch_9_0 > - The normal feature feeze rules apply. Anything explicitly approved as > blocker gets in > > We can still consider adding features to the branch if the benf

Re: New branch and feature freeze for Solr 9.0.0

Can’t restrain myself. The discussion whether we have "enough features" is i.m.o. silly Lucene used to release major versions with something like no features and just deprecation work. It’s historically common, but the silly smell reminds me of the stereotypical kid selling his parents on some

Re: New branch and feature freeze for Solr 9.0.0

One thing we haven’t talked about yet is the Ref Guide for 9.0. SOLR-1 re-organized the entire guide and changed a lot of page names. At the time I merged this into the main branch there was a little bit of comment about trying to provide page redirects for the changed page names but AFAIK n

Re: New branch and feature freeze for Solr 9.0.0

Hi, This is quite simple. - The 9.0 release is on-going - now on branch_9_0 - The normal feature feeze rules apply. Anything explicitly approved as blocker gets in We can still consider adding features to the branch if the benfit/risk ratio is high enough. Having a long stabilization period al

Re: New branch and feature freeze for Solr 9.0.0

> Ishan: What warrants a release is subjective, but noone can accuse the Solr project of RUSHING with the 9.0 release. Have a look at the Major Changes in Solr 9 page if you need a reminder of wh

Re: New branch and feature freeze for Solr 9.0.0

> Ishan, that also means that you only need to revert SOLR-15694 on branch_9_0 In Apache Solr, committers don't tell other committers to revert commits without a proper technical justification. You were late in cutting the release branch for 9.0, and now "need" me to revert my commit because you'r

Re: New branch and feature freeze for Solr 9.0.0

The New feature list for 9.0 is * Replica placement plugins * Rate limiting and task management * Certificate Auth Plugin * SQL Query interface in UI None of these are compelling search features which will motivate anyone to upgrade OTOH , vector search is a very attractive feature and even if it

Re: New branch and feature freeze for Solr 9.0.0

IMPORTANT Just created branch_9_0 off of branch_9x, and bumped version on branch_9x to 9.1. This means that everything is back to normal branch structure, and the feature freeze is now only on branch_9_0. Ishan, that also means that you only need to revert SOLR-15694 on branch_9_0, and let i

Re: New branch and feature freeze for Solr 9.0.0

Hi, This is indeed a deliberate deviation from established branch process, as debated and decided in the "Solr 9.0.0 release in February" thread https://lists.apache.org/thread/pzqvmcxcjhkrj2xb31sj3pwzrn6x9vd3 and repeated on this very thread, so this is far from some SNEAKY attempt to trick yo

Re: New branch and feature freeze for Solr 9.0.0

I'm also confused slightly on the branch strategy here. main got converted to 10.x that's fine... but I would think ALL 9.x branches should descend from branch_9x, including 9.0... why wouldn't we have made branch_9x and branch_9_0 immediately? Where was noble supposed to check in for a feature tha

Re: New branch and feature freeze for Solr 9.0.0

> branch_9x is in feature freeze! We want to stabilize Feature freeze is meant for the release branches. There is no precedent for having a feature freeze on the stable branch. I urge you to follow well established processes and not invent new processes on the fly and hold the project hostage to t

Re: New branch and feature freeze for Solr 9.0.0

> What do we think about a "beta" release, to give users (including *ourselves* in many cases) more time to try out 9.0 to report issues? +1 > It would be a shame to release Solr 9 without support for the vector based index in Lucene 9. Thankfully there's a JIRA issue with a PR! https://issues.ap

Re: New branch and feature freeze for Solr 9.0.0

I tend to Agree with David We should have a compelling feature in Solr 9 which will encourage users to try it out. Solr 9 does not have any such feature and it is mostly a cleanup that most users do not really care about. +1 to include SOLR-15880 (even if we have to release it as experimental) O

Re: New branch and feature freeze for Solr 9.0.0

branch_9x is in feature freeze! We want to stabilize, fix bugs and remove blockers on that branch, not add features - unless they are agreed as a blocker for the release. If everyone starts pushing all kinds of new features to 9x now, it will never stabilize. >>> >>> Q: But my feature is almost

Re: New branch and feature freeze for Solr 9.0.0

Since a 9.0 release branch has not been cut, I backported the SOLR-15694 to branch_9x. If there are any concerns, we can discuss reverting it from branch_9_0 later. Thanks and regards. On Fri, Jan 7, 2022 at 10:34 PM Ishan Chattopadhyaya < ichattopadhy...@gmail.com> wrote: > > let it bake in main

Re: New branch and feature freeze for Solr 9.0.0

> let it bake in main (10.0) for some time, letting more devs try it out Please define "some time". Is 3 weeks until the 9.0 release not enough? On Fri, Jan 7, 2022 at 10:26 PM Jan Høydahl wrote: > I think it is premature to add it to branch_9x yet. First get +1 from key > stakeholders on the P

Re: New branch and feature freeze for Solr 9.0.0

I think it is premature to add it to branch_9x yet. First get +1 from key stakeholders on the PR, then let it bake in main (10.0) for some time, letting more devs try it out. If all looks good at that point, we may consider it, especially if the default behaviour is === 8.x. What do others thin

Re: New branch and feature freeze for Solr 9.0.0

> Btw - does Solr have any benchmarks published yet, that we can compare 8.11 with 9.0? Would be very useful. I can work on it over the weekend. I have some suites ready with me, but not automated yet. >* Today*: Cut branch_9x and enter feature freeze on that branch I'd like to include SOLR-1569

Re: New branch and feature freeze for Solr 9.0.0

Solr 4 had both an Alpha and Beta release. Came with essentially full release cost, just indicated broad confidence in the initial releases and that users should give it a spin if possible to allow a more reasonable .0 release. [Mark Miller - Chat @ Spike](https://spikenow.com/r/a/?ref=spike-or

Re: New branch and feature freeze for Solr 9.0.0

I don't think we are allowed by Apache policy to broadly announce non-official releases like nightlies. There should be more than enough in 9.0 to warrant a major release. Most users will be reluctant to jump on a X.0.0 release, so we can mature a lot in 9.0.x. Perhaps if we start authoring the

Re: New branch and feature freeze for Solr 9.0.0

What do we think about a "beta" release, to give users (including *ourselves* in many cases) more time to try out 9.0 to report issues? I don't think a beta release would necessitate a typical feature freeze. If we ultimately decline on a beta release, a counter-proposal would be to promote our ni

Re: New branch and feature freeze for Solr 9.0.0

thanks Jan, PR looks good now! 😀 On Thu, Jan 6, 2022 at 11:52 AM Jan Høydahl wrote: > False alarm, I had a dirty checkout. > Please see if your PR passes precommit. > > Jan > > > 6. jan. 2022 kl. 19:49 skrev Jan Høydahl : > > > > Tim, I pushed a change to gradle that now uses hardcoded 9.0.0 fo

Re: New branch and feature freeze for Solr 9.0.0

False alarm, I had a dirty checkout. Please see if your PR passes precommit. Jan > 6. jan. 2022 kl. 19:49 skrev Jan Høydahl : > > Tim, I pushed a change to gradle that now uses hardcoded 9.0.0 for > tests.luceneMatchVersion. That's a stop-gap, will make it dynamically follow > the current luce

Re: New branch and feature freeze for Solr 9.0.0

Tim, I pushed a change to gradle that now uses hardcoded 9.0.0 for tests.luceneMatchVersion. That's a stop-gap, will make it dynamically follow the current lucene-version, but somehow my gradle project picked up an old version of org.apache.lucene.utils.Version class... Now I get a new error *

Re: New branch and feature freeze for Solr 9.0.0

gt; To: dev@solr.apache.org >> Subject: Re: New branch and feature freeze for Solr 9.0.0 >> >> Hello All! >> >> I was trying to check the blocker list to see if there is anything I can >> contribute >> with, but I observed that in the filter there is still

RE: New branch and feature freeze for Solr 9.0.0

r.apache.org > Subject: Re: New branch and feature freeze for Solr 9.0.0 > > Hello All! > > I was trying to check the blocker list to see if there is anything I can > contribute > with, but I observed that in the filter there is still the “fix version = > main (9.0)” > which

Re: New branch and feature freeze for Solr 9.0.0

Hello All! I was trying to check the blocker list to see if there is anything I can contribute with, but I observed that in the filter there is still the “fix version = main (9.0)” which is not a valid fix version now. Can you please check this? Thanks! Bence > On 2022. Jan 6., at 17:53, Timot

Re: New branch and feature freeze for Solr 9.0.0

Yep, the addVersion.py upgraded configs to 10.0.0 but we use Lucene 9.0.0 so we need to set those back :) Jan > 6. jan. 2022 kl. 17:53 skrev Timothy Potter : > > Thanks for the update Jan! > > One of my PRs (sync'd with main) is now failing precommit with: > > 105 actionable tasks: 103 execut

Re: New branch and feature freeze for Solr 9.0.0

Thanks for the update Jan! One of my PRs (sync'd with main) is now failing precommit with: 105 actionable tasks: 103 executed, 2 up-to-date 201FAILURE: Build failed with an exception. 202 203* Where: 204Script '/home/runner/work/solr/solr/gradle/validation/solr.config-file-sanity.gradle' line: 4

New branch and feature freeze for Solr 9.0.0

NOTICE: Branch branch_9_x has been cut and versions updated to 10.0 on 'main' branch. This follows the plan from previous notice about 9.0 release [1]. Here is what will happen: Today: Cut branch_9x and enter feature freeze on that branch Next few weeks: Remove blockers, prepare build & release