Re: I think I broke the build...

2022-07-20 Thread Uwe Schindler
Hi Eric, looks fixed. The yellow builds are typical test failures and have nothing to do with your changes. If precommit fails the build gets red (test failures are configured in Gradle to proceed and not exit). So the Gradle build does not fails and succeeds till end, only the test failures

Re: I think I broke the build...

2022-07-20 Thread Eric Pugh
4167 passed after I updated the build with the imports. https://ci-builds.apache.org/job/Solr/job/Solr-Check-main/4167/ 4168 failed, but it may have been timing issues…. > On Jul 19, 2022, at 10:00 PM, Eric Pugh > wrote: > > Good point! I hadn’t even thought of that. Will do, and if Jenk

Re: I think I broke the build...

2022-07-19 Thread Eric Pugh
Good point! I hadn’t even thought of that. Will do, and if Jenkins blows up, untangle in the morning. > On Jul 19, 2022, at 8:36 PM, Houston Putman wrote: > > If the spotless works on the PR, which the github actions indicate, then > you might as well just merge the PR instead of reverting. >

Re: I think I broke the build...

2022-07-19 Thread Houston Putman
If the spotless works on the PR, which the github actions indicate, then you might as well just merge the PR instead of reverting. On Tue, Jul 19, 2022 at 8:12 PM Eric Pugh wrote: > Good news, the spotless check for wildcard imports works…. The bad news > is that I thought SOLR-16271 was comple

I think I broke the build...

2022-07-19 Thread Eric Pugh
Good news, the spotless check for wildcard imports works…. The bad news is that I thought SOLR-16271 was complete and there were no wildcard imports… I can revert the change to main and branch_9x, or maybe someone wants to confirm https://github.com/apache/solr/pull/949 and then the build shoul