Re: Contribution steps

2022-01-06 Thread Abeleshev Artyom
Hi, Gus! Thanks for the support. I feel lucky as my MR was noticed and already has some discussion started. It seems it maybe become a part of the bigger issue of unifying request status responses. Hi, Mark! Thank you for the answer and your advice. I tried this technique at first and even get som

Re: Contribution steps

2022-01-02 Thread Eric Pugh
You did a really great write up, going to have to read it again ;-) As far as your first point on the Eclipse flagging unused imports, a PR to fix that would be welcome. You are pointing to a larger issue which is that we don’t have very good linting of our code. I looked at our gradle build

Re: Contribution steps

2022-01-01 Thread Mark Miller
Yeah that’s a pretty crappy situation for a new contributor. You basically have to make some educated guesses. Do more tests fail on average after your patch than before? Are the fails in tests that you added or in tests that look related (test with backup in the name for example)? If the fails d

Re: Contribution steps

2021-12-30 Thread Gus Heck
Hi Artem, Thanks for contributing! It sounds like you are doing pretty much the right things, possibly more diligently than most, and are up to the point that can sometimes be a bit frustrating, which is getting the attention of a committer with interest and time to review/submit your code (probab

Contribution steps

2021-12-30 Thread Abeleshev Artyom
Hi, everyone! I tried today to make my first contribution to Solr. I was targeting this issue https://issues.apache.org/jira/browse/SOLR-15842 concerning collection backup. I read all the contribution guides I found, but still don't get a clear picture of the process. I first made a detailed inve