Re: Change active replica counting in tests

2023-11-04 Thread Ilan Ginzburg
erhaps just reafactor the current >>> logic in compareActiveReplicaCountsForShards() into >>> clusterShape(), and put the logic you propose directly into >>> activeClusterShape(). >>> >>> Or ... simpler ... >>> >>> Redefine the API of compa

Re: Change active replica counting in tests

2023-11-04 Thread Ilan Ginzburg
t; >> Redefine the API of compareActiveReplicaCountsForShards to take in an >> Iterable instead of DocCollection, and then fix >> activeClusterShape() to pass in collectionState.getActiveSlices() while >> leaving clusterShape() alone. >> >> >> : Date: Fri, 3 Nov 20

Re: Change active replica counting in tests

2023-11-04 Thread Ilan Ginzburg
llection, and then fix > activeClusterShape() to pass in collectionState.getActiveSlices() while > leaving clusterShape() alone. > > > : Date: Fri, 3 Nov 2023 18:25:52 +0100 > : From: Ilan Ginzburg > : Reply-To: dev@solr.apache.org > : To: dev@solr.apache.org > : Subject: Chan

Re: Change active replica counting in tests

2023-11-03 Thread Chris Hostetter
ction, and then fix activeClusterShape() to pass in collectionState.getActiveSlices() while leaving clusterShape() alone. : Date: Fri, 3 Nov 2023 18:25:52 +0100 : From: Ilan Ginzburg : Reply-To: dev@solr.apache.org : To: dev@solr.apache.org : Subject: Change active replica counting in tests :

Change active replica counting in tests

2023-11-03 Thread Ilan Ginzburg
Hi, I plan to change the method compareActiveReplicaCountsForShards() in SolrCloudTestCase (code link ) that counts the total number of active replicas for a collection to only