Re: Alias property deletion confusion

2023-03-15 Thread Alex Deparvu
Thank you Gus and David for the very prompt replies! I was planning on updating the test with some assertions (that is how I ran into this). It seems that today setting to null will be a no-op, the property will not be changed. I'm not 100% sure what component handles this, it may be Zk. In my PR

Re: Alias property deletion confusion

2023-03-15 Thread Gus Heck
Yeah it does look like that test should be improved. I would expect that null and "" should be treated equivalently, but I don't recall what the code actually does. We should get some asserts in there and decide if we like the results of what we find. If not, fix it. On Wed, Mar 15, 2023 at 4:49 P

Re: Alias property deletion confusion

2023-03-15 Thread David Smiley
Interestingly, the part of that test which you commented on doesn't appear to assert/validate anything; it just does stuff. I suspect Gus may know the answer to your question. ~ David Smiley Apache Lucene/Solr Search Developer http://www.linkedin.com/in/davidwsmiley On Wed, Mar 15, 2023 at 2:13 

Alias property deletion confusion

2023-03-15 Thread Alex Deparvu
Hi, I am working on v2 apis for managing alias properties as part of SOLR-16393. I have a confusion I would love to clarify with the community related to an existing test (AliasIntegrationTest) that deletes an alias property. My understanding is that setting a property to 'empty string' will effe