Re: [DISCUSS] Standardizing module naming

2022-01-31 Thread David Smiley
I don't think we should embrace the module system in 9x; too much pain for too little gain. Maybe the only exception would be the SolrJ side as it affects our users more directly. For changing package names without breaking back-compat; depending on the plugin, it may already be supported via the

Re: [DISCUSS] Standardizing module naming

2022-01-31 Thread Jan Høydahl
Could this work? : Say, in 9.1 that we move feature FOO out of core into a module. We introduce a new SOLR_DEFAULT_MODULES=foo variable that will append to SOLR_MODULES, so if a 9.0 user has SOLR_MODULES=extracting and upgrades to 9.1, tey will not need to change anything and will get both. But

Re: [DISCUSS] Standardizing module naming

2022-01-30 Thread David Smiley
Yes; I was thinking something like this as well. This way we can make meaningful progress on modularization during the 9x series without breaking compatibility. ~ David Smiley Apache Lucene/Solr Search Developer http://www.linkedin.com/in/davidwsmiley On Sat, Jan 29, 2022 at 4:37 PM Jan Høydahl

Re: [DISCUSS] Standardizing module naming

2022-01-29 Thread Jan Høydahl
Hi, Seems to be not an overwhelming support for enforcing naming convention - at least not yet. So let the suggestion be a recommendation, and we'll see during 9.x what naming makes sense for new modules. I thought about whether we can extract code from solr-core into modules in a 9.x minor re

Re: [DISCUSS] Standardizing module naming

2022-01-24 Thread Jason Gerlowski
1. [Do we want a convention?] I'd be fine with a convention as long as we're willing to be flexible on it or evolve it as more modules come in. If we're expecting that 9.x will bring in other new modules but we don't know what those are, then we can't be too strict on any particular naming. 2. [sh

Re: [DISCUSS] Standardizing module naming

2022-01-21 Thread Houston Putman
I agree that standardizing the names would be nice. Another good option is to have a ref-guide page that lists all the modules, explains their purpose and links to relevant documentation. This page could be broken down by feature, much like your proposed names would be. On Fri, Jan 21, 2022 at 1:

Re: [DISCUSS] Standardizing module naming

2022-01-21 Thread David Smiley
+1 I like your proposed names. Some of our names are so short now that only us know what they are at a glance. ~ David Smiley Apache Lucene/Solr Search Developer http://www.linkedin.com/in/davidwsmiley On Fri, Jan 21, 2022 at 11:01 AM Jan Høydahl wrote: > There is kind of a proposal in > htt

Re: [DISCUSS] Standardizing module naming

2022-01-21 Thread Ishan Chattopadhyaya
> Or we could just leave it up to each module author as before :) +1 On Fri, Jan 21, 2022 at 9:31 PM Jan Høydahl wrote: > There is kind of a proposal in > https://github.com/apache/solr/blob/main/dev-docs/plugins-modules-packages.adoc#module-naming > already, but I'd like to discuss the general

Re: [DISCUSS] Standardizing module naming

2022-01-21 Thread Jan Høydahl
There is kind of a proposal in https://github.com/apache/solr/blob/main/dev-docs/plugins-modules-packages.adoc#module-naming already, but I'd like to discuss the general idea and what structure makes the most sense here. With my "type" proposal, you can easily map the new names for the various

Re: [DISCUSS] Standardizing module naming

2022-01-21 Thread David Smiley
Now is a great time to do some name changes. I suggest that you make a specific proposal of what the names should be. ~ David Smiley Apache Lucene/Solr Search Developer http://www.linkedin.com/in/davidwsmiley On Fri, Jan 21, 2022 at 8:18 AM Alessandro Benedetti wrote: > I would also add a tan

Re: [DISCUSS] Standardizing module naming

2022-01-21 Thread Jan Høydahl
Hi, This is off-topic for this thread. I'll post my answer to the "Moduarizing Solr with new contrib packages" thread if you don't mind https://lists.apache.org/thread/0k6s7h95yzwvhyk8049mr254ywr8vt2l Jan - To unsubscribe, e-

Re: [DISCUSS] Standardizing module naming

2022-01-21 Thread Alessandro Benedetti
I would also add a tangential question (rather than answers at this point): What makes a module(contrib) a module(contrib)? *From now on I'll use 'module' where I intend a package under contrib.* I am referring to first-party modules such as ltr or langid. My initial understanding was that a modul

[DISCUSS] Standardizing module naming

2022-01-21 Thread Jan Høydahl
Hi, In https://github.com/apache/solr/blob/main/dev-docs/plugins-modules-packages.adoc#module-naming I suggested standardizing contrib/module names. We did not discuss it in yesterday's committer m