Re: [DISCUSS] SIP-16: Polish and Prepare v2 APIs for v1 Deprecation

2025-02-14 Thread Jason Gerlowski
Hey Colvin, Awesome to hear you're making progress on the v2 API integration test(s). Thanks again for taking that up - it'll be a huge improvement! Feel free to be aggressive about tagging me on the PR when it's ready for review, if it seems like I missed it. > From a consumer POV what I have

Re: [DISCUSS] SIP-16: Polish and Prepare v2 APIs for v1 Deprecation

2025-02-14 Thread Jason Gerlowski
Hey Christos, Sorry for the delay - I don't know the logging functionality all that well and had to do some digging before I could reply. Replies below inline: > Let me know if I should create individual threads for such grouped questions If I put myself in the shoes of someone coming to this t

Re: [DISCUSS] SIP-16: Polish and Prepare v2 APIs for v1 Deprecation

2025-02-11 Thread Colvin Cowie
Just to say, I've been writing a smoke test for the v2 APIs when I've had a spare hour, I've done about half of it https://github.com/apache/solr/pull/3023/files I've found three b

Re: [DISCUSS] SIP-16: Polish and Prepare v2 APIs for v1 Deprecation

2025-02-10 Thread David Smiley
(An aside: discussion around a particular endpoint or even category of endpoints deserves its own thread IMO) > On Feb 10, 2025, at 4:40 PM, Christos Malliaridis > wrote: > - If this assumption is correct, can one update the log level of all nodes > with a single request? I can say Solr suppo

Re: [DISCUSS] SIP-16: Polish and Prepare v2 APIs for v1 Deprecation

2025-02-10 Thread Christos Malliaridis
I am very pleased by the progress we achieved in this topic so far, and I would like to add some input from the consumers' perspective. With the start of the new Admin UI development (SIP-7), we now have an additional source for evaluating the v2 API and polish it based on additional scenarios.

Re: [DISCUSS] SIP-16: Polish and Prepare v2 APIs for v1 Deprecation

2022-11-08 Thread David Smiley
Yeah I agree; no need to make a prediction on timing/versions at this point. ~ David Smiley Apache Lucene/Solr Search Developer http://www.linkedin.com/in/davidwsmiley On Tue, Nov 8, 2022 at 10:32 AM Jason Gerlowski wrote: > > removing v1 completely on 10.0 should depend on how soon 10.0 is >

Re: [DISCUSS] SIP-16: Polish and Prepare v2 APIs for v1 Deprecation

2022-11-08 Thread Jason Gerlowski
> removing v1 completely on 10.0 should depend on how soon 10.0 is happening I agree on both points: we need to give adequate time for the ecosystem and users to upgrade, and the major-release cadence will play a big role there. In general I think the "when should we remove v1" question is going

Re: [DISCUSS] SIP-16: Polish and Prepare v2 APIs for v1 Deprecation

2022-11-07 Thread Noble Paul
removing v1 completely on 10.0 should depend on how soon 10.0 is happening. are we prepared to do it within a year? On Tue, Nov 8, 2022 at 9:47 AM Jan Høydahl wrote: > I'm not against a more aggressive plan, i.e. remove v1 in 10.0 - users > will just have to stay longer on 9.x if they don't want

Re: [DISCUSS] SIP-16: Polish and Prepare v2 APIs for v1 Deprecation

2022-11-07 Thread Jan Høydahl
I'm not against a more aggressive plan, i.e. remove v1 in 10.0 - users will just have to stay longer on 9.x if they don't want to change their apps. My only worry there is that the Solr 10.0 release MAY happen already in Q2/Q3 2023, and that leaves just a few months preparation time for the entir

Re: [DISCUSS] SIP-16: Polish and Prepare v2 APIs for v1 Deprecation

2022-11-07 Thread Jason Gerlowski
Hi Jan, I guess I'd be a bit uncomfortable with deprecating v1 until v2 has had some decent dog-fooding. That's probably why the SIP suggests that deprecation coincide with "v2-used-internally": because the earlier "v2-complete" doesn't mean that anything even uses the v2 API yet. But that's jus

Re: [DISCUSS] SIP-16: Polish and Prepare v2 APIs for v1 Deprecation

2022-11-06 Thread Jan Høydahl
Both. 9x: v2 complete, deprecate v1 (and adding some deprecation noise to logs) 10.0 Switch to using v2 internally 11.0 Remove v1 Jan > 4. nov. 2022 kl. 16:25 skrev Jason Gerlowski : > > Hi Jan, > > Just trying to make sure I understand your suggestion. Are you suggesting: > > (1) that we an

Re: [DISCUSS] SIP-16: Polish and Prepare v2 APIs for v1 Deprecation

2022-11-04 Thread Jason Gerlowski
Hi Jan, Just trying to make sure I understand your suggestion. Are you suggesting: (1) that we announce v1 as deprecated at "V2-API-Complete" (instead of the later "v2-API-used-internally")? Or... (2) that we plan "v2-API-used-internally" to coincide with 10.0? (3) Or both? Best, Jason On Mon

Re: [DISCUSS] SIP-16: Polish and Prepare v2 APIs for v1 Deprecation

2022-10-31 Thread Jan Høydahl
Thanks for a thorough SIP. Wrt deprecation plan, could we not have "v2-API-Complete" in e.g. 9.5 (and deprecate v1). Then we wait until 10.0 with "v2-API-used-internally", and 11.0 for removing v1. Say we release 10.0 in March 2023, then the new main will be 11.0 and we can already remove v1 in

[DISCUSS] SIP-16: Polish and Prepare v2 APIs for v1 Deprecation

2022-10-31 Thread Jason Gerlowski
Hey all, This morning I published SIP-16, which proposes the changes necessary to "finish" (i.e. plug coverage gaps and polish) Solr's v2 APIs and a path to deprecating Solr's v1 APIs. The SIP can be found here: https://cwiki.apache.org/confluence/display/SOLR/SIP-16%3A+Polish+and+Prepare+v2+APIs