Re: [DISCUSS] Mark Rate Limiting as Experimental for Solr 9.0

Perhaps we need a dev-docs/alpha-beta-ga.adoc which lays out how developers should tag and document a feature/module as alpha or beta quality, what kind of logging it requires, perhaps it requires adding a -Dsolr.myfeature.enable=true if it is in solr-core, @lucene-experimental annotations etc.

Re: [DISCUSS] Mark Rate Limiting as Experimental for Solr 9.0

I meant to bring this up at the meeting, but forgot. How _do_ we mark it? Probably red guide, javadocs, and sample solrconfig.xml need to be updated? Maybe a log message if it’s turned on? Mike On Thu, Jan 20, 2022 at 12:45 PM Jan Høydahl wrote: > +1 to mark as Beta or experimental. Is this a d

Re: [DISCUSS] Mark Rate Limiting as Experimental for Solr 9.0

+1 to mark as Beta or experimental. Is this a doc-only change? Jan > 12. jan. 2022 kl. 16:59 skrev Mike Drob : > > Howdy folks, > > After finding two quick bugs in the rate limiting code[1][2], I suspect that > this feature has largely gone untested in our code up until now. I also > looked a

Re: [DISCUSS] Mark Rate Limiting as Experimental for Solr 9.0

+1 as well, I only discovered it because I saw the fixes that Mike made! > On Jan 13, 2022, at 3:43 AM, Bruno Roustant wrote: > > +1 > It will allow folks to try it (me included?) > > Bruno > > Le mer. 12 janv. 2022 à 17:00, Mike Drob > a écrit : > Howdy folks, > > A

Re: [DISCUSS] Mark Rate Limiting as Experimental for Solr 9.0

+1 It will allow folks to try it (me included?) Bruno Le mer. 12 janv. 2022 à 17:00, Mike Drob a écrit : > Howdy folks, > > After finding two quick bugs in the rate limiting code[1][2], I suspect > that this feature has largely gone untested in our code up until now. I > also looked at TestRequ

[DISCUSS] Mark Rate Limiting as Experimental for Solr 9.0

Howdy folks, After finding two quick bugs in the rate limiting code[1][2], I suspect that this feature has largely gone untested in our code up until now. I also looked at TestRequestRateLimiter and at least locally I'm getting a lot of EofException in the logs, which I think is unintended. This m