RE: Re: Solr collection naming convention (/how to find historical decision making)

2023-06-04 Thread Will White
Thanks again for your input so far! Sorry for the delay, it's been a busy week. I've put together a draft PR here: https://github.com/apache/solr/pull/1688 I'm not at all sure how to approach automated tests/verification for this PR, I can't see an obvious place to add unit tests - I'm torn betwe

Solr collection naming convention (/how to find historical decision making)

2023-05-25 Thread Will White
Hi Gus, thanks for the feedback! I traced the source of the commit to this: PR: https://github.com/apache/lucene-solr/pull/994 JIRA: https://issues.apache.org/jira/browse/SOLR-13662 where, from the outside, it looks like the regex just happened to be what was written; I couldn't find any specifi

RE: Re: Solr collection naming convention (/how to find historical decision making)

2023-05-25 Thread Will White
Hi Gus, thanks for the feedback! I traced the source of the commit to this: PR: https://github.com/apache/lucene-solr/pull/994 JIRA: https://issues.apache.org/jira/browse/SOLR-13662 where, from the outside, it looks like the regex just happened to be what was written; I couldn't find any specifi

Solr collection naming convention (/how to find historical decision making)

2023-05-22 Thread Will White
Hi all, There's an inconsistency in how Solr validates collection names between creating a collection through the Collection API (org.apache.solr.handler.admin.api.CreateCollectionAPI.java#L405, via the SolrIdentifierValidator) and through the Package Manager (org.apache.solr.packagemanager.Packag