Re: SolrJ backwards compatibility

2025-03-19 Thread Mike Drob
If you compare the results from https://github.com/search?q=%22new+RequestWriter%28%29%22+language%3AJava+path%3Aorg%2Fapache%2Fsolr&type=code&ref=advsearch (294) and https://github.com/search?q=%22new+RequestWriter%28%29%22+language%3AJava&type=code&ref=advsearch (307) that suggests there are 13 p

Re: Environment Variables in the Solr CLI...

2025-03-06 Thread Mike Drob
I think the guidance from clig.dev is pretty clear - when the configuration is generally stable from one invocation to the next, using environment variables is nice. Imagine starting a container, you set ZK_HOST once and then it's good for every invocation of the tools. Otherwise you have to have l

Value of the Solr Blog

2025-02-02 Thread Mike Drob
Hi Devs, I'd like to discuss the value of the Solr blog at https://solr.apache.org/blog.html We started it a year ago with a great idea that if we build it, content will come. But it looks like the breakdown of posts was: 2 meta posts about the blog 3 posts about C/C conferences (2 of which are

Fwd: JDK 24 Feature Freeze | Permanently Disabling the Security Manager

2024-12-13 Thread Mike Drob
Not sure if folks saw this, but it's possibly going to be relevant for our test suite since I think we're still using security manager in deprecated mode? -- Forwarded message - From: David Delabassee Date: Fri, Dec 13, 2024 at 9:17 AM Subject: JDK 24 Feature Freeze | Permanently

Re: PR labeling

2024-09-24 Thread Mike Drob
I think this is a common sense of false optimism, that we will come back and finish that PR we started. I too suffer from this frequently. Why does it matter if the PR is open or closed though? Re-opening is a single click, and after 6 months of zero activity it’s probably full of merge conflicts

Re: Simple Query String Builder for SolrJ

2024-08-20 Thread Mike Drob
At the risk of sounding ignorant, what is the advantage of this over using Lucene classes to programmatically build queries and then toString those? It's not a single class, but the lucene search package has always seemed pretty straightforward to me. https://lucene.apache.org/core/9_7_0/core/org/a

Re: Cleaning generated jmh classes

2024-08-01 Thread Mike Drob
I think the idea is correct, but I would also check if there is something we could do with the generator task to mark those directories as generated sources that should be cleaned up (I could be totally wrong here) On Thu, Aug 1, 2024 at 8:49 AM Jason Gerlowski wrote: > +1 - that makes sense afa

Re: SolrCloud architecture overview doc?

2024-05-30 Thread Mike Drob
I think Mark has given this as a presentation a few times, maybe https://www.youtube.com/watch?v=eVK0wLkLw9w On Thu, May 30, 2024 at 3:03 AM Ilan Ginzburg wrote: > Hi, > > I'm looking for a blog post or documentation giving a good overview of the > architecture of SolrCloud (not the user experie

Re: Is SolrBot too noisy / being ignored...?

2024-04-18 Thread Mike Drob
That’s probably a question for asf legal On Thu, Apr 18, 2024 at 5:36 PM Eric Pugh wrote: > Thanks for the work that has been done on some of these. > > I actually just ran through the process of updating commons-cli based on > what SolrBot provided. I *did* have to update a Java class, and I

Re: [PR] SOLR-16835: Add approximate-/select to OAS [solr]

2023-11-30 Thread Mike Drob
I think the goal is incremental migration from hand written to generated? So over time these endpoints converge rather than fragment. Maybe this isn’t the right way though, what do you think an appropriate direction would be? On Thu, Nov 30, 2023 at 8:33 AM Ishan Chattopadhyaya < ichattopadhy...@g

Re: PR reviewed

2023-08-23 Thread Mike Drob
Resending with corrected email address On Wed, Aug 23, 2023 at 11:13 AM Mike Drob wrote: > Hi Isabelle, > > It looks like there is a precommit check issue with the code still, can > you take a look and address that? You should be able to click on > "details" for the

Re: PR reviewed

2023-08-23 Thread Mike Drob
Hi Isabelle, It looks like there is a precommit check issue with the code still, can you take a look and address that? You should be able to click on "details" for the failing check, or run it locally using ./gradlew check -x test Thanks for your contribution! On Wed, Aug 23, 2023 at 9:52 AM Isa

Re: Welcome Alex Deparvu as Solr committer

2023-08-02 Thread Mike Drob
Welcome and congratulations! On Wed, Aug 2, 2023 at 8:47 AM David Smiley wrote: > Congratulations and well deserved Alex! > > ~ David > > > On Wed, Aug 2, 2023 at 4:10 AM Anshum Gupta wrote: > > > Hello everyone. > > > > On behalf of the Apache Solr PMC, I'm pleased to announce that Alex > Depa

Re: [Proposal] Security Working Group

2023-05-12 Thread Mike Drob
at 3:28 PM Arrieta, Alejandro < > > > > > aarri...@perrinsoftware.com> wrote: > > > > > > > > > > > Hello Team, > > > > > > > > > > > > Do you need to be a committer to join the group? > > > > >

Re: [Proposal] Security Working Group

2023-05-02 Thread Mike Drob
Howdy folks. I'd be happy to step into this working group. On Mon, May 1, 2023 at 12:34 PM Gus Heck wrote: > Awesome, glad to have you Jason, I in the end feel the same way about my > spot. Mostly I qualify as "concerned citizen", possibly with "who thought > about it some and has ideas" added.

Re: [Discuss] Solr 9.2.1 BugFix Release

2023-04-21 Thread Mike Drob
Eid Mubarak to all who celebrate and happy Friday to everybody else. And happy weekend to those who want to rest and not check emails constantly. And hey, wouldn't you know it, the next workday isn't until 72 hours away! Let's try to be accommodating to all of our friends, yes? On Thu, Apr 20, 202

Re: Rethinking dependency upgrades

2023-04-03 Thread Mike Drob
I think for a lot of us the rapid release cycle of other projects is surprising coming from our ASF context. Here a release takes three votes and at least three days and comparatively quite a bit of process. For some other project, a release involves as little as clicking a button to make a github

Re: Welcome David Smiley as Solr's new PMC chair

2023-03-31 Thread Mike Drob
Thank you for taking this mantle, David. On Fri, Mar 31, 2023 at 3:39 PM Gus Heck wrote: > Congratulations! > > On Fri, Mar 31, 2023 at 3:51 PM Andy Webb wrote: > > > Congratulations David! > > > > Andy > > > > On Fri, 31 Mar 2023 at 20:47, Alessandro Benedetti > > > wrote: > > > > > Congrats

Re: Running all tests via Crave.io

2023-01-26 Thread Mike Drob
lopers only get to use the commands that are approved by the > > Solr community leaders. > > > > Would that work? > > Thanks, > > -Uv > > > > On Jan 26 2023, at 8:09 am, Mike Drob wrote: > > > Having massive infrastructure to run PRs is pretty co

Re: Running all tests via Crave.io

2023-01-26 Thread Mike Drob
Having massive infrastructure to run PRs is pretty cool. I'm worried about letting arbitrary people run code on these machines though - a single 'crave run -- mine_bitcoin.exe' would ruin the system for everybody, or it's not hard to imagine a slightly more indirect case where an attacker adds a t

Re: Welcome Michael Gibney to the Solr PMC

2022-12-21 Thread Mike Drob
Welcome and well deserved! On Wed, Dec 21, 2022 at 3:41 PM Michael Gibney wrote: > Thank you for the invitation, and the warm welcome! It's an honor to > be a part of this community. > > Michael > > On Wed, Dec 21, 2022 at 4:06 PM Jan Høydahl wrote: > > > > Congrats and welcome Michael! > > > >

Re: Publishing dependency vulnerability information

2022-11-30 Thread Mike Drob
Hi Arnout, Thanks for starting this conversation, I have had similar thoughts recently but hadn’t put them to action yet. >From my understanding, SBOM are meaningful in the context of a release, not necessarily an arbitrary code point. VEX on the other hand could be updated between releases as in

Re: 9.1 RC1 build errors (GPG)

2022-10-25 Thread Mike Drob
>From `gradlew helpPublishing` If you the following command fails with your GPG configuration, you can not use an external GPG process with gradle: echo foo | gpg --batch --no-tty --armor --detach-sign --use-agent --local-user YOUR_KEY_NAME Can you verify that command works for you? You m

Re: On tests labelled @Slow...

2022-07-22 Thread Mike Drob
Ok, another correction, tests.slow is enabled by default, so if they're already running most of the time then it's pretty "safe" to just axe the annotations. On Thu, Jul 21, 2022 at 8:19 PM Mike Drob wrote: > Hmm... correction here - the failing Slow tests also happen to

Re: On tests labelled @Slow...

2022-07-21 Thread Mike Drob
Hmm... correction here - the failing Slow tests also happen to be AwaitsFix tests so they were broken anyway. I wonder why my gradle command decided to include them. On Thu, Jul 21, 2022 at 8:14 PM Mike Drob wrote: > While I would agree with you in principle, I don't think the Slow tes

Re: On tests labelled @Slow...

2022-07-21 Thread Mike Drob
bably PR validation too. > > ~ David Smiley > Apache Lucene/Solr Search Developer > http://www.linkedin.com/in/davidwsmiley > > > On Thu, Jul 21, 2022 at 4:00 PM Mike Drob wrote: > > > Howdy devs, > > > > I stumbled onto https://issues.apache.org/jira/browse/SOLR

On tests labelled @Slow...

2022-07-21 Thread Mike Drob
Howdy devs, I stumbled onto https://issues.apache.org/jira/browse/SOLR-16304 while trying to upgrade our Lucene dependency and it's motivated me to take a little bit of a look at our tests. I know that there are dragons here and I'm under no illusions that I can fix everything, but I feel like a t

Re: Missing tags for recent 8.x Solr releases

2022-07-11 Thread Mike Drob
+dev@solr -dev@lucene to bcc Hi Nemo, The canonical location of our tags for the 8.x release line is https://gitbox.apache.org/repos/asf?p=lucene-solr.git;a=tags The tags for 9.x (and future) will all be at https://gitbox.apache.org/repos/asf?p=solr.git;a=tags as you have found. This is the unfo

[ANNOUNCE] Apache Solr 8.11.2 released

2022-06-21 Thread Mike Drob
The Lucene and Solr PMCs are pleased to announce the release of Apache Solr 8.11.2. Solr is the popular, blazing fast, open source NoSQL search platform from the Apache Lucene project. Its major features include powerful full-text search, hit highlighting, faceted search, dynamic clustering, da

Re: [RESULT] [VOTE] Release Lucene/Solr 8.11.2 RC2

2022-06-21 Thread Mike Drob
We're currently having issues with updating the project websites, which we need before we can officially announce the release on the mailing list. It's being tracked under INFRA-23404 On Tue, Jun 21, 2022 at 9:47 AM Colvin Cowie wrote: > Thanks! > > On Tue, 21 Jun 2022 at 16:31, Shawn Heisey wr

[RESULT] [VOTE] Release Lucene/Solr 8.11.2 RC2

2022-06-17 Thread Mike Drob
It's been >72h since the vote was initiated and the result is: +1 6 (6 binding) 0 1 -1 0 This vote has PASSED On Mon, Jun 13, 2022 at 12:05 PM Mike Drob wrote: > Please vote for release candidate 2 for Lucene/Solr 8.11.2 > > The artifacts can be downloade

Re: v2 API "Broader Changes" and Next Steps

2022-06-16 Thread Mike Drob
I suspect that #2 will inspire #1, once we start trying to use it everywhere in SolrJ and other areas we’ll see patterns and antipatterns emerge and guide us on what the API should be. On Thu, Jun 16, 2022 at 6:05 AM Jason Gerlowski wrote: > Hi all, > > I've been working over the last few months

Older Docker Images

2022-06-14 Thread Mike Drob
I noticed that with the 9.0 release we made the decision to yank all of the older docker images. I wanted to get some clarity on the practical implications. On our Official Images page I see that we list 8.11.1 and 9.0 - is the plan going forward to continue to list only the latest in each line? S

[VOTE] Release Lucene/Solr 8.11.2 RC2

2022-06-13 Thread Mike Drob
Please vote for release candidate 2 for Lucene/Solr 8.11.2 The artifacts can be downloaded from: https://dist.apache.org/repos/dist/dev/lucene/lucene-solr-8.11.2-RC2-rev17dee71932c683e345508113523e764c3e4c80fa You can run the smoke tester directly with this command: python3 -u dev-tools/scripts/

Re: [VOTE] Release Lucene/Solr 8.11.2 RC1

2022-06-13 Thread Mike Drob
This RC did not receive enough votes to pass, I've fixed the bug pointed out by Houston and will be moving on to RC2. Thanks! On Sun, Jun 12, 2022 at 2:57 PM Mike Drob wrote: > Thanks for finding that, Houston! It was an issue during backporting that > I've corrected. I'l

Re: [VOTE] Release Lucene/Solr 8.11.2 RC1

2022-06-12 Thread Mike Drob
rowse/SOLR-16191>, which is included in > this release. > Not exactly sure what went wrong, but the example still passed? > > - Houston > > On Wed, Jun 8, 2022 at 8:50 PM Mike Drob wrote: > >> to: dev@lucene, dev@solr >> >> Please vote for release candidate 1

[VOTE] Release Lucene/Solr 8.11.2 RC1

2022-06-08 Thread Mike Drob
to: dev@lucene, dev@solr Please vote for release candidate 1 for Lucene/Solr 8.11.2 The artifacts can be downloaded from: https://dist.apache.org/repos/dist/dev/lucene/lucene-solr-8.11.2-RC1-reva9ed1e5fccbd1a84c78194a1329a7e1a3032ffc6 You can run the smoke tester directly with this command: pyt

Re: Bugfix release Lucene/Solr 8.11.2

2022-06-03 Thread Mike Drob
OLR-16227) and have a fix for it ( > https://github.com/apache/solr/pull/887). Can you wait on the release for > 8.11.2 till I can backport this? > > Thank you, > Kiran. > > On Tue, May 31, 2022 at 9:21 AM Mike Drob wrote: > >> Howdy folks, now that Lucene 9.2 has wrappe

Re: Bugfix release Lucene/Solr 8.11.2

2022-05-31 Thread Mike Drob
ecause >> I have an in-flight PR with a backport. I'll complete and merge that PR. >> >> Jan >> >> >> 13. mai 2022 kl. 01:03 skrev Mike Drob : >> >> To: dev@lucene, dev@solr >> >> NOTICE: >> >> I am planning on preparing a b

Re: Cleaning up IntelliJ warnings in code base

2022-05-27 Thread Mike Drob
Declaring an unused thrown exception in tests isn't the most critical change, but cleaning this up might help us discover accidental API signature changes in the future. If a test throws an exception then JUnit will figure it out and fail the test anyway, which is probably what we want to do regard

Re: Cleaning up IntelliJ warnings in code base

2022-05-27 Thread Mike Drob
I would try to handle them in several small PRs either grouped by module or by warning type. On Fri, May 27, 2022 at 9:24 AM Eric Pugh wrote: > Hey all, was poking around at a unit test while watching TV and noticed > lots of warnings from IntelliJ, little stuff like exceptions being thrown > th

Re: Update Lucene dependency version

2022-05-16 Thread Mike Drob
Some folks have mentioned being interested in working on this, but I don't know that anybody has picked it up yet. Most were likely waiting to do that work post 9.0 release which is still just wrapping up. The big change that worries me is the module system, I wonder if we will be affected or if i

Bugfix release Lucene/Solr 8.11.2

2022-05-12 Thread Mike Drob
To: dev@lucene, dev@solr NOTICE: I am planning on preparing a bugfix release from branch branch_8_11 (likely mid next week) Please observe the normal rules for committing to this branch: * Before committing to the branch, reply to this thread and argue why the fix needs backporting and how lo

Re: [VOTE] Release Solr 9.0.0 RC5

2022-05-10 Thread Mike Drob
in >>>>> http://joelsolr.blogspot.com/ >>>>> >>>>> >>>>> On Fri, May 6, 2022 at 11:26 AM Eric Pugh < >>>>> ep...@opensourceconnections.com> wrote: >>>>> >>>>>> +1 (binding) >>>

Re: [VOTE] Release Solr 9.0.0 RC5

2022-05-05 Thread Mike Drob
[INFO] There was an issue with SOLR-16133 that caused the smoke tester to fail with gpg errors on macOS. That change has been reverted from branch_9_0 and if you run into it, please try fetching the latest changes and running the smoke tester command again. On Thu, May 5, 2022 at 2:48 AM Jan Høyda

Re: [RESULT] [VOTE] Release Solr 9.0.0 RC4

2022-05-03 Thread Mike Drob
I created SOLR-16177 for the license header issue. I am backporting SOLR-16133 as a minor smoke tester improvement. Mike On Tue, May 3, 2022 at 8:35 AM Kevin Risden wrote: > I'm backporting https://issues.apache.org/jira/browse/SOLR-16164 - >

Re: [VOTE] Release Solr 9.0.0 RC4

2022-05-02 Thread Mike Drob
I'll change my vote to a -1. Two reasons, #1 is based on the license header issue that I mentioned, and will work on getting that sorted out this week. #2 is that while I personally don't see the severity of the latest identified issues as blocking, if we're going to immediately turn around and st

Re: [VOTE] Release Solr 9.0.0 RC4

2022-04-29 Thread Mike Drob
+1 (binding) Smoketester succeeded with Java 11 and Java 17 -- SUCCESS! [2:04:03.678208] Unlike for some others, this succeeded on my first try. I guess I'm just lucky :) Tested building an application that uses EmbeddedSolrServer and depends on our maven artifacts - validated SOLR-16157, SOLR

Re: [RESULT][VOTE] Release Solr 9.0.0 RC3

2022-04-13 Thread Mike Drob
nitiated and the result is: >>> >>> +1 7 (7 binding) >>> 0 1 >>> -1 0 >>> >>> This vote has PASSED >>> >>> Congratulations everyone for reaching this milestone! >>> >>> There are still a few loose end

Re: [VOTE] Release Solr 9.0.0 RC3

2022-04-08 Thread Mike Drob
If we're not doing anything with the release artifacts anyway (since you'll be on holiday, Jan), would it be fine to leave it open over the weekend? I didn't get nearly the amount of testing done on this that I wanted to, mainly trying to figure out if SOLR-16143 was a real problem (yes) or just a

Re: Solr github permissions

2022-04-01 Thread Mike Drob
Reach out to ASF Infra for help troubleshooting either on slack #asfinfra or through INFRA jira. Make sure your profile on id.apache.org is linked to your GitHub profile On Fri, Apr 1, 2022 at 8:32 AM Joel Bernstein wrote: > My github permissions appear to be incorrect or missing for the Solr >

Re: [VOTE] Release Solr 9.0.0 RC2

2022-03-31 Thread Mike Drob
Anshum and I are both seeing the smoke tester leak GPG agents, filed https://issues.apache.org/jira/browse/SOLR-16132 for it. On Thu, Mar 31, 2022 at 9:06 AM Ishan Chattopadhyaya < ichattopadhy...@gmail.com> wrote: > Sure, I'll take a stab at it. But, no need to wait for me to get to it, I > migh

Re: [VOTE] Release Solr 9.0.0 RC1

2022-03-29 Thread Mike Drob
Never mind, I think that last one is because I ran from a src unpack and not a bin unpack like I thought I was running. Probably could have a better error message instead of that CNFE. On Tue, Mar 29, 2022 at 3:41 PM Mike Drob wrote: > -1: > > Java 11 Only - SUCCESS! [0:35:46.949352]

Re: [VOTE] Release Solr 9.0.0 RC1

2022-03-29 Thread Mike Drob
-1: Java 11 Only - SUCCESS! [0:35:46.949352] Java 11 + 17 via python3 -u dev-tools/scripts/smokeTestRelease.py --test-java17 /Library/Java/JavaVirtualMachines/jdk-17.jdk/Contents/Home https://dist.apache.org/... run tests w/ Java 17 and testArgs='-Dtests.nightly=false -Dtests.badapples=false '..

Re: Welcome Houston Putman as Solr's new PMC chair

2022-03-17 Thread Mike Drob
Thank you both for the effort you’ve put in and will put in! On Thu, Mar 17, 2022 at 12:11 PM Anshum Gupta wrote: > Thank you, Jan for all the effort and for serving as the chair. > > Congratulations and good luck, Houston! > > > > On Thu, Mar 17, 2022 at 6:14 AM Jan Høydahl wrote: > >> Hi, >>

Re: CloudSolrClient; do we deprecate or not?

2022-03-16 Thread Mike Drob
I feel like CloudSolrClient doesn't imply anything about HTTP 1 or 2, anything about Apache or Jetty (or java.net.http). If we have exposed those internal details in some ways, then that is unfortunate and should be addressed. I personally never use CloudHttp2SolrClient because I kind of assumed t

Re: [Operator] 1.0 Release Questions

2022-03-04 Thread Mike Drob
On Fri, Mar 4, 2022 at 9:43 AM Timothy Potter wrote: > Also, we should draw a hard line in the sand on which versions of Solr > the 1.0 operator supports! It'll likely be one of the later 8.x > versions. > In addition to this, I think we will need to be aware of what versions of Kubernetes each

Re: Define what requires a JIRA and an entry in CHANGES.txt?

2022-02-16 Thread Mike Drob
If this is about my PR https://github.com/apache/solr/pull/641 then I'm happy to add a JIRA for it. I initially said that I wasn't sure if it was big enough to warrant an issue because it was almost entirely test changes, and even then not really functional changes. But it's 200 lines of difference

Re: Warning - Ref Guide has been migrated to Antora

2022-02-14 Thread Mike Drob
The build should download and install node/npm/npx for you under .gradle, so no new prerequisites aside from gradle pulling in new dependency trees. Do you have more detail on the error message so we can investigate further? On Mon, Feb 14, 2022 at 10:30 PM David Smiley wrote: > When I do "gw c

Re: Warning - Ref Guide has been migrated to Antora

2022-02-10 Thread Mike Drob
I just went through the process of merging up an older PR and the ref guide link checker helpfully alerted me to my old broken links! Took me a few minutes to find the right page, but overall the speedbump was very very minor. Thanks for taking this across the finish line, Houston! On Thu, Feb 10

Re: Solr partial shutdown problem

2022-01-24 Thread Mike Drob
Is this a 9.0 blocker? Seems like any APIs we change would be internal only? On Mon, Jan 24, 2022 at 9:26 AM Jan Høydahl wrote: > Hi, > > Solr runs in a servlet container (Jetty), and normally you want one webapp > to not be able to cause issues for another one by e.g. running > System.exit(). >

Re: [DISCUSS] Mark Rate Limiting as Experimental for Solr 9.0

2022-01-20 Thread Mike Drob
s a doc-only change? > > Jan > > 12. jan. 2022 kl. 16:59 skrev Mike Drob : > > Howdy folks, > > After finding two quick bugs in the rate limiting code[1][2], I suspect > that this feature has largely gone untested in our code up until now. I > also looked at TestReques

Re: [VOTE] Stop releasing Solr binary ZIP artifact

2022-01-16 Thread Mike Drob
+0 I have no issue with this, but would maybe like to see a discussion on the user@ list first and to hear the thoughts of our Windows users (Uwe? Steve? Shawn?) On Sun, Jan 16, 2022 at 1:08 PM Jan Høydahl wrote: > Hi, > > I know that ZIP vs TGZ has been discussed before, but I'd like to propos

Re: Quarterly Committer Meetings

2022-01-13 Thread Mike Drob
+1 Do we have a place to gather agenda items ahead of time? On Thu, Jan 13, 2022 at 8:12 AM Gus Heck wrote: > +1, please send a link to me too. > > On Thu, Jan 13, 2022 at 3:52 AM Bruno Roustant > wrote: > >> +1 >> I'll try to make it, probably with some lateness. >> >> Bruno >> >> Le jeu. 13

Re: New branch and feature freeze for Solr 9.0.0

2022-01-12 Thread Mike Drob
I'd like to consider getting SOLR-15919 into 9.0 because I'm not sure if it would be allowed in 9.1. I just realized we would want this while looking at the code tonight, don't even have a patch to present yet. It would be a fairly substantial cha

Re: Discuss SIP-14 Embedded Zookeeper

2022-01-12 Thread Mike Drob
21 at 9:17 AM Mike Drob wrote: > > If people are running 100 or 1000 node clusters and use each node as a > ZK server, by default, what kind of impact would that have? > > Bad. Very very bad. The largest ZK quorum I've personally seen is 9, and > I've heard rumo

[DISCUSS] Mark Rate Limiting as Experimental for Solr 9.0

2022-01-12 Thread Mike Drob
Howdy folks, After finding two quick bugs in the rate limiting code[1][2], I suspect that this feature has largely gone untested in our code up until now. I also looked at TestRequestRateLimiter and at least locally I'm getting a lot of EofException in the logs, which I think is unintended. This m

Re: Quarterly Committer Meetings

2022-01-11 Thread Mike Drob
David, Thank you for taking the initiative! Happy New Year! In your text you propose noon, but the time link is for 11am Boston Time. Which did you mean? Mike On Mon, Jan 10, 2022 at 8:36 PM David Smiley wrote: > Hello everyone, > > I would like to propose that we have Solr committer online m

Re: Log4j < 2.15.0 may still be vulnerable even if -Dlog4j2.formatMsgNoLookups=true is set

2021-12-14 Thread Mike Drob
The MDC Patterns used by solr are for the collection, shard, replica, core and node names, and a potential trace id. All of those are restricted to alphanumeric, no special characters like $ or { needed for the injection. And trying to access a collection that didn’t exist Returns 404 without loggi

Re: Log4J RCE vulnerability

2021-12-10 Thread Mike Drob
I’ve already posted an item to our security page. If you have improvements, please add them, my copy was certainly rushed. Informing our user list is a good idea too! On Fri, Dec 10, 2021 at 10:13 AM Cassandra Targett wrote: > Uwe, I understand Log4J 2.15.0 is going to address the vulnerabilit

Re: Strange error in Solr with Lucene 9.0.0

2021-12-08 Thread Mike Drob
Sorry, meant to add that the reproduction is before the update to lucene 9.0.0 release. But I'm also able to reproduce it after the upgrade, like Uwe noted. On Wed, Dec 8, 2021 at 12:53 PM Mike Drob wrote: > I was just able to reproduce this on my local macOS machine with > >

Re: Strange error in Solr with Lucene 9.0.0

2021-12-08 Thread Mike Drob
I was just able to reproduce this on my local macOS machine with gradlew test --tests TestRandomDVFaceting.testRandomFaceting -Dtests.seed=3B93BA61C91F26D4 -Dtests.slow=true -Dtests.locale=uz-Latn -Dtests.timezone=America/Santa_Isabel -Dtests.asserts=true -Dtests.file.encoding=UTF-8 on commit 028

Re: First class support for node roles

2021-12-05 Thread Mike Drob
ve and not strict/non-strict. You have a role or you don't. > What that means is up to the code implementing the role. > >>>>>>> > >>>>>>> Roles should be free to configure a preference order (binary, or > n-ary or whatever,

Re: First class support for node roles

2021-12-02 Thread Mike Drob
be stricter about this, but there are also >> a lot of users who wouldn't want those to be strict either (like "query" >> nodes). >> >>>> >> >>>> Maybe we just put in stronger guarantees that if a non-overseer role >> node

Re: First class support for node roles

2021-12-01 Thread Mike Drob
er. Overseer shouldn't be special in this regard. Noble wrote: > If we do that how do we know if xyz is a role or a node in the following request? You're absolutely correct, thanks for pointing this out. Let's leave it as is. On Tue, Nov 30, 2021 at 2:21 PM Ishan Chattopadhyaya

Re: First class support for node roles

2021-11-29 Thread Mike Drob
On Mon, Nov 29, 2021 at 2:40 PM Gus Heck wrote: > > >> CLARIFICATION: I do not like that we are storing node liveness in two >> different places now. We have the live nodes and we have the node roles >> stored in two different places in zookeeper and it feels like this would >> lead to race condi

Re: First class support for node roles

2021-11-29 Thread Mike Drob
Replying to the top post in this thread because there has been a lot of discussion and I don't want to look like I'm continuing any of those particular threads. I finally had time to sit down and think about this with the attention it deserves and am generally happy with how the conversation has s

Re: [VOTE 2] SIP-15 Node roles

2021-11-26 Thread Mike Drob
FYI this vote is over a major holiday weekend in the United States. On Thu, Nov 25, 2021 at 12:55 AM Ishan Chattopadhyaya < ichattopadhy...@gmail.com> wrote: > Hi all, > > SIP-15 for first class support of node roles has been proposed. > https://cwiki.apache.org/confluence/display/SOLR/SIP-15+Nod

Re: First class support for node roles

2021-11-23 Thread Mike Drob
must be updated to reflect the results of discussion in >>>>> the google doc. >>>>> 2) The fact that the wiki has been updated, and that you think the >>>>> discussion is at an end must be posted here, preferably with a summary on >>>>> the l

Re: First class support for node roles

2021-11-23 Thread Mike Drob
-1, I would like to see a proposal on list where it will be permanently available in the archives instead of being directed to a Google doc which can be edited at any point in time. This has been an incredibly difficult proposal to keep track of. Mike On Tue, Nov 23, 2021 at 6:09 AM Ishan Chatto

Re: Should JVM Args list in Admin UI Dashboard be sorted?

2021-11-19 Thread Mike Drob
If they are sorted, I would prefer that we use a stable sort so that folks can be aware of which setting is in effect for "last one wins" situations. I also would echo Gus's question to verify that the not-sorted version is meaningful rather than shuffled. If the sort we are using is not a stable

Reference Guide has DRAFT watermark

2021-11-09 Thread Mike Drob
When looking at an 8_10 reference guide, many pages have the DRAFT watermark on them - e.g. https://solr.apache.org/guide/8_10/solr-upgrade-notes.html Is this my browser caching something or do other people see it too? If this is on the server side, can we update these? We'll have to do this again

Re: 8.11 release candidate

2021-11-05 Thread Mike Drob
After additional discussion on https://issues.apache.org/jira/browse/SOLR-15762 I think there is a small patch that would be nice to include for 8.11 if there is still time. Thanks On Fri, Nov 5, 2021 at 5:05 AM Adrien Grand wrote: > All blockers are now addressed, I'll proceed with building a r

Fwd: 8.11 and 9.0 feature freeze

2021-11-02 Thread Mike Drob
Adding Solr dev for 8.11 info. -- Forwarded message - From: Adrien Grand Date: Tue, Nov 2, 2021 at 8:08 AM Subject: 8.11 and 9.0 feature freeze To: Lucene Dev Hello all, I just created branches in preparation for the upcoming 8.11 and 9.0 releases. Here's how branches map to L

Collection delete behavior

2021-10-15 Thread Mike Drob
Currently, if we try to delete a collection that doesn't exist we return an error to the caller (status 400 I think) and log a stack trace about no collection found in our logs. When running this as part of test infrastructure, we always delete our collections at the end, and I don't much care if t

Re: Testing docker images during build

2021-10-15 Thread Mike Drob
nvoke a >> self-test right after build: >> >> docker run --rm mysolr:mytag selftest.sh >> >> Jan >> >> > 13. okt. 2021 kl. 19:37 skrev Mike Drob : >> > >> > I've seen some other docker images have a test stage built into the >>

Testing docker images during build

2021-10-13 Thread Mike Drob
I've seen some other docker images have a test stage built into the dockerfile, which makes some sense to me. We could potentially use this in our builds to add a light-weight validation to the images we produce, I'm not intending to replace the full suite we have under testDocker -- maybe that com

Re: ZkTestServer Watch limit violations

2021-10-05 Thread Mike Drob
I remember talking to Tim and Mark about these a bit ago, and I think I had started to remove them in my patch to switch to the ZK Embedded Server. On Tue, Oct 5, 2021 at 11:49 AM Timothy Potter wrote: > I don't have an opinion on this and don't recall the details from 7+ > years ago but I suspe

Re: Welcome Ilan Ginzburg to Solr PMC

2021-09-22 Thread Mike Drob
Welcome, Ilan! On Wed, Sep 22, 2021 at 12:40 PM Furkan KAMACI wrote: > Congrats Ilan! > > On 22 Sep 2021 Wed at 20:34 Houston Putman wrote: > >> Congrats Ilan! >> >> On Wed, Sep 22, 2021 at 1:25 PM Anshum Gupta wrote: >> >>> Congratulations and welcome, Ilan! >>> >>> On Wed, Sep 22, 2021 at 9:

Re: New branch and feature freeze for Lucene/Solr 8.10.0

2021-09-20 Thread Mike Drob
ory-trend-of-recent-failures.html#series/org.apache.solr.search.TestFiltering.testRandomFiltering >> >> I beasted it and 3/10 failed: >> >> [beaster] Tests with failures [seed: A5F8AAEF7994FE2B] (first 3 out of 10): >> [beaster] - org.apache.solr.search.TestFiltering.testRandomFiltering &

Re: New branch and feature freeze for Lucene/Solr 8.10.0

2021-09-17 Thread Mike Drob
aries Jan mentioned. Just > my two cents. > > On Sat, 18 Sep, 2021, 12:02 am Mike Drob, wrote: > >> The second library you linked, Jan, is AGPL. Thank you for continuing to >> look for alternatives. >> >> I have some regular expressions cooked up locally that I thi

Re: New branch and feature freeze for Lucene/Solr 8.10.0

2021-09-17 Thread Mike Drob
ng: >> >> : > >> >> : > java PrintManifest.java lucene-core-9.0.0-SNAPSHOT.jar >> >> : > >> >> : > shows: >> >> : > >> >> : > lucene-core-9.0.0-SNAPSHOT.jar: 9.0.0-SNAPSHOT >> >> : > de45b68c90

Re: New branch and feature freeze for Lucene/Solr 8.10.0

2021-09-15 Thread Mike Drob
e required attribute)? This way we wouldn't care > about the implementation details of how manifest wraps the lines (or > escapes characters). > > D. > > On Wed, Sep 15, 2021 at 8:46 PM Mike Drob wrote: > >> The benchmark jar has the info we need… sort of. When I bu

Re: New branch and feature freeze for Lucene/Solr 8.10.0

2021-09-15 Thread Mike Drob
Sep 15, 2021 at 9:46 AM Timothy potter wrote: > can someone also please look into that benchmark jar issue? > > Sent from my iPhone > > On Sep 15, 2021, at 9:44 AM, Nhat Nguyen > wrote: > >  > Thanks Mayya and Mike! I will backport it to the 8.10 branch. > > O

Re: Discuss SIP-14 Embedded Zookeeper

2021-09-15 Thread Mike Drob
scaling up to nowadays? If people are running 100 or 1000 node > clusters and use each node as a ZK server, by default, what kind of impact > would that have? > > On Tue, Sep 14, 2021 at 8:20 PM Mike Drob wrote: > >> I like the idea of starting nodes in a ZK-only mode, proba

Re: New branch and feature freeze for Lucene/Solr 8.10.0

2021-09-15 Thread Mike Drob
, >> wrote: >> >> >> >> Building RC1 now ... stay tuned. >> >> >> >> On Thu, Sep 9, 2021 at 2:30 PM Timothy Potter >> wrote: >> >> > >> >> > Thanks for the update Mike! >> >> > >> >

Re: Discuss SIP-14 Embedded Zookeeper

2021-09-14 Thread Mike Drob
/cwiki.apache.org/confluence/display/SOLR/SIP-6+Solr+should+own+the+bootstrap+process>, > as we'd want to control startup/shutdown behavior wrt the zk, e.g. start > embedded zk before solr and stop solr before stopping zk. Perhaps also > gracefully exiting the quorum on planned sh

Discuss SIP-14 Embedded Zookeeper

2021-09-14 Thread Mike Drob
Devs, We've previously discussed maintaining ZK as being an operational hurdle for some groups getting started or migrating to SolrCloud from non-ZK cloud mode. I'd like to discuss the idea of embedding ZK in our own process control. Please see the SIP at https://cwiki.apache.org/confluence/displ

Re: [Operator] [VOTE] Release the Solr Operator v0.4.0 RC1

2021-09-10 Thread Mike Drob
+1, but there's a bunch of problems that I ran into. Successfully smoke tested the Solr Operator v0.4.0! Ran into this error because I had go 1.17 installed instead of 1.16: ./hack/check_format.sh These files did not pass the ‘go fmt’ check, please run ‘go fmt’ on them: dif

Re: New branch and feature freeze for Lucene/Solr 8.10.0

2021-09-09 Thread Mike Drob
Hi Tim, I'm still working on SOLR-1, the code and benchmarking both look pretty good, but I've got a few last unit tests that I need to chase down. Hopefully taken care of by today or tomorrow, I'll be sure to keep you updated though. On Thu, Sep 9, 2021 at 11:39 AM Timothy Potter wrote: > >

  1   2   >