Re: uniqueKey customization... maybe shouldn't be allowed?

2025-07-11 Thread Gus Heck
I suppose the only reservation is with respect to breaking back compatibility with existing systems that never used it, or configured it differently. However I would say that if we don't decide to make it mandatory, those are bugs. I will say that one of the things I discovered in the opensearch w

Re: uniqueKey customization... maybe shouldn't be allowed?

2025-07-11 Thread David Smiley
Places where "id" is assumed (sometimes via a constant ID): * CloudSolrClient.directUpdate * HashBasedRouter (base class of CompositeIdRouter (DocRouter), and it does call super to use that) * AtomicUpdateDocumentMerger * SpellCheckCollator An aside: CommonParams should not be the dumping ground o

uniqueKey customization... maybe shouldn't be allowed?

2025-07-11 Thread David Smiley
I've seen uniqueKey customized in a SolrCloud setting recently. I thought I recalled some discussion or issues/limitations with this. I've seen a regret of making it customizable[1], and I concur with the sentiment. Does anyone recall a custom uniqueKey posing problems? My search in JIRA didn't