Re: SolrJ timeouts

2025-05-24 Thread Luke Kot-Zaniewski (BLOOMBERG/ 919 3RD A)
That's a good point. I didn't immediately realize it would effectively be the minimum of the two idle timeout values but now that I think about it, it makes sense. Looking at it from a higher level though, since Jetty appears to honor idleTimeout at the request level (either through the aforem

Re: SolrJ timeouts

2025-05-24 Thread David Smiley
Luke, thanks for writing this test!! I looked at your test (esp. org.apache.solr.client.solrj.impl.Http2SolrClientTest#testIdleTimeoutWithHttpClient ) in more detail. You tested going from having a sufficient amount of idle timeout for the request to succeed, then down to a lower amount, asserti

Re: [JENKINS] Solr » Solr-Test-9.x - Build # 7477 - Still Failing!

2025-05-24 Thread David Smiley
I pushed the fix a minute ago; at about the time you sent your email. No need to post a 9x backport PR in general for little issues like this. If a backport is more complicated then a PR for it is a good idea. On Sat, May 24, 2025 at 12:15 PM Matthew Biscocho (BLOOMBERG/ 919 3RD A) < mbisco...@bl

Re: [JENKINS] Solr » Solr-Test-9.x - Build # 7477 - Still Failing!

2025-05-24 Thread Matthew Biscocho (BLOOMBERG/ 919 3RD A)
Sorry about that. I got caught on the backport doing a bad cast not possible with Java 11. Will make sure to run precommit and tests before backporting next time. Here is the corresponding PR to fix the 9x build https://github.com/apache/solr/pull/3363 From: dsmi...@apache.org At: 05/24/25 11:1

Re: [JENKINS] Solr » Solr-Test-9.x - Build # 7477 - Still Failing!

2025-05-24 Thread David Smiley
Matthew, you broke the 9x build; every CI email for 9x builds are failing for 2 days now. Sadly we don't have a CI failure notification to notify the author of the offending commits. When committing / pushing, it's imperative that you run "./gradlew precommit" at a minimum; ideally run tests as w