Re: [DISCUSS] Solr 9.7 release

2024-07-25 Thread Eric Pugh
Really hoping to get https://github.com/apache/solr/pull/2593 and https://github.com/apache/solr/pull/2577 in for 9.7 as well. I’ve asked on the user mailing list for help testing the changes out on Windows, so hopefully we get some confirmation the work I’ve done is bug free and it won’t hold

Re: Exception handling in background tasks

2024-07-25 Thread David Smiley
(face-palm) -- you were very clear but I misread it; sorry Andrey! I agree with what you propose / imply: code should *not* call submit() if it ignores the returned Future; it misses the point of the submit method! execute() should be used in that case. In fact I recently proposed this very impr

Re: [DISCUSS] Solr 9.7 release

2024-07-25 Thread Gus Heck
I hadn't realized it wasn't marked for 9.7 but https://issues.apache.org/jira/browse/SOLR-17298 was always intended as a blocker as well. On Thu, Jul 25, 2024 at 12:31 PM Anshum Gupta wrote: > Sure, I'll wait until the 30th. Thanks for letting me know. > > On Wed, Jul 24, 2024 at 9:39 PM Ishan C

Re: [JENKINS-EA] Solr-main-Linux (64bit/hotspot/jdk-23-ea+33) - Build # 19448 - Unstable!

2024-07-25 Thread Chris Hostetter
: Yes, JDK 9 changed the default provider to be the compat one, but Java 21 : should already default to the CLDR. But maybe theres a difference in parsing. Mmmm, I think you're mistaken somewhere ... jdk9, jdk11, jdk17, and jdk21 all say the default behavior is the same... >> The default order

Re: [DISCUSS] Solr 9.7 release

2024-07-25 Thread Anshum Gupta
Sure, I'll wait until the 30th. Thanks for letting me know. On Wed, Jul 24, 2024 at 9:39 PM Ishan Chattopadhyaya < ichattopadhy...@gmail.com> wrote: > Hi Anshum, > I'm still working on unblocking SOLR-13350. Can we please push the date > back by a week, say 30 July? > > Thanks and regards, > Isha

Re: Exception handling in background tasks

2024-07-25 Thread Andrey Bozhko
Hi David, In the example of SolrZkClient.ProcessWatchWithExecutor#process, it should be possible to use ExecutorService#submit and ExecutorService#execute methods interchangeably - because either method would run the task in the background. So I went ahead and replaced `submit` with `execute`, and