Re: Change active replica counting in tests

2023-11-04 Thread Ilan Ginzburg
Sorry, I posted a wrong unrelated PR link in my previous email. The PR for this change is https://github.com/apache/solr/pull/2063 "SOLR-17067 SolrCloudTestCase activeClusterShape() should only consider active shards" On Sat, Nov 4, 2023 at 11:2

Re: Change active replica counting in tests

2023-11-04 Thread Ilan Ginzburg
Created SOLR-17067 and PR 1965 On Sat, Nov 4, 2023 at 8:28 PM Ilan Ginzburg wrote: > Thanks Hoss for your input. I was focused on that specific method (to > contribute back a test change we made on our

Re: Change active replica counting in tests

2023-11-04 Thread Ilan Ginzburg
Thanks Hoss for your input. I was focused on that specific method (to contribute back a test change we made on our Solr fork) and was missing the big picture. I therefore explored your suggestions. I agree activeClusterShape() is where the change makes the most sense. I can of course limit it to t