Re: [DISCUSS] Future of SolrCell in Solr

2023-03-08 Thread Shawn Heisey
On 3/7/2023 3:48 PM, Jan Høydahl wrote: * Move SolrCell to a package, outside of Solr's tarball SOLR-15951 * Deprecate SolrCell SOLR-13973 * Keep in Solr but use Tika-Server

RE: Re: Re: Re: Re: Re: Low untunable default FastWriter output buffer - possible reason for slow single threaded data receiving from Solr on 1Gigabit+ networks while scroll, search etc

2023-03-08 Thread Fikavec F
Thank you for your work Noble Paul, it's very interesting.   You were so attentive that you noticed and replaced "else if (val instanceof Double) { gen.writeNumber(val.floatValue()); }" with "else if (val instanceof Double) { gen.writeNumber(val.doubleValue()); }". But I just copied the code (Line

Re: Google Java Style: shall we declare intent to follow?

2023-03-08 Thread David Smiley
BTW, I believe a rename of a file/class should *not* appear to git blame as happening on every line. Not something you said but maybe implied and not something I want to bring about with my proposal either. ~ David Smiley Apache Lucene/Solr Search Developer http://www.linkedin.com/in/davidwsmiley

Re: Google Java Style: shall we declare intent to follow?

2023-03-08 Thread Ishan Chattopadhyaya
My biggest concern with widespread code changes, like the effort to format the entire codebase or to suppress warnings etc in the past, is that relevant history gets polluted. It isn't as easy to trace back changes to their issues by browsing code. To me, reading code is easier if I can quickly fo

Re: Solr documentation questions

2023-03-08 Thread Houston Putman
Hey Alejandro! It would be great to get some help with the docs!! Are there other test(s) to run apart from compiling, seeing that > documentation finished correctly and checking your change display correctly > in your local copy? > The following command will build a local site for you to look a

Re: Google Java Style: shall we declare intent to follow?

2023-03-08 Thread Justin Sweeney
+1 If we do so, I'd suggest we also add that to the Contributing docs somewhere so it is readily apparent for new contributors: https://github.com/apache/solr/blob/main/CONTRIBUTING.md. On Wed, Mar 8, 2023 at 3:29 AM Bruno Roustant wrote: > +1 > I find that a standard is more productive because

Re: jira account request

2023-03-08 Thread Kevin Risden
https://selfserve.apache.org/jira-account.html This is brand new. Let us know how it works. Kevin Risden On Wed, Mar 8, 2023 at 8:56 AM Arrieta, Alejandro < aarri...@perrinsoftware.com> wrote: > Hello team, > > If possible I want to request a Jira account for the Solr project. > > Kind Regards

Re: Solr documentation questions

2023-03-08 Thread Kevin Risden
- Not all documentation changes need a Jira. If its a big change like adding a new page/section it might be worth a Jira to help call it out in the release notes (solr/CHANGES.txt) - Depending on the scope of the multiple changes - it could be one PR or could be broken up. - "./gradlew check -x tes

Solr documentation questions

2023-03-08 Thread Arrieta, Alejandro
Hello Team, I want to help with Solr documentation and I have some newbie questions: -Changes in documentation in Solr git repo, do they need a doc bug ticket filled? -If making more than one change to documentation, do you need one PR for all of them or each change on a separate PR. If a doc b

jira account request

2023-03-08 Thread Arrieta, Alejandro
Hello team, If possible I want to request a Jira account for the Solr project. Kind Regards, Alejandro Arrieta Rios

Re: Re: Re: Re: Re: Low untunable default FastWriter output buffer - possible reason for slow single threaded data receiving from Solr on 1Gigabit+ networks while scroll, search etc

2023-03-08 Thread Noble Paul
I've opened the PR https://github.com/apache/solr/pull/1440 Some tests are still failing. I'll address them later On Tue, Mar 7, 2023 at 1:56 PM David Smiley wrote: > Fantastic! > I really appreciate you working with the community on this one. > > ~ David Smiley > Apache Lucene/Solr Search Dev

Re: Google Java Style: shall we declare intent to follow?

2023-03-08 Thread Bruno Roustant
+1 I find that a standard is more productive because I wouldn't have to question anymore about what is the consistent naming/pattern to use. Le mar. 7 mars 2023 à 19:05, Anshum Gupta a écrit : > I like the idea, David. Overall it makes for code that is easier to read > and understand, specially

Re: Welcome Andy Webb as Solr committer

2023-03-08 Thread Bruno Roustant
Welcome! Le mar. 7 mars 2023 à 21:14, Tomás Fernández Löbbe a écrit : > Welcome Andy! > > On Tue, Mar 7, 2023 at 7:53 AM Gus Heck wrote: > > > Welcome :) > > > > On Tue, Mar 7, 2023 at 10:37 AM Michael Gibney < > mich...@michaelgibney.net> > > wrote: > > > > > Welcome, and congrats! > > > > > >