Re: Potential Dead Code: MetricsCollectorHandler, SolrReporter

2022-07-01 Thread David Smiley
These are opt-in plugins living in Solr-core. A user can configure reporters on all their nodes publishing to a node that has the MetricsCollectorHandler configured. AB explains their use here: https://issues.apache.org/jira/browse/SOLR-15007?focusedCommentId=17234635&page=com.atlassian.jira.plugi

Re: Potential Dead Code: MetricsCollectorHandler, SolrReporter

2022-07-01 Thread Jason Gerlowski
> Andy, if you'd like to open a pull request for the removal of the code +1 to what Christine said, and thanks for volunteering to take it off my list Andy. If you do push up a PR and no one jumps on it, feel free to plug it here and I'll definitely take a look. Best, Jason On Fri, Jul 1, 2022

Re: Potential Dead Code: MetricsCollectorHandler, SolrReporter

2022-07-01 Thread Christine Poerschke (BLOOMBERG/ LONDON)
I concur with the analysis that this is dead code (in main and branch_9x branches) after the removal and deprecation in SOLR-15416 and SOLR-15502 tickets. Andy, if you'd like to open a pull request for the removal of the code, that would be wonderful. Thanks, Christine From: dev@solr.apache.o