Re: New branch and feature freeze for Solr 9.0.0

2022-03-01 Thread David Smiley
I suppose the biggest spots for peer review are: * use of brackets [ ] in the metric name where the request handler is. Thus "/select[shard]" * There is a fundamental difference in how the metrics are tracked on a handler. Previously, there were metrics for all of /select (no matter how it was inv

Re: New branch and feature freeze for Solr 9.0.0

2022-03-01 Thread Timothy Potter
Hi David, I read your note about SOLR-14401 but not clear what you need from me? Seems like you're renaming existing metrics and removing "distrib" from handlers that don't support a distrib mode, seems right to me. I actually haven't done much work on the metrics backend. For Grafana, it's a JSO

Re: [JENKINS] Solr » Solr-Check-9.0 - Build # 385 - Still Failing!

2022-03-01 Thread Kevin Risden
Ok this was addressed in SOLR-14920 Kevin Risden On Tue, Mar 1, 2022 at 10:55 AM Kevin Risden wrote: > Does anyone else see the error about spotless on branch_9_0? > > I checked this locally and it doesn't fail for me. > > Execution failed for task ':solr:solrj:spotlessJavaCheck'. > > The foll

Re: [Operator] Bugfix release Solr Operator v0.5.1

2022-03-01 Thread Houston Putman
The draft release notes can be found here: https://cwiki.apache.org/confluence/display/SOLR/Solr+Operator+Release+Notes+v0.5.1 On Tue, Mar 1, 2022 at 11:19 AM Houston Putman wrote: > NOTICE: > > I am now preparing for a Solr Operator bugfix release from branch > release-0.5 > > Please observe t

[Operator] Bugfix release Solr Operator v0.5.1

2022-03-01 Thread Houston Putman
NOTICE: I am now preparing for a Solr Operator bugfix release from branch release-0.5 Please observe the normal rules for committing to this branch: * Before committing to the branch, reply to this thread and argue why the fix needs backporting and how long it will take. * All issues accepted

Re: [JENKINS] Solr » Solr-Check-9.0 - Build # 385 - Still Failing!

2022-03-01 Thread Kevin Risden
Does anyone else see the error about spotless on branch_9_0? I checked this locally and it doesn't fail for me. Execution failed for task ':solr:solrj:spotlessJavaCheck'. > The following files had format violations: solr/solrj/src/java/org/apache/solr/client/solrj/impl/XMLResponseParser.java

Re: New branch and feature freeze for Solr 9.0.0

2022-03-01 Thread David Smiley
On Tue, Mar 1, 2022 at 4:46 AM Jan Høydahl wrote: > Hi, and welcome to March! > > Our initial goal of a RC1 within February slipped, but we are still in a > good position. > I'll try to summarize the current code blockers: > > > *SOLR-16061 Decouple CloudSolrClient from ZkStateReader* > > This i

Re: New branch and feature freeze for Solr 9.0.0

2022-03-01 Thread Jan Høydahl
Hi, and welcome to March! Our initial goal of a RC1 within February slipped, but we are still in a good position. I'll try to summarize the current code blockers: SOLR-16061 Decouple CloudSolrClient from ZkStateReader This is new, a spin-off from SOLR-15342 to prepare for solrj modularization