Re: Define what requires a JIRA and an entry in CHANGES.txt?

2022-02-16 Thread David Smiley
This has been discussed and documented before: https://cwiki.apache.org/confluence/display/SOLR/Commit+Process+Guidelines#CommitProcessGuidelines-UpdatingCHANGES.txt In general I push for us to not waste our time on busy-work like this, not to mention hassling everyone else in perpetuity who reads

Re: Define what requires a JIRA and an entry in CHANGES.txt?

2022-02-16 Thread Anshum Gupta
As I've been going through the CHANGES.txt entries for the 9.0 release notes, here's what I have been feeling: - CHANGES entries are mostly for users who're trying to understand what changes they'd be picking up in a specific release. We link it from the release notes too. - Anything that requires

Re: Define what requires a JIRA and an entry in CHANGES.txt?

2022-02-16 Thread Timothy Potter
The approach I've always used is: any change to the codebase needs a JIRA. Any change a user would care about (in the most liberal sense) needs a changes.txt entry. Refactoring that doesn't impact APIs (such as changes to tests) doesn't need a changes.txt entry. In general it's rare for me to make

Re: Define what requires a JIRA and an entry in CHANGES.txt?

2022-02-16 Thread Eric Pugh
It wasn’t just your PR, there has been a couple times when I was kind of on the fence and not sure. > On Feb 16, 2022, at 6:45 PM, Mike Drob wrote: > > If this is about my PR https://github.com/apache/solr/pull/641 > then I'm happy to add a JIRA for >

Re: Define what requires a JIRA and an entry in CHANGES.txt?

2022-02-16 Thread Mike Drob
If this is about my PR https://github.com/apache/solr/pull/641 then I'm happy to add a JIRA for it. I initially said that I wasn't sure if it was big enough to warrant an issue because it was almost entirely test changes, and even then not really functional changes. But it's 200 lines of difference

Re: Running Streaming Expression & getting Cosine Similarity Score

2022-02-16 Thread Jan Høydahl
Hi, In the JIRA you opened (https://issues.apache.org/jira/browse/SOLR-16014) I asked you to consult the "users" mailing list. This is the "dev" mailing list and is unfortunately not for user questions either :) Try once more and you'll get help on the users-list Jan > 16. feb. 2022 kl. 12:48

Re: New branch and feature freeze for Solr 9.0.0

2022-02-16 Thread Jan Høydahl
These are the three main code-blockers for doing 9.0.0 RC1: (P) SOLR-15064 Atomic/partial updates to nested docs should not assume _route_ dsmiley dsmiley (S) SOLR-14290 Fix NPE in SolrTestCaseJ4 breaking external usage for master/9.x gus gus (S) SOLR-14401 """distrib"" reque

Running Streaming Expression & getting Cosine Similarity Score

2022-02-16 Thread suyash.sangale
Hi, I wanted to know where can I run Streaming Expression in Solr. Also how can I achieve getting cosine similarity as response. Is there any included feature in the latest version ? Reference link - https://issues.apache.org/jira/browse/SOLR-12890 For example - sort( select( search(food_col

Re: Define what requires a JIRA and an entry in CHANGES.txt?

2022-02-16 Thread Ishan Chattopadhyaya
IMO, any code change should have a JIRA and CHANGES.txt. Substantial ref guide changes should have a JIRA. Refactoring should definitely get a JIRA, I'll be surprised if any refactoring has happened without a JIRA. On Wed, Feb 16, 2022 at 12:52 PM Eric Pugh wrote: > Hi all!Do we have a writt