Re: Propose changing the "dist" layout

2022-01-12 Thread David Smiley
(now to dev@solr.apache.org not lucene) I'm just re-surfacing an older conversation where it is time for us to take action. Some JIRAs were recently created, and a separate thread about the prometheus-exporter Full thread in ponymail: https://lists.apache.org/thread/jbs4ds0w3r3v1hto9rqhs4qq1xfk5z6

Re: Quarterly Committer Meetings

2022-01-12 Thread Shawn Heisey
On 1/12/2022 3:46 AM, Alessandro Benedetti wrote: +1, the time works for me and I am in! Do we have a calendar event already? Looking forward to seeing a Google Meet link! I blocked out some time on my calendar for this. Thanks, Shawn --

Re: New branch and feature freeze for Solr 9.0.0

2022-01-12 Thread Mike Drob
I'd like to consider getting SOLR-15919 into 9.0 because I'm not sure if it would be allowed in 9.1. I just realized we would want this while looking at the code tonight, don't even have a patch to present yet. It would be a fairly substantial cha

Re: Modularizing Solr with new contrib packages

2022-01-12 Thread David Smiley
Shawn: * RE redundancies of stuff in /dist/, see https://issues.apache.org/jira/browse/SOLR-15916 * RE "contrib" vs "module" vs "package", see: https://issues.apache.org/jira/browse/SOLR-15917 * RE not shipping these extras with the Solr distribution, see: "slim distro" mention in the document "Sol

Prometheus Exporter; new location?

2022-01-12 Thread David Smiley
The inevitable rename of the "contribs" module to something else ( https://issues.apache.org/jira/browse/SOLR-15917 ) will be a time for us to move the prometheus exporter somewhere else, as it is not a module/package within Solr; it's an independent service with its own dependencies; one of which

Re: Modularizing Solr with new contrib packages

2022-01-12 Thread Shawn Heisey
On 1/12/2022 8:31 AM, Jan Høydahl wrote: I think there are lots of pieces of code in solr-core that can easily be extracted the same way. Some perhaps even for 9.0.0, as it slims down the core and reduces attack surface for most users as well. I think it would be really awesome if we had a co

Re: Modularizing Solr with new contrib packages

2022-01-12 Thread David Smiley
(my previous email was accidentally sent; it was incomplete!) Speaking of modularization: * https://issues.apache.org/jira/browse/SOLR-15904 "Move SQLHandler to a contrib/module/package" -- just a JIRA issue; I don't have time for this one now. * https://issues.apache.org/jira/browse/SOLR-14660 "M

Re: Modularizing Solr with new contrib packages

2022-01-12 Thread David Smiley
All awesomeness! Speaking of modularization: * https://issues.apache.org/jira/browse/SOLR-15904 Move SQLHandler to a contrib/module/package -- just a JIRA issue; I don't have time for this one now. * https://issues.apache.org/jira/browse/SOLR-14660 ~ David Smiley Apache Lucene/Solr Search Develo

Re: Fails: PackageManagerCLITest

2022-01-12 Thread Houston Putman
Reopened the issue, because the tests are in fact not fixed yet. Working on it now. On Wed, Jan 12, 2022 at 11:07 AM Jan Høydahl wrote: > Hi, > > Yes, I touched the part checking version constraint, and added the check > for invalid SemVer expression syntax when adding SolrVersion class. > Earli

Re: Discuss SIP-14 Embedded Zookeeper

2022-01-12 Thread Mike Drob
I put together a draft PR for the first stage of the SIP which is to cut over unit tests to using the embedded ZK. There's a few things missing, like setting limiters and our injected use of ZKDatabase, but we've also had discussions about how those are not particularly useful as is. The biggest c

Re: Fails: PackageManagerCLITest

2022-01-12 Thread Jan Høydahl
Hi, Yes, I touched the part checking version constraint, and added the check for invalid SemVer expression syntax when adding SolrVersion class. Earlier an invalid expression in a package manifest would print "Version incompatible!..." and exit. After the change it will print "Error in version

Re: Quarterly Committer Meetings

2022-01-12 Thread Houston Putman
+1 I am down, thanks for taking the initiative David! On Wed, Jan 12, 2022 at 10:41 AM Jan Høydahl wrote: > Thanks for arranging this David! > > It's 6pm in Europe but I'll try to make it. > > Jan > > 11. jan. 2022 kl. 19:10 skrev David Smiley : > > Woops; wrong URL. I meant what I said -- noon

Re: [Solr] does not use the filterCache

2022-01-12 Thread Daniele Antuzi
Hi Mikhail, Thank you for your clarification. It has been really useful. I understood what my problem was. I used the debugger adding a breakpoint in the method get() of the CaffeineCache. The execution was blocked only when the flag useFilterCache == true. So, the breakpoint not hit plus the name

Re: Fails: PackageManagerCLITest

2022-01-12 Thread Houston Putman
Hey David, The errors should disappear now that https://issues.apache.org/jira/browse/SOLR-15902 is in. Note that this was caused partially by a buggy semver library mis-calculating version expressions (branch_9x), but also the versions were hardcoded so that when main upgraded to 10.0.0, it no l

[DISCUSS] Mark Rate Limiting as Experimental for Solr 9.0

2022-01-12 Thread Mike Drob
Howdy folks, After finding two quick bugs in the rate limiting code[1][2], I suspect that this feature has largely gone untested in our code up until now. I also looked at TestRequestRateLimiter and at least locally I'm getting a lot of EofException in the logs, which I think is unintended. This m

Re: Quarterly Committer Meetings

2022-01-12 Thread Jan Høydahl
Thanks for arranging this David! It's 6pm in Europe but I'll try to make it. Jan > 11. jan. 2022 kl. 19:10 skrev David Smiley : > > Woops; wrong URL. I meant what I said -- noon EST. > Correct URL > https://www.timeanddate.com/worldclock/fixedtime.html?msg=Solr+Committer+Meeting&iso=20220120T

Modularizing Solr with new contrib packages

2022-01-12 Thread Jan Høydahl
Hi, I just did an attempt to lift out the JWT auth plugin from solr-core into its own contrib [1] and it wasn't too hard. I think it gives much better insight into the dependency situation and nice to have a separate solr-jwt-auth-9.0.0.jar This is also a first step towards converting it to a p

Re: Quarterly Committer Meetings

2022-01-12 Thread Alessandro Benedetti
+1, the time works for me and I am in! Do we have a calendar event already? Cheers -- Alessandro Benedetti Apache Lucene/Solr Committer Director, R&D Software Engineer, Search Consultant www.sease.io On Tue, 11 Jan 2022 at 18:10, David Smiley wrote: > Woops; wrong URL