Re: Solr and Jetty and Servlets

2021-11-07 Thread David Smiley
Sonatype-lift giving a passing review on a PR is not a qualification we have on our project to merge. Therefore it's also pointless to tell it to "ignore" anything. The bot provides feedback at specific line numbers that we should at least briefly consider; ideally say something about in the comm

Re: Solr and Jetty and Servlets

2021-11-07 Thread Gus Heck
https://github.com/apache/solr/pull/397 is the new PR for those interested. Will try to merge it next weekend if no objections are found. Am a little unclear on what sonatype-lift is doing. I told it to ignore one (that I filed a separate ticket for) then made a fix thinking that that would cull o