Re: ZkCmdExecutor

2021-10-02 Thread Mark Miller
I filed https://issues.apache.org/jira/browse/SOLR-15672 Leader Election is flawed - for future reference if anyone looks at tackling leader election issues. I’ll drop a couple notes and random suggestions there Mark On Sat, Oct 2, 2021 at 12:47 PM Mark Miller wrote: > At some point digging thr

Re: ZkCmdExecutor

2021-10-02 Thread Mark Miller
At some point digging through some of this stuff, I often start to think, I wonder how good our tests are at catching certain categories of problems. Various groups of code branches and behaviors. I do notice that as I get the test flying, they do start to pick up a lot more issues. A lot more bug

Re: ZkCmdExecutor

2021-10-02 Thread Mark Miller
Tim was referring to code that addresses those issues from the ref branch. I’ve been trying to remember the items that Ilan has brought up, for reason I thought this was third one, but I can only come up with shard leader loss and overseer loss other than leader sync. I also recalled I have slide

Re: ZkCmdExecutor

2021-10-02 Thread David Smiley
I just want to say that I appreciate the insights you shared over the last couple days. By "copy paste", was Tim referring to copying your insights and pasting them into the code? This is what I was thinking. Or at least some way to make these insights more durable / findable. Could be a link f