Re: Solr and Jetty and Servlets

2021-08-18 Thread Mark Miller
The gap is not ideal and I’m not advocating for it, but it does help keep you honest. There is gap between a mini cluster and a packed dist regardless and it’s really something that should be covered by testing even with more of a lineup. I’m very into dependency injection in Solr. I was adding ju

RE: Tracking out when and why a certain code was added in specific Solr class

2021-08-18 Thread yael.mushin...@exlibrisgroup.com.INVALID
Thank you very much, was able to find the Jira that triggered the problematic for me code change. Just wonder how to proceed … My company is now in the middle of a process to upgrade from Solr 5.4 to Solr 8.7 . Performance tests showed that performance got worse … An investigation (jstack, debug

Re: Solr and Jetty and Servlets

2021-08-18 Thread Gus Heck
The thing that concerned me most about JettySolrRunner is that it differed from what we use in production essentially leaving a gap of untested functionality, so if we move one or the other to match I'm pretty much happy. The thing it (and ServeletContextHandler) don't do is start anything else wit

Re: Solr and Jetty and Servlets

2021-08-18 Thread Jan Høydahl
Hi, Clearly a refactor is needed here, thanks Gus for diving in deep. Like Uwe I don't want us to be more dependent upon web.xml or Jetty's startup logic. That's why I filed SIP-6 (https://cwiki.apache.org/confluence/display/SOLR/SIP-6+Solr+should+own+the+bootstrap+process) to try to describe

Re: Tracking out when and why a certain code was added in specific Solr class

2021-08-18 Thread Eric Pugh
I just did this to try and understand when the “indent” checkbox in the Solr Admin changed behavior! I go into Github, and find the file, and then use the Blame link: https://github.com/apache/solr/blame/720fa009118c229e0969fa21523ff3c4cf91f931/solr/webapp/web/partials/query.html

Tracking out when and why a certain code was added in specific Solr class

2021-08-18 Thread yael.mushin...@exlibrisgroup.com.INVALID
Hello, Can someone assist in explaining how I can understand regarding a certain code change I see between versions of Solr, when and part of what commit it was added/changed? Thank you,

RE: Solr and Jetty and Servlets

2021-08-18 Thread Uwe Schindler
Hi, Thanks Mark, I fully agree with you on this: Booting up jetty with start.jar and using a web application is dramatically slower. Nevertheless, I think that we should go away with the web application alltogether. We can still stay with the servlet API, but just – as in Gus patch – to

Re: Solr and Jetty and Servlets

2021-08-18 Thread Mark Miller
Agreement or not, I wouldn’t step in front of whatever you did. I doubt anyone is going to take on actually pulling out of a web app because it’s easier to lean on it for configuration and I doubt start up speed is a very high priority for most. It had never really occurred to me in the past that