Re: HDFS tests

2021-05-13 Thread Gus Heck
I realize in retrospect this sounds like I'm pinning it on you personally, which is not what I mean to do... I'll make a 9x blocker ticket specific to this and awaits fix, and mark it related to 14660. On Thu, May 13, 2021 at 10:25 AM Gus Heck wrote: > Ok can I mark these tests AwaitsFix with t

Re: HDFS tests

2021-05-13 Thread Gus Heck
Ok can I mark these tests AwaitsFix with that URL or do you want a separate ticket for fixing this problem? On Thu, May 13, 2021 at 10:20 AM Andras Salamon wrote: > We are planning to migrate it to a package: > https://issues.apache.org/jira/browse/SOLR-14660 please do not remove it > before tha

Re: HDFS tests

2021-05-13 Thread Andras Salamon
We are planning to migrate it to a package: https://issues.apache.org/jira/browse/SOLR-14660 please do not remove it before that if it's possible. Andras On Thu, May 13, 2021 at 3:59 PM Gus Heck wrote: > Given that HdfsDirectory has been deprecated since 8.6 and is now > breaking, is it time to

Re: HDFS tests

2021-05-13 Thread Gus Heck
Given that HdfsDirectory has been deprecated since 8.6 and is now breaking, is it time to declare this removed for 9.0? On Thu, May 13, 2021 at 9:29 AM David Smiley wrote: > I believe those tests failed when Lucene changed the Directory APIs from > big endian to little endian: > * LUCENE-9047 -

Re: Use of Java "var"; allow it now?

2021-05-13 Thread David Smiley
Not particularly; it's a nice-to-have. When doing work that is targeted specifically at main/9.0, it's a shame to be constrained. ~ David Smiley Apache Lucene/Solr Search Developer http://www.linkedin.com/in/davidwsmiley On Thu, May 13, 2021 at 8:59 AM Gus Heck wrote: > Is there any reason no

Re: HDFS tests

2021-05-13 Thread David Smiley
I believe those tests failed when Lucene changed the Directory APIs from big endian to little endian: * LUCENE-9047 - Directory APIs should be little endian ~ David Smiley Apache Lucene/Solr Search Developer http://www.linkedin.com/in/davidwsmiley On Thu, May 13, 2021 at 5:38 AM Andras Salamon

Re: Use of Java "var"; allow it now?

2021-05-13 Thread Gus Heck
Is there any reason not to wait until we have a 9.0 and 8x is on maintenance? I think that was the plan originally, though I can't find the prior discussion. On Thu, May 13, 2021 at 8:14 AM David Smiley wrote: > I propose removing the blockage on use of the "var" Java keyword. > https://github.c

Use of Java "var"; allow it now?

2021-05-13 Thread David Smiley
I propose removing the blockage on use of the "var" Java keyword. https://github.com/apache/solr/pull/124 Of course, it should be used judiciously, especially while there are still 8.x releases. ~ David Smiley Apache Lucene/Solr Search Developer http://www.linkedin.com/in/davidwsmiley

Re: HDFS tests

2021-05-13 Thread Andras Salamon
Hi, I tested locally with the provided seed the test failed 3 out of 3 times. I reverted SOLR-15329 (that's my commit) and tested again, it also failed 3 out of 3 times. The fail rates for this test there is a small jump between 04-12 and 04-19 and a large one between 04-26 and 05-03. 2021-03