Re: Proposal to pin the Lucene snapshot version on main

2021-04-30 Thread Ishan Chattopadhyaya
> What submodules don't solve is releases - if you're > on a particular unreleased Lucene version then releasing > Solr would still mean you need some kind of > "public" pinned Lucene release for the > Mavenworld. Can we then update the submodule to point to the release tag or sha that Lucene got

Re: Proposal to pin the Lucene snapshot version on main

2021-04-30 Thread Dawid Weiss
> Other than literally adding the git submodule, would we do anything else to > modify the gradle build so that or do we (and Jenkinsfile) have to manually > do a step to install Lucene before proceeding? Technically you add a submodule and then make a composite build from Solr side. I can provi

Re: Proposal to pin the Lucene snapshot version on main

2021-04-30 Thread Mike Drob
I think adding git submodule means that we have to add back in all the build code for it. At which point, I'd rather just copy and commit the code they have so we don't have to learn another git system. I've heard submodules don't play nice with Jenkins, but don't have any direct experience with th

Re: Proposal to pin the Lucene snapshot version on main

2021-04-30 Thread David Smiley
Other than literally adding the git submodule, would we do anything else to modify the gradle build so that or do we (and Jenkinsfile) have to manually do a step to install Lucene before proceeding? Manually wouldn't necessarily be bad, even if a first step, considering this is likely to only last

Re: Proposal to pin the Lucene snapshot version on main

2021-04-30 Thread Ishan Chattopadhyaya
Can we give submodules a try for few weeks and then take an informed decision? On Sat, 1 May, 2021, 12:32 am Ishan Chattopadhyaya, < ichattopadhy...@gmail.com> wrote: > I fully support git submodules. +1 dawid. > Most of the problems with it that people complain about, are perceived > problems, n

Re: Proposal to pin the Lucene snapshot version on main

2021-04-30 Thread Ishan Chattopadhyaya
I fully support git submodules. +1 dawid. Most of the problems with it that people complain about, are perceived problems, not real ones. On Fri, 30 Apr, 2021, 10:50 pm Dawid Weiss, wrote: > We've had that discussion before -- this is where git submodules are > excellent to work with - you know

Re: Proposal to pin the Lucene snapshot version on main

2021-04-30 Thread Dawid Weiss
We've had that discussion before -- this is where git submodules are excellent to work with - you know exactly which version you had for each commit... this said, there are other pitfalls to using submodules so it's not all rosy either. On Fri, Apr 30, 2021 at 4:41 PM Mike Drob wrote: > > Note th

Re: Welcome Eric Pugh to the Apache Solr PMC

2021-04-30 Thread Christine Poerschke (BLOOMBERG/ LONDON)
Welcome Eric! From: dev@solr.apache.org At: 04/30/21 12:54:36To: dev@solr.apache.org Subject: Re: Welcome Eric Pugh to the Apache Solr PMC Welcome Eric! Joel Bernstein http://joelsolr.blogspot.com/ On Fri, Apr 30, 2021 at 3:37 AM Dawid Weiss wrote: Sorry to be late to the party but cordial

RE: Proposal to pin the Lucene snapshot version on main

2021-04-30 Thread Uwe Schindler
snapshot version on main > > Solr can build a 9.0.0-solr-20210430 version and push it to internal ASF repo, > can't we? > > Jan > > > 30. apr. 2021 kl. 16:41 skrev Mike Drob : > > > > Note that this happened again last night, and Jason was able to > &g

Re: Proposal to pin the Lucene snapshot version on main

2021-04-30 Thread Jan Høydahl
Solr can build a 9.0.0-solr-20210430 version and push it to internal ASF repo, can't we? Jan > 30. apr. 2021 kl. 16:41 skrev Mike Drob : > > Note that this happened again last night, and Jason was able to > quickly fix it. But it makes things like 'git bisect'

Re: Proposal to pin the Lucene snapshot version on main

2021-04-30 Thread Mike Drob
Note that this happened again last night, and Jason was able to quickly fix it. But it makes things like 'git bisect' impossible to chase a bug because none of the older versions will compile. I don't think we can pin to a SNAPSHOT version because there are no guarantees about how long those versi

Re: Post Tool

2021-04-30 Thread Gus Heck
Proposed edit: https://github.com/apache/solr/pull/109 I'll leave expanding/updating examples with curl to Eric. On Thu, Apr 29, 2021 at 5:06 PM David Smiley wrote: > Documentation needs maintenance long term -- it can say things or show > snippets that aren't true eventually or eventually stop

Re: Welcome Eric Pugh to the Apache Solr PMC

2021-04-30 Thread Joel Bernstein
Welcome Eric! Joel Bernstein http://joelsolr.blogspot.com/ On Fri, Apr 30, 2021 at 3:37 AM Dawid Weiss wrote: > Sorry to be late to the party but cordial congratulations, Eric! > > Dawid > > On Sat, Apr 24, 2021 at 2:19 AM Jan Høydahl > wrote: > > > > I am pleased to announce that Eric Pugh

Re: Welcome Eric Pugh to the Apache Solr PMC

2021-04-30 Thread Dawid Weiss
Sorry to be late to the party but cordial congratulations, Eric! Dawid On Sat, Apr 24, 2021 at 2:19 AM Jan Høydahl wrote: > > I am pleased to announce that Eric Pugh has accepted an invitation to join > the Solr PMC! > > Congratulations, and welcome aboard! > > Jan > ---

Re: Proposal to pin the Lucene snapshot version on main

2021-04-30 Thread Dawid Weiss
But how do you pin to an intermediate version without a snapshot maven repository that would keep those pinned artifacts? Dawid On Thu, Apr 29, 2021 at 9:45 PM David Smiley wrote: > > +1 Jan, that sounds complementary to what I propose. We'd get notifications > via Jenkins that there are some