Re: [VOTE] Release Apache Maven Clean Plugin version 3.5.0

2025-05-28 Thread Hervé Boutemy
+1 Reproducible Build checked ok: reference build done with JDK 21 on *nix Regards, Hervé Le mercredi 28 mai 2025, 00:20:52 CEST Slawomir Jaranowski a écrit : > Hi, > > We solved 6 issues: > https://github.com/apache/maven-clean-plugin/milestone/5?closed=1 > > There are still a couple of issu

Re: Maven 4.0.0 Release - Thoughts?

2025-05-28 Thread Xeno Amess
yep, you can try with jprofiler/jetbrains-profiler/something else and see what be the bottleneck. if the project is...open source, we can have a try too... Xeno Amess 于2025年5月28日周三 17:09写道: > @Sergey Chernov > could you please give a link about the test suites you be using > > Sergey Chernov 于

Re: Maven 4.0.0 Release - Thoughts?

2025-05-28 Thread Xeno Amess
@Sergey Chernov could you please give a link about the test suites you be using Sergey Chernov 于2025年5月27日周二 04:56写道: > Just tried the 4.0.0-rc-3 comparing with 3.9.9, it's 4x times slower (!) on > a project of ~900 modules (700 of them are jar). > Maven 3 builds it in 2m57s, while Maven 4 in 1

Re: Maven 4.0.0 Release - Thoughts?

2025-05-28 Thread Xeno Amess
IMO LinkedHashSet can work, no need to use LinkedHashMap directly... but I still think it better to see the bottle-neck through real-world running. so let's just find some really biggy open source java projects using maven(if can't, maybe we have to craft one?) Martin Desruisseaux 于2025年5月28日周三

Re: Maven 4.0.0 Release - Thoughts?

2025-05-28 Thread Xeno Amess
the biggest I found yet is https://github.com/apache/logging-log4j2.git Xeno Amess 于2025年5月28日周三 17:17写道: > IMO LinkedHashSet can work, no need to use LinkedHashMap directly... > but I still think it better to see the bottle-neck through real-world > running. so let's just find some really biggy

Re: Maven 4.0.0 Release - Thoughts?

2025-05-28 Thread Guillaume Nodet
After considering the concerns about API stability, plugin compatibility, and the performance issues reported by Sergey (4x slower in rc3), I agree with Sylwester, Benjamin, and Elliotte that we should opt for an rc4 to address these issues. My proposal is to release a final release candidate (rc4)

Re: [VOTE] Release Apache Maven Clean Plugin version 3.5.0

2025-05-28 Thread Karl Heinz Marbaise
Hi, +1 from me. Kind regards Karl Heinz Marbaise On 28.05.25 00:20, Slawomir Jaranowski wrote: Hi, We solved 6 issues: https://github.com/apache/maven-clean-plugin/milestone/5?closed=1 There are still a couple of issues left: https://github.com/apache/maven-clean-plugin/issues Changes since

Re: [VOTE] Release Apache Maven Clean Plugin version 3.5.0

2025-05-28 Thread Sylwester Lachiewicz
+1 śr., 28 maj 2025, 14:30 użytkownik Karl Heinz Marbaise napisał: > Hi, > > +1 from me. > > Kind regards > Karl Heinz Marbaise > On 28.05.25 00:20, Slawomir Jaranowski wrote: > > Hi, > > > > We solved 6 issues: > > https://github.com/apache/maven-clean-plugin/milestone/5?closed=1 > > > > There

Re: [VOTE] Release Apache Maven Clean Plugin version 3.5.0

2025-05-28 Thread Elliotte Rusty Harold
I see test failures with Maven 3.9.9. Are these expected to work? Maybe a misconfig somewhere? [ERROR] Failed to execute goal org.apache.maven.plugins:maven-clean-plugin:4.0.0-beta-3-SNAPSHOT:clean (default-clean) on project exclude-default-dirs: The plugin org.apache.maven.plugins:maven-clean-plu

Re: [VOTE] Release Apache Maven Clean Plugin version 3.5.0

2025-05-28 Thread Elliotte Rusty Harold
OK, looks like that was in the 4.0 branch and this is for the 3,x branch. In the 3.x branch there's one unused test dependency that can be removed, nothing serious I can see. On Wed, May 28, 2025 at 12:44 PM Elliotte Rusty Harold wrote: > > I see test failures with Maven 3.9.9. Are these expected

Re: [VOTE] Release Apache Maven Clean Plugin version 3.5.0

2025-05-28 Thread Slawomir Jaranowski
On Wed, 28 May 2025 at 14:46, Elliotte Rusty Harold wrote: > I see test failures with Maven 3.9.9. Are these expected to work? > Maybe a misconfig somewhere? > > [ERROR] Failed to execute goal > org.apache.maven.plugins:maven-clean-plugin:4.0.0-beta-3-SNAPSHOT:clean > (default-clean) on project e

Re: Maven 4.0.0 Release - Thoughts?

2025-05-28 Thread Xeno Amess
jetty is a good example. mvn3 can build but mvn4 cannot. maven-assembly-plugin:3.7.1 wrongly invoking a bom sub-project [INFO] ---< org.eclipse.jetty.ee10:jetty-ee10-bom > [INFO] Building EE10 :: BOM 12.0.22-SNAPSHOT [90/354] [INFO] from jetty-ee10/jetty-ee10-bom/pom

Re: Maven 4.0.0 Release - Thoughts?

2025-05-28 Thread Xeno Amess
I used apache-maven-4.0.0-rc-3 btw. I would have a try at the latest github code version... Xeno Amess 于2025年5月29日周四 14:39写道: > jetty is a good example. > mvn3 can build but mvn4 cannot. > > maven-assembly-plugin:3.7.1 wrongly invoking a bom sub-project > > [INFO] ---< org.eclipse.je

Re: Maven 4.0.0 Release - Thoughts?

2025-05-28 Thread Xeno Amess
nope. neither can the github master latest. Xeno Amess 于2025年5月29日周四 14:40写道: > I used apache-maven-4.0.0-rc-3 btw. I would have a try at the latest > github code version... > > Xeno Amess 于2025年5月29日周四 14:39写道: > >> jetty is a good example. >> mvn3 can build but mvn4 cannot. >> >> maven-assemb

Re: Maven 4.0.0 Release - Thoughts?

2025-05-28 Thread Sergey Chernov
Hey, Delany. I will look into this. Also to avoid confusion let's continue this discussion in the proper thread as it's not related to maven 4 release On Wed, May 28, 2025 at 4:22 PM Delany wrote: > Hi Sergei, > > I'm running with this extension going forward. I don't use the build cache > (yet)

Re: Maven 4.0.0 Release - Thoughts?

2025-05-28 Thread Xeno Amess
I tested log4j2 an hour ago. on my computer mvn3 use 2:00(min), mvn4 use 1:53(min) no much difference. would try test your examples later. Sergey Chernov 于2025年5月28日周三 20:55写道: > Guillaume, that's awesome. It's good that there is no rush with it. > Once I'll have insights, I'll share them. > > X

Re: Maven 4.0.0 Release - Thoughts?

2025-05-28 Thread Sergey Chernov
Guillaume, that's awesome. It's good that there is no rush with it. Once I'll have insights, I'll share them. Xeno, the project I'm checking is private unfortunately. Also this can be quite challenging to find a good Maven multi-module project as a reference for performance testing and compatibili

Re: Maven 4.0.0 Release - Thoughts?

2025-05-28 Thread Gary Gregory
Jetty is a good one as well: https://github.com/jetty/jetty.project Gary On Wed, May 28, 2025, 08:55 Sergey Chernov wrote: > Guillaume, that's awesome. It's good that there is no rush with it. > Once I'll have insights, I'll share them. > > Xeno, the project I'm checking is private unfortunatel

Re: Maven 4.0.0 Release - Thoughts?

2025-05-28 Thread Delany
Hi Sergei, I'm running with this extension going forward. I don't use the build cache (yet) so that's not an issue. When trying to promote unit tests to a company that's resistant its helpful to be able to say the tests won't slow down the build. We have one huge module though (project we're call

Re: [VOTE] Release Apache Maven Clean Plugin version 3.5.0

2025-05-28 Thread Matthias Bünger
+1 (nb) Am 28.05.2025 um 00:20 schrieb Slawomir Jaranowski: Hi, We solved 6 issues: https://github.com/apache/maven-clean-plugin/milestone/5?closed=1 There are still a couple of issues left: https://github.com/apache/maven-clean-plugin/issues Changes since the last release: https://github.com