Re: Proposal: new default directory layout for modular project

2025-05-16 Thread Guillaume Nodet
Well, we just did that for Maven 4 in the pom schema. Not everyone has made the switch yet... It'll take some time. Le ven. 16 mai 2025 à 15:12, Gary Gregory a écrit : > User POV here: I find it confusing that I can't tell when people talk about > a Maven module versus a JPMS module. My knee j

Re: Proposal: Enhance code quality checks with OpenRewrite in addition to Spotless/Checkstyle

2025-05-16 Thread Piotr Żygieło
On Fri, 16 May 2025 at 22:37, Henning Schmiedehausen wrote: > Frankly, posting with a mail address of "me.com.invalid" makes me press schmiedehausen.org.invalid (https://lists.apache.org/api/source.lua?id=kf906zch8lho65q70s92gnw2p1wbt3o7) -- Piotrek ---

Re: [ANN] Apache Maven Changes Plugin 3.0.0-M3 Released

2025-05-16 Thread Henning Schmiedehausen
Is there a way to track which plugins are maven 3 only, maven 3/4 and maven 4 only? Would it make sense to add this to https://maven.apache.org/plugins/ ? -h On Thu, May 15, 2025 at 11:22 PM Slawomir Jaranowski wrote: > The Apache Maven team is pleased to announce the release of the Apache > M

Re: Proposal: Enhance code quality checks with OpenRewrite in addition to Spotless/Checkstyle

2025-05-16 Thread Piotr P. Karwasz
Hi, On 16.05.2025 22:48, Piotr Żygieło wrote: > On Fri, 16 May 2025 at 22:37, Henning Schmiedehausen > wrote: >> Frankly, posting with a mail address of "me.com.invalid" makes me press > > schmiedehausen.org.invalid > > (https://lists.apache.org/api/source.lua?id=kf906zch8lho65q70s92gnw2p1wbt3o

Re: [ANN] Apache Maven Changes Plugin 3.0.0-M3 Released

2025-05-16 Thread Gary Gregory
TY for the release.😀 Gary On Fri, May 16, 2025, 02:22 Slawomir Jaranowski wrote: > The Apache Maven team is pleased to announce the release of the Apache > Maven Changes Plugin, version 3.0.0-M3 > > This plugin is used to inform your users of the changes that have occurred > between different r

Re: Proposal: Enhance code quality checks with OpenRewrite in addition to Spotless/Checkstyle

2025-05-16 Thread Piotr P. Karwasz
Hi all, In Log4j we have used OpenRewrite to fix several inconsistencies between our 2.x and 3.x branches and to remove Java 8 patterns from our Java 17 code. I can sincerely recommend it. While it is still work in progress, our migration guide from Log4j 1 to Log4j 2 will contain OpenRewrite rec

Re: Proposal: Enhance code quality checks with OpenRewrite in addition to Spotless/Checkstyle

2025-05-16 Thread Henning Schmiedehausen
On Fri, May 16, 2025 at 1:43 AM Vincent Potucek wrote: > Dear colleagues, > I am not your colleague. Frankly, posting with a mail address of "me.com.invalid" makes me press "Spam" usually right away. As this message has received some replies from other developers, here is my take: "Vendor spam

Re: Proposal: new default directory layout for modular project

2025-05-16 Thread Andy Law
From: Romain Manni-Bucau Date: Friday, 16 May 2025 at 08:10 To: Maven Developers List Subject: Re: Proposal: new default directory layout for modular project The most natural way is to do parent/moduleX/src/main/java (and siblings) and handle the compiler plugin in parent to be jpms specific, no

Re: Proposal: new default directory layout for modular project

2025-05-16 Thread Guillaume Nodet
This is very unnatural in maven, where all the source code usually resides in the src directory for a given project. Typical maven projets has a number of files in the root, a src directory and the target directory which contains all generated files. Starting to use other directories is much more d

Re: Proposal: new default directory layout for modular project

2025-05-16 Thread Guillaume Nodet
I hope you guys did understand that we're talking only about JPMS modules and only when a give (sub-)project contains more than one JPMS module: https://maven.apache.org/ref/4.0.0-rc-3/apidocs/org/apache/maven/api/model/Source.html#getModule() Le ven. 16 mai 2025 à 14:28, Andy Law a écrit : > F

Re: Proposal: new default directory layout for modular project

2025-05-16 Thread Martin Desruisseaux
Le 2025-05-16 à 14 h 27, Andy Law a écrit : >> The most natural way is to do parent/moduleX/src/main/java (and siblings) >> and handle the compiler plugin in parent to be jpms specific, no technical >> blocker, no maven core change needed > This (^^) just seems so natural, I can’t believe tha

Re: Proposal: new default directory layout for modular project

2025-05-16 Thread Andy Law
Yes, but I still think that there’s no need for this because that edge case could be handled by treating that multi-module JPMS project as a variation on the current multi-module aggregation Later, Andy From: Guillaume Nodet Date: Friday, 16 May 2025 at 13:53 To: Maven Developers List Subjec

Re: Proposal: new default directory layout for modular project

2025-05-16 Thread Andy Law
OK. I see the purpose of the tag now. Instinctively, I would have applied that at the level and mapped one project to one module (and built multiple modules as an aggregation of multiple projects) Later, Andy From: Martin Desruisseaux Date: Friday, 16 May 2025 at 13:58 To: dev@maven.apach

Re: Proposal: new default directory layout for modular project

2025-05-16 Thread Gary Gregory
User POV here: I find it confusing that I can't tell when people talk about a Maven module versus a JPMS module. My knee jerk reaction is that Maven 3 should deprecate its use of "module" in favor of "project" (including XML tags) and Maven 4 only use "module" only for JPMS. 2c, Gary On Fri, May

Re: Proposal: new default directory layout for modular project

2025-05-16 Thread Martin Desruisseaux
Le 2025-05-16 à 15 h 01, Andy Law a écrit : OK. I see the purpose of the tag now. To elaborate on the purpose of : we could argue that javac should be able to discover this information itself by parsing the module-info file. But a single module can have its source files split in many direct

Re: Proposal: new default directory layout for modular project

2025-05-16 Thread Romain Manni-Bucau
Well, you can still use a standard maven layout and map 1-1 with the underlying plugin by configuration. The most natural way is to do parent/moduleX/src/main/java (and siblings) and handle the compiler plugin in parent to be jpms specific, no technical blocker, no maven core change needed. Not su