Incoming PRs related to 'tree' enhancements

2025-03-30 Thread Bear Giles
I've taken the time to look around the other 'tree' classes, or more precisely the '*DependencyNodeVisitor" classes, and noticed that most if not all of them follow the anti-pattern of doing more than one thing in each method. More precisely they mix logic ('what to include') and presentation ('wha

Re: Incoming PRs related to 'tree' enhancements

2025-03-30 Thread Bear Giles
Here's one proposal I mentioned. It would allow the *caller* to eliminate all calls to visit() and endVisit() while maintaining existing behavior. This may allow the callers to drop some now-unnecessary code as well. /** * UpdatedependencyNodeVisitor */ public interface NewDependencyNodeVisitor

Q: does prior contribution to 'archives' also provide jira access for this project?

2025-03-30 Thread Bear Giles
I'm ready to submit some issues + patches and having weird problems with the self-submit process. I have an existing JIRA account, and I've definitely contributed to an Apache project in the past (read-only access to ancient unix backups). When I try to log in it fails but when I try the self-subm

Re: Incoming PRs related to 'tree' enhancements

2025-03-30 Thread Guillaume Nodet
Which project are you targeting exactly ? If you're targeting Maven Core, do you think you could target the new API rather than the resolver one ? https://github.com/apache/maven/blob/master/api/maven-api-core/src/main/java/org/apache/maven/api/Node.java Or are you targeting the resolver ? Le dim

Re: Idea - allow pom to specify expected version for all dependencies in a common single groupId

2025-03-30 Thread Bear Giles
Thanks for the clarification. I'm usually the one pushing for using more plugins in our projects and even I had missed some of these nuances. I was planning to finally revive my blog and one of the ideas was how to improve the CI/CD pipeline. Consistency and avoiding unintentional addition of tran

Re: Incoming PRs related to 'tree' enhancements

2025-03-30 Thread Bear Giles
P.S., another possibility is extending AutoCloseable - the implementation can have endVisit(node) cache the last node seen so it's available to the close() method. There are two benefits to this. The first is that it eliminates the need for a new method. AutoClosable requires 'close()' but that's

[RESULT][VOTE] Apache Maven Surefire 3.5.3 (take 2)

2025-03-30 Thread Olivier Lamy
Hi, Vote has passed with the following result: +1 Matthias, Arnaud, Tibor, Tamas, Olivier Looks like there is enough binding vote. I will continue the release process. Cheers Olivier - To unsubscribe, e-mail: dev-unsubscr...@ma

[RESULT] [VOTE] Release Apache Maven Plugin Testing version 4.0.0-beta-4

2025-03-30 Thread Guillaume Nodet
Closing this vote with 6 +1s. Le mer. 26 mars 2025 à 11:12, Guillaume Nodet a écrit : > Hey, > > This release contains a few changes, mainly an upgrade to Maven > 4.0.0-rc-3 which brought a few incompatible changes in the API and > thus requires this update. This release also updates a few > de

Re: [VOTE] Apache Maven Surefire 3.5.3 (take 2)

2025-03-30 Thread Olivier Lamy
+1 On Fri, 28 Mar 2025 at 10:07, Olivier Lamy wrote: > > Hi, > We fixed 4 issues: > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317927&version=12355687 > > Staged repository: > https://repository.apache.org/content/repositories/maven-2283 > > Staged sources: > https://repos

Re: [VOTE] Release Apache Maven Plugin Testing version 4.0.0-beta-4

2025-03-30 Thread Guillaume Nodet
+1 Le mer. 26 mars 2025 à 11:12, Guillaume Nodet a écrit : > Hey, > > This release contains a few changes, mainly an upgrade to Maven > 4.0.0-rc-3 which brought a few incompatible changes in the API and > thus requires this update. This release also updates a few > dependencies. > > Changes sin

Re: Incoming PRs related to 'tree' enhancements

2025-03-30 Thread Bear Giles
My primary motivation is making the `mvn dependency:tree -DoutputType=dot` output usable. That's why I've been looking at that code - I've used 'dependency' for years. I can definitely look at repeating the effort but unless the existing implementation is going away soon I would prefer to finish m