MavenProject apparent inconsistencies

2024-09-23 Thread Martin Desruisseaux
Hello again In my attempt to add a List to Maven, I got hesitations about what to do with the following file: * https://github.com/apache/maven/blob/master/maven-core/src/main/java/org/apache/maven/project/MavenProject.java This class contains many collections, but I'm not sure if they are

Re: MavenProject apparent inconsistencies

2024-09-23 Thread Martin Desruisseaux
Le 2024-09-23 à 12 h 32, Martin Desruisseaux a écrit : Would it be okay if I modify the implementation with the following goals? * All setter methods make a defensive copy of the given collection, preserving Set order. * All getter methods returns an unmodifiable (but not necessarily

Most significant changes in history with every major release of Maven

2024-09-23 Thread Robert Scholte
Hi all, Within 2 weeks I will do a talk with Maarten about Maven 4. Part of that are some slides about previous major releases that should clearly explain why it was a major release at not the next minor. In short I came with this list: M1 -> M2: (breaking change, migration required)

Re: MavenProject apparent inconsistencies

2024-09-23 Thread Gary Gregory
Speaking of collections... In some code bases I review (not here) a List is often used when a Set would semantically correct. Is there an opportunity in m3 or m4 for such a change? Gary On Mon, Sep 23, 2024, 6:32 AM Martin Desruisseaux < martin.desruisse...@geomatys.com> wrote: > Hello again > >

Re: MavenProject apparent inconsistencies

2024-09-23 Thread Martin Desruisseaux
Le 2024-09-23 à 12 h 53, Gary Gregory a écrit : Speaking of collections... In some code bases I review (not here) a List is often used when a Set would semantically correct. Is there an opportunity in m3 or m4 for such a change? Yes, I also though about that. Especially since I have seen cod

Re: [VOTE] Release Apache Maven Archetype version 3.3.0

2024-09-23 Thread Olivier Lamy
+1 On Mon, 23 Sept 2024 at 07:49, Slawomir Jaranowski wrote: > > Hi, > > We solved 36 issues: > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317122&version=12351178 > > There are still a couple of issues left in JIRA: > https://issues.apache.org/jira/issues/?jql=project%20%3

Re: MavenProject apparent inconsistencies

2024-09-23 Thread Elliotte Rusty Harold
One thing I "learned" when interviewing new grads was that all numbers are ints and all data structures are lists. :-) Any question that required a set, a map, or a floating point number would quickly weed out about 90% of candidates. On Mon, Sep 23, 2024 at 11:08 AM Martin Desruisseaux wrote: >

Re: [VOTE] Release Apache Maven Archetype version 3.3.0

2024-09-23 Thread Giovanni van der Schelde
+1 (non-committer vote) Awesome to see the plugin getting some updates. I've successfully installed and generated some of my archetypes I use during my talk on this subject. On Mon, 23 Sept 2024 at 09:12, Olivier Lamy wrote: > +1 > > On Mon, 23 Sept 2024 at 07:49, Slawomir Jaranowski > wrote:

Re: [VOTE] Release Apache Maven Archetype version 3.3.0

2024-09-23 Thread Tamás Cservenák
+1 On Sun, Sep 22, 2024, 23:48 Slawomir Jaranowski wrote: > Hi, > > We solved 36 issues: > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317122&version=12351178 > > There are still a couple of issues left in JIRA: > > https://issues.apache.org/jira/issues/?jql=project%20%3

Re: [VOTE] Release Apache Maven Archetype version 3.3.0

2024-09-23 Thread Jermaine Hua
+1 Tamás Cservenák 于2024年9月24日 周二06:36写道: > +1 > > On Sun, Sep 22, 2024, 23:48 Slawomir Jaranowski > wrote: > > > Hi, > > > > We solved 36 issues: > > > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317122&version=12351178 > > > > There are still a couple of issues left

Re: Most significant changes in history with every major release of Maven

2024-09-23 Thread Hervé Boutemy
wow, going back to Maven 1, old people need to refresh their memory :) summary looks ok to me, there is only one even more important change from Maven 1 to Maven 2: starting with Maven 2, plugins are not bundled any more in Maven core (Arnaud Héritier, who did the Maven 1.1 release, remembers ho